[PATCH v1] HID: wacom: #include <linux/device-id/hid.h> instead of <linux/mod_devicetable.h>

[PATCH v1] HID: wacom: #include <linux/device-id/hid.h> instead of <linux/mod_devicetable.h>

[Uwe Kleine-König (The Capable Hub)]

The single device-id structure that is used by drivers/hid/wacom.h and
its users (drivers/hid/wacom_sys.c + drivers/hid/wacom_wac.c) is struct
hid_device_id. So #include the much more lightweight
<linux/device-id/hid.h> instead the full <linux/mod_devicetable.h>.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,

there is no coordination needed, just make sure to apply it to v7.2-rc2 or
later. So please take it via the hid tree for the next merge window.

Best regards
Uwe

 drivers/hid/wacom.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/wacom.h b/drivers/hid/wacom.h
index 1deacb4568cb..d2398b1cdbb2 100644
--- a/drivers/hid/wacom.h
+++ b/drivers/hid/wacom.h
@@ -82,7 +82,7 @@
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/module.h>
-#include <linux/mod_devicetable.h>
+#include <linux/device-id/hid.h>
 #include <linux/hid.h>
 #include <linux/kfifo.h>
 #include <linux/leds.h>

base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
-- 
2.55.0.11.g153666a7d9bb

Re: [PATCH v1] HID: wacom: #include <linux/device-id/hid.h> instead of <linux/mod_devicetable.h>

[Ping Cheng]

On Mon, Jul 6, 2026 at 4:39 AM Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@baylibre.com> wrote:
>
> The single device-id structure that is used by drivers/hid/wacom.h and
> its users (drivers/hid/wacom_sys.c + drivers/hid/wacom_wac.c) is struct
> hid_device_id. So #include the much more lightweight
> <linux/device-id/hid.h> instead the full <linux/mod_devicetable.h>.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> there is no coordination needed, just make sure to apply it to v7.2-rc2 or
> later. So please take it via the hid tree for the next merge window.

What's the status of this patch? I don't see it merged into 7.2 or 7.3-rc.

The patch works,
Ping

> Best regards
> Uwe
>
>  drivers/hid/wacom.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom.h b/drivers/hid/wacom.h
> index 1deacb4568cb..d2398b1cdbb2 100644
> --- a/drivers/hid/wacom.h
> +++ b/drivers/hid/wacom.h
> @@ -82,7 +82,7 @@
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/module.h>
> -#include <linux/mod_devicetable.h>
> +#include <linux/device-id/hid.h>
>  #include <linux/hid.h>
>  #include <linux/kfifo.h>
>  #include <linux/leds.h>
>
> base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
> --
> 2.55.0.11.g153666a7d9bb
>
>

Re: [PATCH v1] HID: wacom: #include <linux/device-id/hid.h> instead of <linux/mod_devicetable.h>

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Hello Ping,

On Fri, Sep 11, 2026 at 12:53:29PM -0700, Ping Cheng wrote:
> On Mon, Jul 6, 2026 at 4:39 AM Uwe Kleine-König (The Capable Hub)
> <u.kleine-koenig@baylibre.com> wrote:
> >
> > The single device-id structure that is used by drivers/hid/wacom.h and
> > its users (drivers/hid/wacom_sys.c + drivers/hid/wacom_wac.c) is struct
> > hid_device_id. So #include the much more lightweight
> > <linux/device-id/hid.h> instead the full <linux/mod_devicetable.h>.
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> > ---
> > Hello,
> >
> > there is no coordination needed, just make sure to apply it to v7.2-rc2 or
> > later. So please take it via the hid tree for the next merge window.
> 
> What's the status of this patch? I don't see it merged into 7.2 or 7.3-rc.

It wasn't merged yet. The procedure I'd expect is that the designated
maintainers of the HID Wacom driver (i.e. you and Jason Gerecke) send an
ack and then it get's picked up by Jiri or Benjamin (as HID
maintainers).

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1] HID: wacom: #include <linux/device-id/hid.h> instead of <linux/mod_devicetable.h>

[Ping Cheng]

On Mon, Jul 6, 2026 at 4:39 AM Uwe Kleine-König (The Capable Hub)
<u.kleine-koenig@baylibre.com> wrote:
>
> The single device-id structure that is used by drivers/hid/wacom.h and
> its users (drivers/hid/wacom_sys.c + drivers/hid/wacom_wac.c) is struct
> hid_device_id. So #include the much more lightweight
> <linux/device-id/hid.h> instead the full <linux/mod_devicetable.h>.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Acked-by: Ping Cheng <ping.cheng@wacom.com>
Tested-by: Ping Cheng <ping.cheng@wacom.com>

Cheers,
Ping

> ---
> Hello,
>
> there is no coordination needed, just make sure to apply it to v7.2-rc2 or
> later. So please take it via the hid tree for the next merge window.
>
> Best regards
> Uwe
>
>  drivers/hid/wacom.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom.h b/drivers/hid/wacom.h
> index 1deacb4568cb..d2398b1cdbb2 100644
> --- a/drivers/hid/wacom.h
> +++ b/drivers/hid/wacom.h
> @@ -82,7 +82,7 @@
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/module.h>
> -#include <linux/mod_devicetable.h>
> +#include <linux/device-id/hid.h>
>  #include <linux/hid.h>
>  #include <linux/kfifo.h>
>  #include <linux/leds.h>
>
> base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
> --
> 2.55.0.11.g153666a7d9bb
>
>