From: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
To: "jikos@kernel.org" <jikos@kernel.org>,
"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
"miaoqinglang@huawei.com" <miaoqinglang@huawei.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove_device()
Date: Mon, 21 Sep 2020 14:45:04 +0000 [thread overview]
Message-ID: <ca452e8f61c2e828bc3ec2dc5993f87d251e5e38.camel@intel.com> (raw)
In-Reply-To: <20200921131033.92017-1-miaoqinglang@huawei.com>
On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index c47c3328a..bba29cd36 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -502,8 +502,6 @@ static void ishtp_bus_remove_device(struct
> ishtp_cl_device *device)
> int ishtp_cl_driver_register(struct ishtp_cl_driver *driver,
> struct module *owner)
> {
> - int err;
> -
> if (!ishtp_device_ready)
> return -ENODEV;
>
> @@ -511,11 +509,7 @@ int ishtp_cl_driver_register(struct
> ishtp_cl_driver *driver,
> driver->driver.owner = owner;
> driver->driver.bus = &ishtp_cl_bus_type;
>
> - err = driver_register(&driver->driver);
> - if (err)
> - return err;
> -
> - return 0;
> + return driver_register(&driver->driver);
> }
> EXPORT_SYMBOL(ishtp_cl_driver_register);
>
next prev parent reply other threads:[~2020-09-21 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:10 [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove_device() Qinglang Miao
2020-09-21 14:45 ` Pandruvada, Srinivas [this message]
2020-09-22 9:10 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca452e8f61c2e828bc3ec2dc5993f87d251e5e38.camel@intel.com \
--to=srinivas.pandruvada@intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox