* [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove_device()
@ 2020-09-21 13:10 Qinglang Miao
2020-09-21 14:45 ` Pandruvada, Srinivas
0 siblings, 1 reply; 3+ messages in thread
From: Qinglang Miao @ 2020-09-21 13:10 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, Qinglang Miao
Simplify the return expression.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index c47c3328a..bba29cd36 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -502,8 +502,6 @@ static void ishtp_bus_remove_device(struct ishtp_cl_device *device)
int ishtp_cl_driver_register(struct ishtp_cl_driver *driver,
struct module *owner)
{
- int err;
-
if (!ishtp_device_ready)
return -ENODEV;
@@ -511,11 +509,7 @@ int ishtp_cl_driver_register(struct ishtp_cl_driver *driver,
driver->driver.owner = owner;
driver->driver.bus = &ishtp_cl_bus_type;
- err = driver_register(&driver->driver);
- if (err)
- return err;
-
- return 0;
+ return driver_register(&driver->driver);
}
EXPORT_SYMBOL(ishtp_cl_driver_register);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove_device()
2020-09-21 13:10 [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove_device() Qinglang Miao
@ 2020-09-21 14:45 ` Pandruvada, Srinivas
2020-09-22 9:10 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Pandruvada, Srinivas @ 2020-09-21 14:45 UTC (permalink / raw)
To: jikos@kernel.org, benjamin.tissoires@redhat.com,
miaoqinglang@huawei.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index c47c3328a..bba29cd36 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -502,8 +502,6 @@ static void ishtp_bus_remove_device(struct
> ishtp_cl_device *device)
> int ishtp_cl_driver_register(struct ishtp_cl_driver *driver,
> struct module *owner)
> {
> - int err;
> -
> if (!ishtp_device_ready)
> return -ENODEV;
>
> @@ -511,11 +509,7 @@ int ishtp_cl_driver_register(struct
> ishtp_cl_driver *driver,
> driver->driver.owner = owner;
> driver->driver.bus = &ishtp_cl_bus_type;
>
> - err = driver_register(&driver->driver);
> - if (err)
> - return err;
> -
> - return 0;
> + return driver_register(&driver->driver);
> }
> EXPORT_SYMBOL(ishtp_cl_driver_register);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove_device()
2020-09-21 14:45 ` Pandruvada, Srinivas
@ 2020-09-22 9:10 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2020-09-22 9:10 UTC (permalink / raw)
To: Pandruvada, Srinivas
Cc: benjamin.tissoires@redhat.com, miaoqinglang@huawei.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
On Mon, 21 Sep 2020, Pandruvada, Srinivas wrote:
> On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> > Simplify the return expression.
> >
> > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-21 13:10 [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove_device() Qinglang Miao
2020-09-21 14:45 ` Pandruvada, Srinivas
2020-09-22 9:10 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox