From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Dirk Hohndel <hohndel@linux.intel.com>,
Jeff Garzik <jeff@garzik.org>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
Date: Mon, 29 Oct 2007 08:54:59 -0400 [thread overview]
Message-ID: <d120d5000710290554x618eca05tbf864a0f7f9b77a5@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0710291113450.18815@twin.jikos.cz>
On 10/29/07, Jiri Kosina <jikos@jikos.cz> wrote:
> On Mon, 29 Oct 2007, Dirk Hohndel wrote:
>
> > [INPUT] hidinput_connect incorrectly ignored return value from
> > input_register_device
> > Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
>
> Will apply
Please don't - the fix is completely broken for multi-input devices -
if 2nd device fails to register we bail out of hidinput_connect and
thus never set HID_CLAIMED_INPUT bit. So when we disconnect device we
never call hidinput_disconnect and who knows what will happen after
that.
hidinput_connect() should properly unwind already registered devices
after failure.
--
Dmitry
next prev parent reply other threads:[~2007-10-29 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 6:51 [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device Dirk Hohndel
2007-10-29 7:53 ` Jeff Garzik
2007-10-29 8:49 ` Dirk Hohndel
2007-10-29 9:35 ` Jeff Garzik
2007-10-29 10:14 ` Jiri Kosina
2007-10-29 12:54 ` Dmitry Torokhov [this message]
2007-10-29 12:57 ` Jiri Kosina
2007-10-29 14:49 ` Jeff Garzik
2007-10-29 15:20 ` Dirk Hohndel
2007-10-29 15:33 ` Dmitry Torokhov
2007-10-29 15:38 ` Hohndel, Dirk
2007-10-29 17:11 ` Dmitry Torokhov
2007-10-29 17:28 ` Jiri Kosina
2007-10-29 22:50 ` Dirk Hohndel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000710290554x618eca05tbf864a0f7f9b77a5@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=hohndel@linux.intel.com \
--cc=jeff@garzik.org \
--cc=jikos@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox