* Re: [PATCH v2 09/11] docs: Fix some broken references
From: Charles Keepax @ 2018-05-16 9:09 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Catalin Marinas, Linus Walleij, Will Deacon, dri-devel,
Jaroslav Kysela, Eric Paris, linux-clk, James Morris, Alan Stern,
xen-devel, Boqun Feng, Nicholas Piggin, Sean Paul,
Thomas Gleixner, Antoine Jacquet, Greg Kroah-Hartman, linux-usb,
linux-kernel, Li Zefan, linux-crypto, Mark Rutland, alsa-devel,
Linux Doc Mailing List, David Airlie, Gustavo Padovan
In-Reply-To: <e959f23d6f6905ee606fadfda13e2bb37deed017.1525870886.git.mchehab+samsung@kernel.org>
On Wed, May 09, 2018 at 10:18:52AM -0300, Mauro Carvalho Chehab wrote:
> As we move stuff around, some doc references are broken. Fix some of
> them via this script:
> ./scripts/documentation-file-ref-check --fix-rst
>
> Manually checked if the produced result is valid, removing a few
> false-positives.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> drivers/input/touchscreen/wm97xx-core.c | 2 +-
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply
* Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)
From: Aaron Ma @ 2018-05-16 8:48 UTC (permalink / raw)
To: Teika Kazura, dmitry.torokhov
Cc: benjamin.tissoires, devicetree, linux-input, linux-kernel
In-Reply-To: <20180516.160915.1252752723511457980.teika@gmx.com>
On 05/16/2018 03:09 PM, Teika Kazura wrote:
> From: Aaron Ma <aaron.ma@canonical.com>
> Date: Tue, 17 Apr 2018 19:42:27 +0800
>
>> Could you apply my patch too?
>>
>> It add LEN0096 that Benjamin's patch doesn't include.
>>
>> + "LEN0096", /* X280 */
> Aaron, in your original patch in last Oct [1], both *LEN0092 and* LEN0096 were aded. Which should be the case, both two, or only LEN0096?
Hi Teika:
Both LEN0096/LENO0092 are needed, so I think my original patch should be
merged, Benjamin's patch only include one of them.
Regards,
Aaron
>
> [1] https://www.spinics.net/lists/kernel/msg2625450.html
>
> Teika (Teika kazura)
>
^ permalink raw reply
* Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)
From: Teika Kazura @ 2018-05-16 7:09 UTC (permalink / raw)
To: aaron.ma, dmitry.torokhov
Cc: benjamin.tissoires, devicetree, linux-input, linux-kernel
In-Reply-To: <ca40347e-44cd-aa93-75ba-1bf0a63705be@canonical.com>
From: Aaron Ma <aaron.ma@canonical.com>
Date: Tue, 17 Apr 2018 19:42:27 +0800
> Could you apply my patch too?
>
> It add LEN0096 that Benjamin's patch doesn't include.
>
> + "LEN0096", /* X280 */
Aaron, in your original patch in last Oct [1], both *LEN0092 and* LEN0096 were aded. Which should be the case, both two, or only LEN0096?
[1] https://www.spinics.net/lists/kernel/msg2625450.html
Teika (Teika kazura)
^ permalink raw reply
* Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer
From: Oleksandr Andrushchenko @ 2018-05-16 4:59 UTC (permalink / raw)
To: Juergen Gross, Konrad Rzeszutek Wilk
Cc: xen-devel, dmitry.torokhov, jandryuk, Oleksandr Andrushchenko,
linux-input
In-Reply-To: <86b7b3be-6e49-46b7-beb4-759ee05f90fb@suse.com>
On 05/11/2018 06:15 PM, Juergen Gross wrote:
> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>
>>>> Add missing string constants for {feature|request}-raw-pointer
>>>> to align with the rest of the interface file.
>>>>
>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")
>>>>
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Juergen, you OK with an release-ack?
> Yes:
>
> Release-acked-by: Juergen Gross <jgross@suse.com>
Is this ack for both patches or this one only?
I see Konrad has applied this patch, but
"[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard
and pointer"
is still floating.
>
> Juergen
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply
* Re: [PATCH v2 09/11] docs: Fix some broken references
From: Stephen Boyd @ 2018-05-15 20:26 UTC (permalink / raw)
To: Linux Doc Mailing List
Cc: Catalin Marinas, Will Deacon, dri-devel, Jaroslav Kysela,
Eric Paris, Mauro Carvalho Chehab, linux-clk, James Morris,
Alan Stern, xen-devel, Boqun Feng, Nicholas Piggin,
Thomas Gleixner, Antoine Jacquet, Greg Kroah-Hartman, linux-usb,
linux-kernel, Li Zefan, linux-crypto, Mark Rutland, alsa-devel,
David Airlie, Max Filippov, Harry Wei, selinux
In-Reply-To: <e959f23d6f6905ee606fadfda13e2bb37deed017.1525870886.git.mchehab+samsung@kernel.org>
Quoting Mauro Carvalho Chehab (2018-05-09 06:18:52)
> As we move stuff around, some doc references are broken. Fix some of
> them via this script:
> ./scripts/documentation-file-ref-check --fix-rst
>
> Manually checked if the produced result is valid, removing a few
> false-positives.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> drivers/clk/clk.c | 4 ++--
> drivers/clk/ingenic/cgu.h | 2 +-
Acked-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply
* Re: [PATCH] input: fix coding style issues in input.c
From: Dmitry Torokhov @ 2018-05-15 17:34 UTC (permalink / raw)
To: Nick Simonov; +Cc: rydberg, linux-input, linux-kernel
In-Reply-To: <20180511230120.GA23354@gmail.com>
On Sat, May 12, 2018 at 02:01:20AM +0300, Nick Simonov wrote:
> Wed, May 09, 2018 at 05:33:13PM -0700, Dmitry Torokhov wrote:
> > Hi NIck,
> >
> > On Wed, May 09, 2018 at 05:07:14PM +0300, Nick Simonov wrote:
> > > This is a patch to the input.c file that fixes
> > > up warning found by checkpatch.pl tool
> > >
> > > Signed-off-by: Nick Simonov <nicksimonovv@gmail.com>
> > > ---
> > > drivers/input/input.c | 52 ++++++++++++++++++++++++++++++++-------------------
> > > 1 file changed, 33 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/drivers/input/input.c b/drivers/input/input.c
> > > index 9785546..e18fdae 100644
> > > --- a/drivers/input/input.c
> > > +++ b/drivers/input/input.c
> > > @@ -1,3 +1,4 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > /*
> > > * The input core
> > > *
> > > @@ -252,7 +253,8 @@ static int input_handle_abs_event(struct input_dev *dev,
> > > }
> > >
> > > /* Flush pending "slot" event */
> > > - if (is_mt_event && mt && mt->slot != input_abs_get_val(dev, ABS_MT_SLOT)) {
> > > + if (is_mt_event && mt && mt->slot !=
> > > + input_abs_get_val(dev, ABS_MT_SLOT)) {
> > > input_abs_set_val(dev, ABS_MT_SLOT, mt->slot);
> >
> > So now it is not immediately clear what is part of condition and what is
> > part of body.
> >
> > I am sorry to say, but with most of these changes the cure is worse than
> > the disease. If you were fixing the code and adjusted the affected lines
> > so they are under 80 columns limit that would be one thing, but just
> > reformatting for the sake of it is not really helpful.
> >
> > Thanks.
> >
> > --
> > Dmitry
>
> Dmitry thanks for your comment. I deleted all my changes except one
> and prepare a new patch for it.
>
> In function input_set_capability when it go through default statment
> it is use hard coded function name "input_set_capability" in pr_err() call.
> I replace it using "%s" __func__ instead.
> From 2aef27ca4896b8d9e64fd1417965793acfba3653 Mon Sep 17 00:00:00 2001
> From: Nick Simonov <nicksimonovv@gmail.com>
> Date: Sat, 12 May 2018 01:24:47 +0300
> Subject: [PATCH] input: replace hard coded string with __func__ in pr_err()
>
> Change hardcoded string "input_set_capability"
> in pr_err() function call, replace it with
> "%s" __func__ instead.
>
> Signed-off-by: Nick Simonov <nicksimonovv@gmail.com>
Applied, thank you.
> ---
> drivers/input/input.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index 9785546..6365c19 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -1943,8 +1943,7 @@ void input_set_capability(struct input_dev *dev, unsigned int type, unsigned int
> break;
>
> default:
> - pr_err("input_set_capability: unknown type %u (code %u)\n",
> - type, code);
> + pr_err("%s: unknown type %u (code %u)\n", __func__, type, code);
> dump_stack();
> return;
> }
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply
* Re: [PATCH V3] Input: pm8941-pwrkey: add resin key capabilities
From: Dmitry Torokhov @ 2018-05-15 17:20 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Tirupathi Reddy, robh+dt, mark.rutland, linux-input,
linux-arm-msm, devicetree, linux-kernel
In-Reply-To: <20180507184659.GG2259@tuxbook-pro>
On Mon, May 07, 2018 at 11:46:59AM -0700, Bjorn Andersson wrote:
> On Fri 04 May 17:10 PDT 2018, Dmitry Torokhov wrote:
>
> > Hi Tirupathi,
> >
> > On Fri, Mar 23, 2018 at 11:53:12AM +0530, Tirupathi Reddy wrote:
> > > Add resin key support to handle different types of key events
> > > defined in different platforms.
> > >
> > > Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> > > ---
> > > .../bindings/input/qcom,pm8941-pwrkey.txt | 32 +++++++++
> > > drivers/input/misc/pm8941-pwrkey.c | 81 ++++++++++++++++++++++
> > > 2 files changed, 113 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
> [..]
> > > EXAMPLE
> > >
> > > pwrkey@800 {
> > > @@ -40,4 +66,10 @@ EXAMPLE
> > > interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> > > debounce = <15625>;
> > > bias-pull-up;
> > > +
> > > + resin {
> > > + interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> > > + linux,code = <KEY_VOLUMEDOWN>;
> > > + bias-pull-up;
> > > + };
> > > };
> >
> > The new key and power key bindings are very similar, I would prefer if
> > we shared the parsing code and our new DTS looked like:
> >
> > power {
> > ...
> > };
> >
> > resin {
> > ...
> > };
> >
> > (we can easily keep backward compatibility with power properties being
> > in device node).
> >
>
> As discussed here https://patchwork.kernel.org/patch/9751627/ the PON
> block does, in addition to providing power and resin key support also
> handle the restart reason ("reboot bootloader" in Android).
>
> My interpretation of our conclusion was to come up with a new binding
> for the "pon" and a driver for this block that instantiates the power
> key device.
>
> It seems reasonable for such binding to describe the two keys, as you
> propose here Dmitry, and instantiates the two input devices based on
> this.
OK, I'll wait for the new driver and binding then.
Thanks.
--
Dmitry
^ permalink raw reply
* Re: [PATCH v2 11/11] docs: fix broken references with multiple hints
From: Steven Rostedt @ 2018-05-15 14:52 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Mark Rutland, linux-fbdev, linux-usb, Linux Doc Mailing List,
David Airlie, Linus Walleij, dri-devel, Harry Wei, devel,
Jonathan Corbet, James Morris, Ingo Molnar, linux-input,
Roy Pledge, devicetree, Bartlomiej Zolnierkiewicz, Jiri Kosina,
Mauro Carvalho Chehab, linux-gpio, Rob Herring,
Greg Kroah-Hartman, Dmitry Torokhov, linux-kernel,
linux-security-module, Benjamin
In-Reply-To: <63a4f8a93f9115475bc184d0f37d076c9b9c75ff.1525870886.git.mchehab+samsung@kernel.org>
On Wed, 9 May 2018 10:18:54 -0300
Mauro Carvalho Chehab <mchehab+samsung@kernel.org> wrote:
> diff --git a/Documentation/trace/events.rst b/Documentation/trace/events.rst
> index 7b6b1236ec2e..c292117b83a9 100644
> --- a/Documentation/trace/events.rst
> +++ b/Documentation/trace/events.rst
> @@ -8,7 +8,7 @@ Event Tracing
> 1. Introduction
> ===============
>
> -Tracepoints (see Documentation/trace/tracepoints.txt) can be used
> +Tracepoints (see Documentation/trace/tracepoints.rst) can be used
> without creating custom kernel modules to register probe functions
> using the event tracing infrastructure.
>
> diff --git a/Documentation/trace/tracepoint-analysis.rst b/Documentation/trace/tracepoint-analysis.rst
> index b0c9c21f129d..716326b9f152 100644
> --- a/Documentation/trace/tracepoint-analysis.rst
> +++ b/Documentation/trace/tracepoint-analysis.rst
> @@ -6,7 +6,7 @@ Notes on Analysing Behaviour Using Events and Tracepoints
> 1. Introduction
> ===============
>
> -Tracepoints (see Documentation/trace/tracepoints.txt) can be used without
> +Tracepoints (see Documentation/trace/tracepoints.rst) can be used without
> creating custom kernel modules to register probe functions using the event
> tracing infrastructure.
>
> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> index c94f466d57ef..19a690b559ca 100644
> --- a/include/linux/tracepoint.h
> +++ b/include/linux/tracepoint.h
> @@ -4,7 +4,7 @@
> /*
> * Kernel Tracepoint API.
> *
> - * See Documentation/trace/tracepoints.txt.
> + * See Documentation/trace/tracepoints.rst.
> *
> * Copyright (C) 2008-2014 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> *
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
^ permalink raw reply
* Re: [PATCH] Input: ili251x - add support for Ilitek ILI251x touchscreens
From: Philipp Puschmann @ 2018-05-15 14:31 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: robh, mark.rutland, rydberg, andi, linux-input, devicetree,
linux-kernel
In-Reply-To: <20180509224152.GB91762@dtor-ws>
Hi Dmitry,
hi Rob,
hi Andi,
thank you for your replies and your helpful hints. I will take care of them and
send a V2 of this driver + dt-bindings soon. As i have a working version of this
driver working on it has not a very priority so it may need some time.
Most of your points are correct and don't need further discussion. For the pressure
data i'm unsure, see below.
Am 10.05.2018 um 00:41 schrieb Dmitry Torokhov:
>> The usage of pressure is optional. Touchscreens may deliver constant
>> and so useless pressure data.
>
> Is it dependent on model or what? I would much rather we did not have DT
> property for this.
I don't know. My touchscreen here delivers a constant (useless) pressure of
10. So my chip delivers "something". I'm not sure if the chip always delivers
no real pressure data or if this is dependent from the wiring.
This was the reason i put it in the dt.
Thanks
Philipp
--
Bitte beachten Sie unsere neue Adresse am Göttinger Standort:
emlix GmbH, Gothaer Platz 3, 37083 Göttingen
Philipp Puschmann, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Goettingen HR B 3160
Geschaeftsführung: Heike Jordan, Dr. Uwe Kracke
Ust-IdNr.: DE 205 198 055
emlix - smart embedded open source
^ permalink raw reply
* Re: [PATCH v2 11/11] docs: fix broken references with multiple hints
From: Bartlomiej Zolnierkiewicz @ 2018-05-15 10:28 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Mark Rutland, linux-fbdev, linux-usb, Linux Doc Mailing List,
David Airlie, dri-devel, Harry Wei, devel, Jonathan Corbet,
James Morris, Ingo Molnar, linux-input, Roy Pledge,
Serge E. Hallyn, devicetree, Jiri Kosina, Steven Rostedt,
Mauro Carvalho Chehab, linux-gpio, Rob Herring,
Greg Kroah-Hartman, Dmitry Torokhov, linux-kernel,
linux-security-module, Benjamin Tissoires <benjamin.tissoires@
In-Reply-To: <63a4f8a93f9115475bc184d0f37d076c9b9c75ff.1525870886.git.mchehab+samsung@kernel.org>
On Wednesday, May 09, 2018 10:18:54 AM Mauro Carvalho Chehab wrote:
> The script:
> ./scripts/documentation-file-ref-check --fix-rst
>
> Gives multiple hints for broken references on some files.
> Manually use the one that applies for some files.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> # for fbdev part
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply
* Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD
From: Jarkko Nikula @ 2018-05-15 10:20 UTC (permalink / raw)
To: Chris Chiu
Cc: Daniel Drake, Jian-Hong Pan, Jiri Kosina, Benjamin Tissoires,
Jani Nikula, Hans de Goede, Dmitry Torokhov, Adrian Salido,
Jason Gerecke, linux-input, Andy Shevchenko, Mika Westerberg,
Wolfram Sang, linux-i2c, Linux Kernel, Linux Upstreaming Team
In-Reply-To: <CAB4CAwe6kjJ10s0KtVJrPMSC8UA+YLCiqbnkZ_-oFTKTFPTwCw@mail.gmail.com>
On 05/15/2018 06:22 AM, Chris Chiu wrote:
> What if I change the 120MHz to 180MHz and then make sure that the I2C operates
> in target FS mode frequency 400kHz via scope? Would there be any side effect?
> Maybe some other busses frequency could be also affected and causing some other
> component malfunction?
>
Should be safe. It is only clock rate information when registering a
fixed clock with known rate in intel-lpss.c and i2c-designware uses that
info when calculating the timing parameters. I.e. it doesn't change any
internal clocks.
I'm trying to find a contact who can confirm what is the expected rate
of I2C input clock and is it common to all Cannon Lake HW.
--
Jarkko
^ permalink raw reply
* Re: [PATCH] HID: i2c-hid: check if device is there before really probing
From: Jiri Kosina @ 2018-05-15 9:16 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Benjamin Tissoires, linux-input, linux-kernel, Brian Norris,
Douglas Anderson
In-Reply-To: <20180509191215.77406-1-dmitry.torokhov@gmail.com>
On Wed, 9 May 2018, Dmitry Torokhov wrote:
> From: Dmitry Torokhov <dtor@chromium.org>
>
> On many Chromebooks touch devices are multi-sourced; the components are
> electrically compatible and one can be freely swapped for another without
> changing the OS image or firmware.
>
> To avoid bunch of scary messages when device is not actually present in the
> system let's try testing basic communication with it and if there is no
> response terminate probe early with -ENXIO.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH v9 0/2] hid-steam driver with user mode client dection
From: Jiri Kosina @ 2018-05-15 9:11 UTC (permalink / raw)
To: Rodrigo Rivas Costa
Cc: Benjamin Tissoires, Pierre-Loup A. Griffais,
Clément VUCHENER, Cameron Gutman, lkml, linux-input
In-Reply-To: <20180504101631.GA7496@casa>
On Fri, 4 May 2018, Rodrigo Rivas Costa wrote:
> > If noone has any objections (last chance to raise them), I'll be
> > queuing this for 4.18.
>
> That would be great, thanks!
>
> Now that my distro upgraded to 4.16, without the hid-quirks array, I've been
> testing it a bit more.
>
> It works great, but I've noticed that I've missed a couple of lines when
> creating the client hdev. It doesn't seem to cause any harm, and anyway 'type'
> and 'country' are currently both 0 in my controller; only 'version' is visibly
> different but who uses that?
>
> Anyway, this would be the change, I don't know if it is worth a whole reroll...
I've put this on top of your patches and queued in for-4.18/hid-steam.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD
From: Chris Chiu @ 2018-05-15 3:22 UTC (permalink / raw)
To: Jarkko Nikula
Cc: Daniel Drake, Jian-Hong Pan, Jiri Kosina, Benjamin Tissoires,
Jani Nikula, Hans de Goede, Dmitry Torokhov, Adrian Salido,
Jason Gerecke, linux-input, Andy Shevchenko, Mika Westerberg,
Wolfram Sang, linux-i2c, Linux Kernel, Linux Upstreaming Team
In-Reply-To: <c1343704-6b1a-14b5-3942-a8a33f73feee@linux.intel.com>
On Mon, May 14, 2018 at 10:20 PM, Jarkko Nikula
<jarkko.nikula@linux.intel.com> wrote:
> On 05/10/2018 03:03 PM, Chris Chiu wrote:
>>
>> Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns
>> , HCNT increase to 117, the SCL high duration is 576ns as follows
>> https://pasteboard.co/HkwERvP.png
>>
>> The original SCL high duration (HCNT = 105, 120MHz) is as follows
>> https://pasteboard.co/HkwFxgY.png
>>
>> So the HCNT does affect but per this HCNT/LCNT value, just not 400kHz
>> as expected. Any suggestion?
>>
> Thanks for measurements. I was sidetracked last week so I don't have yet
> explanation why signals run faster than expected :-(
>
> Using 120 MHz SPT I2C clocks in commit b418bbff36dd ("mfd: intel-lpss: Add
> Intel Cannonlake PCI IDs") is clearly wrong but before going to 133 MHz
> (which work for you but still runs too fast) I would like to find
> explanation why it appears to be much higher.
>
> --
> Jarkko
What if I change the 120MHz to 180MHz and then make sure that the I2C operates
in target FS mode frequency 400kHz via scope? Would there be any side effect?
Maybe some other busses frequency could be also affected and causing some other
component malfunction?
Chris
^ permalink raw reply
* Re: [PATCH v3 0/3] ti_am335x_tsc: Fix suspend/resume
From: Vignesh R @ 2018-05-14 15:04 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Grygorii Strashko, linux-input, linux-kernel, linux-omap,
Tony Lindgren
In-Reply-To: <20180424062741.7891-1-vigneshr@ti.com>
On 24-Apr-18 11:57 AM, Vignesh R wrote:
> This patch series fixes couple of issues wrt suspend/resume with TI AM335x
> TSC driver. Disable and clear any pending IRQs before suspend, and
> handle case where TSC wakeup would fail, if there were touch events
> during suspend.
>
>
Gentle ping on this series... Any comments?
> Grygorii Strashko (2):
> Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend
> Input: ti_am335x_tsc - Prevent system suspend when TSC is in use
>
> Vignesh R (1):
> Input: ti_am335x_tsc - Mark IRQ as wakeup capable
>
> drivers/input/touchscreen/ti_am335x_tsc.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
^ permalink raw reply
* [PATCH v3 2/2] Input: xen-kbdfront - allow better run-time configuration
From: Oleksandr Andrushchenko @ 2018-05-14 14:40 UTC (permalink / raw)
To: xen-devel, linux-input, linux-kernel, dmitry.torokhov, jgross,
lyan, boris.ostrovsky
Cc: konrad.wilk, andr2000, andrii_chepurnyi, Oleksandr Andrushchenko
In-Reply-To: <20180514144029.16019-1-andr2000@gmail.com>
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
It is now only possible to control if multi-touch virtual device
is created or not (via the corresponding XenStore entries),
but keyboard and pointer devices are always created.
In some cases this is not desirable. For example, if virtual
keyboard device is exposed to Android then the latter won't
automatically show on-screen keyboard as it expects that a
physical keyboard device can be used for typing.
Utilize keyboard and pointer device XenStore feature fields to
configure which virtual devices are created:
- set "feature-disable-keyboard" to 1 if no keyboard device
needs to be created
- set "feature-disable-pointer" to 1 if no pointer device
needs to be created
Keep old behavior by default.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Suggested-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
Tested-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
---
Changes since v2:
- based on XenStore kbdif features to control which devices are
exposed instead of module parameters.
drivers/input/misc/xen-kbdfront.c | 172 ++++++++++++++++++------------
1 file changed, 101 insertions(+), 71 deletions(-)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index d91f3b1c5375..0f166e11c421 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -63,6 +63,9 @@ static void xenkbd_disconnect_backend(struct xenkbd_info *);
static void xenkbd_handle_motion_event(struct xenkbd_info *info,
struct xenkbd_motion *motion)
{
+ if (unlikely(!info->ptr))
+ return;
+
input_report_rel(info->ptr, REL_X, motion->rel_x);
input_report_rel(info->ptr, REL_Y, motion->rel_y);
if (motion->rel_z)
@@ -73,6 +76,9 @@ static void xenkbd_handle_motion_event(struct xenkbd_info *info,
static void xenkbd_handle_position_event(struct xenkbd_info *info,
struct xenkbd_position *pos)
{
+ if (unlikely(!info->ptr))
+ return;
+
input_report_abs(info->ptr, ABS_X, pos->abs_x);
input_report_abs(info->ptr, ABS_Y, pos->abs_y);
if (pos->rel_z)
@@ -97,6 +103,9 @@ static void xenkbd_handle_key_event(struct xenkbd_info *info,
return;
}
+ if (unlikely(!dev))
+ return;
+
input_event(dev, EV_KEY, key->keycode, value);
input_sync(dev);
}
@@ -192,7 +201,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
const struct xenbus_device_id *id)
{
int ret, i;
- unsigned int abs, touch;
+ bool with_mtouch, with_kbd, with_ptr;
struct xenkbd_info *info;
struct input_dev *kbd, *ptr, *mtouch;
@@ -211,93 +220,114 @@ static int xenkbd_probe(struct xenbus_device *dev,
if (!info->page)
goto error_nomem;
- /* Set input abs params to match backend screen res */
- abs = xenbus_read_unsigned(dev->otherend,
- XENKBD_FIELD_FEAT_ABS_POINTER, 0);
- ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend,
- XENKBD_FIELD_WIDTH,
- ptr_size[KPARAM_X]);
- ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend,
- XENKBD_FIELD_HEIGHT,
- ptr_size[KPARAM_Y]);
- if (abs) {
- ret = xenbus_write(XBT_NIL, dev->nodename,
- XENKBD_FIELD_REQ_ABS_POINTER, "1");
- if (ret) {
- pr_warn("xenkbd: can't request abs-pointer\n");
- abs = 0;
- }
- }
+ /*
+ * The below are reverse logic, e.g. if the feature is set, then
+ * do not expose the corresponding virtual device.
+ */
+ with_kbd = !xenbus_read_unsigned(dev->nodename,
+ XENKBD_FIELD_FEAT_DSBL_KEYBRD, 0);
- touch = xenbus_read_unsigned(dev->nodename,
- XENKBD_FIELD_FEAT_MTOUCH, 0);
- if (touch) {
+ with_ptr = !xenbus_read_unsigned(dev->nodename,
+ XENKBD_FIELD_FEAT_DSBL_POINTER, 0);
+
+ /* Direct logic: if set, then create multi-touch device. */
+ with_mtouch = xenbus_read_unsigned(dev->nodename,
+ XENKBD_FIELD_FEAT_MTOUCH, 0);
+ if (with_mtouch) {
ret = xenbus_write(XBT_NIL, dev->nodename,
XENKBD_FIELD_REQ_MTOUCH, "1");
if (ret) {
pr_warn("xenkbd: can't request multi-touch");
- touch = 0;
+ with_mtouch = 0;
}
}
/* keyboard */
- kbd = input_allocate_device();
- if (!kbd)
- goto error_nomem;
- kbd->name = "Xen Virtual Keyboard";
- kbd->phys = info->phys;
- kbd->id.bustype = BUS_PCI;
- kbd->id.vendor = 0x5853;
- kbd->id.product = 0xffff;
-
- __set_bit(EV_KEY, kbd->evbit);
- for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
- __set_bit(i, kbd->keybit);
- for (i = KEY_OK; i < KEY_MAX; i++)
- __set_bit(i, kbd->keybit);
-
- ret = input_register_device(kbd);
- if (ret) {
- input_free_device(kbd);
- xenbus_dev_fatal(dev, ret, "input_register_device(kbd)");
- goto error;
+ if (with_kbd) {
+ kbd = input_allocate_device();
+ if (!kbd)
+ goto error_nomem;
+ kbd->name = "Xen Virtual Keyboard";
+ kbd->phys = info->phys;
+ kbd->id.bustype = BUS_PCI;
+ kbd->id.vendor = 0x5853;
+ kbd->id.product = 0xffff;
+
+ __set_bit(EV_KEY, kbd->evbit);
+ for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
+ __set_bit(i, kbd->keybit);
+ for (i = KEY_OK; i < KEY_MAX; i++)
+ __set_bit(i, kbd->keybit);
+
+ ret = input_register_device(kbd);
+ if (ret) {
+ input_free_device(kbd);
+ xenbus_dev_fatal(dev, ret,
+ "input_register_device(kbd)");
+ goto error;
+ }
+ info->kbd = kbd;
}
- info->kbd = kbd;
/* pointing device */
- ptr = input_allocate_device();
- if (!ptr)
- goto error_nomem;
- ptr->name = "Xen Virtual Pointer";
- ptr->phys = info->phys;
- ptr->id.bustype = BUS_PCI;
- ptr->id.vendor = 0x5853;
- ptr->id.product = 0xfffe;
-
- if (abs) {
- __set_bit(EV_ABS, ptr->evbit);
- input_set_abs_params(ptr, ABS_X, 0, ptr_size[KPARAM_X], 0, 0);
- input_set_abs_params(ptr, ABS_Y, 0, ptr_size[KPARAM_Y], 0, 0);
- } else {
- input_set_capability(ptr, EV_REL, REL_X);
- input_set_capability(ptr, EV_REL, REL_Y);
- }
- input_set_capability(ptr, EV_REL, REL_WHEEL);
+ if (with_ptr) {
+ unsigned int abs;
+
+ /* Set input abs params to match backend screen res */
+ abs = xenbus_read_unsigned(dev->otherend,
+ XENKBD_FIELD_FEAT_ABS_POINTER, 0);
+ ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend,
+ XENKBD_FIELD_WIDTH,
+ ptr_size[KPARAM_X]);
+ ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend,
+ XENKBD_FIELD_HEIGHT,
+ ptr_size[KPARAM_Y]);
+ if (abs) {
+ ret = xenbus_write(XBT_NIL, dev->nodename,
+ XENKBD_FIELD_REQ_ABS_POINTER, "1");
+ if (ret) {
+ pr_warn("xenkbd: can't request abs-pointer\n");
+ abs = 0;
+ }
+ }
- __set_bit(EV_KEY, ptr->evbit);
- for (i = BTN_LEFT; i <= BTN_TASK; i++)
- __set_bit(i, ptr->keybit);
+ ptr = input_allocate_device();
+ if (!ptr)
+ goto error_nomem;
+ ptr->name = "Xen Virtual Pointer";
+ ptr->phys = info->phys;
+ ptr->id.bustype = BUS_PCI;
+ ptr->id.vendor = 0x5853;
+ ptr->id.product = 0xfffe;
+
+ if (abs) {
+ __set_bit(EV_ABS, ptr->evbit);
+ input_set_abs_params(ptr, ABS_X, 0,
+ ptr_size[KPARAM_X], 0, 0);
+ input_set_abs_params(ptr, ABS_Y, 0,
+ ptr_size[KPARAM_Y], 0, 0);
+ } else {
+ input_set_capability(ptr, EV_REL, REL_X);
+ input_set_capability(ptr, EV_REL, REL_Y);
+ }
+ input_set_capability(ptr, EV_REL, REL_WHEEL);
- ret = input_register_device(ptr);
- if (ret) {
- input_free_device(ptr);
- xenbus_dev_fatal(dev, ret, "input_register_device(ptr)");
- goto error;
+ __set_bit(EV_KEY, ptr->evbit);
+ for (i = BTN_LEFT; i <= BTN_TASK; i++)
+ __set_bit(i, ptr->keybit);
+
+ ret = input_register_device(ptr);
+ if (ret) {
+ input_free_device(ptr);
+ xenbus_dev_fatal(dev, ret,
+ "input_register_device(ptr)");
+ goto error;
+ }
+ info->ptr = ptr;
}
- info->ptr = ptr;
/* multi-touch device */
- if (touch) {
+ if (with_mtouch) {
int num_cont, width, height;
mtouch = input_allocate_device();
--
2.17.0
^ permalink raw reply related
* [PATCH v3 1/2] xen/kbdif: Sync up with the canonical definition in Xen
From: Oleksandr Andrushchenko @ 2018-05-14 14:40 UTC (permalink / raw)
To: xen-devel, linux-input, linux-kernel, dmitry.torokhov, jgross,
lyan, boris.ostrovsky
Cc: konrad.wilk, andr2000, andrii_chepurnyi, Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
This is the sync up with the canonical definition of the keyboard
protocol in Xen:
1. Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to individually
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs
to be created
- set feature-disable-pointer to 1 if no pointer device needs
to be created
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
include/xen/interface/io/kbdif.h | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/include/xen/interface/io/kbdif.h b/include/xen/interface/io/kbdif.h
index 2a9510ade701..808ef7d02a65 100644
--- a/include/xen/interface/io/kbdif.h
+++ b/include/xen/interface/io/kbdif.h
@@ -51,6 +51,18 @@
* corresponding entries in XenStore and puts 1 as the value of the entry.
* If a feature is not supported then 0 must be set or feature entry omitted.
*
+ * feature-disable-keyboard
+ * Values: <uint>
+ *
+ * If there is no need to expose a virtual keyboard device by the
+ * frontend then this must be set to 1.
+ *
+ * feature-disable-pointer
+ * Values: <uint>
+ *
+ * If there is no need to expose a virtual pointer device by the
+ * frontend then this must be set to 1.
+ *
* feature-abs-pointer
* Values: <uint>
*
@@ -63,6 +75,13 @@
* Backends, which support reporting of multi-touch events
* should set this to 1.
*
+ * feature-raw-pointer
+ * Values: <uint>
+ *
+ * Backends, which support reporting raw (unscaled) absolute coordinates
+ * for pointer devices should set this to 1. Raw (unscaled) values have
+ * a range of [0, 0x7fff].
+ *
*------------------------- Pointer Device Parameters ------------------------
*
* width
@@ -98,6 +117,13 @@
*
* Request backend to report multi-touch events.
*
+ * request-raw-pointer
+ * Values: <uint>
+ *
+ * Request backend to report raw unscaled absolute pointer coordinates.
+ * This option is only valid if request-abs-pointer is also set.
+ * Raw unscaled coordinates have the range [0, 0x7fff]
+ *
*----------------------- Request Transport Parameters -----------------------
*
* event-channel
@@ -163,9 +189,13 @@
#define XENKBD_DRIVER_NAME "vkbd"
+#define XENKBD_FIELD_FEAT_DSBL_KEYBRD "feature-disable-keyboard"
+#define XENKBD_FIELD_FEAT_DSBL_POINTER "feature-disable-pointer"
#define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer"
+#define XENKBD_FIELD_FEAT_RAW_POINTER "feature-raw-pointer"
#define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch"
#define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer"
+#define XENKBD_FIELD_REQ_RAW_POINTER "request-raw-pointer"
#define XENKBD_FIELD_REQ_MTOUCH "request-multi-touch"
#define XENKBD_FIELD_RING_GREF "page-gref"
#define XENKBD_FIELD_EVT_CHANNEL "event-channel"
--
2.17.0
^ permalink raw reply related
* Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD
From: Jarkko Nikula @ 2018-05-14 14:20 UTC (permalink / raw)
To: Chris Chiu, Daniel Drake
Cc: Jian-Hong Pan, Jiri Kosina, Benjamin Tissoires, Jani Nikula,
Hans de Goede, Dmitry Torokhov, Adrian Salido, Jason Gerecke,
linux-input, Andy Shevchenko, Mika Westerberg, Wolfram Sang,
linux-i2c, Linux Kernel, Linux Upstreaming Team
In-Reply-To: <CAB4CAwd0tN7CaS7YZCo3TZH-DPxt0x6wxyO23v7aBW9MOCtHCw@mail.gmail.com>
On 05/10/2018 03:03 PM, Chris Chiu wrote:
> Report from guys who can access scope. If i2c-sda-falling-time-ns=400ns
> , HCNT increase to 117, the SCL high duration is 576ns as follows
> https://pasteboard.co/HkwERvP.png
>
> The original SCL high duration (HCNT = 105, 120MHz) is as follows
> https://pasteboard.co/HkwFxgY.png
>
> So the HCNT does affect but per this HCNT/LCNT value, just not 400kHz
> as expected. Any suggestion?
>
Thanks for measurements. I was sidetracked last week so I don't have yet
explanation why signals run faster than expected :-(
Using 120 MHz SPT I2C clocks in commit b418bbff36dd ("mfd: intel-lpss:
Add Intel Cannonlake PCI IDs") is clearly wrong but before going to 133
MHz (which work for you but still runs too fast) I would like to find
explanation why it appears to be much higher.
--
Jarkko
^ permalink raw reply
* Re: [PATCH v2 09/11] docs: Fix some broken references
From: Masami Hiramatsu @ 2018-05-14 13:31 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Catalin Marinas, Will Deacon, dri-devel, Jaroslav Kysela,
Eric Paris, linux-clk, James Morris, Alan Stern, xen-devel,
Boqun Feng, Nicholas Piggin, Thomas Gleixner, Antoine Jacquet,
Greg Kroah-Hartman, linux-usb, linux-kernel, Li Zefan,
linux-crypto, Mark Rutland, alsa-devel, Linux Doc Mailing List,
David Airlie, Max Filippov, Harry Wei, selinux, Paul
In-Reply-To: <e959f23d6f6905ee606fadfda13e2bb37deed017.1525870886.git.mchehab+samsung@kernel.org>
On Wed, 9 May 2018 10:18:52 -0300
Mauro Carvalho Chehab <mchehab+samsung@kernel.org> wrote:
> As we move stuff around, some doc references are broken. Fix some of
> them via this script:
> ./scripts/documentation-file-ref-check --fix-rst
>
> Manually checked if the produced result is valid, removing a few
> false-positives.
The part of kprobes and trace_kprobe changes look good to me :)
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> .../admin-guide/kernel-parameters.txt | 4 ++--
> .../bindings/input/rotary-encoder.txt | 2 +-
> Documentation/driver-api/gpio/consumer.rst | 2 +-
> Documentation/kprobes.txt | 4 ++--
> Documentation/trace/coresight.txt | 2 +-
> Documentation/trace/events.rst | 2 +-
> Documentation/trace/ftrace-uses.rst | 2 +-
> Documentation/trace/histogram.txt | 2 +-
> Documentation/trace/intel_th.rst | 2 +-
> Documentation/trace/tracepoint-analysis.rst | 6 +++---
> Documentation/translations/ja_JP/howto.rst | 4 ++--
> .../translations/zh_CN/magic-number.txt | 4 ++--
> .../zh_CN/video4linux/omap3isp.txt | 4 ++--
> MAINTAINERS | 20 +++++++++----------
> arch/Kconfig | 2 +-
> arch/arm/include/asm/cacheflush.h | 2 +-
> arch/arm64/include/asm/cacheflush.h | 2 +-
> arch/microblaze/include/asm/cacheflush.h | 2 +-
> arch/um/Kconfig.um | 2 +-
> arch/unicore32/include/asm/cacheflush.h | 2 +-
> arch/x86/entry/vsyscall/vsyscall_64.c | 2 +-
> arch/xtensa/include/asm/cacheflush.h | 4 ++--
> block/Kconfig | 2 +-
> certs/Kconfig | 2 +-
> crypto/asymmetric_keys/asymmetric_type.c | 2 +-
> crypto/asymmetric_keys/signature.c | 2 +-
> drivers/char/Kconfig | 2 +-
> drivers/clk/clk.c | 4 ++--
> drivers/clk/ingenic/cgu.h | 2 +-
> drivers/gpu/vga/Kconfig | 2 +-
> drivers/gpu/vga/vgaarb.c | 2 +-
> drivers/input/joystick/Kconfig | 10 +++++-----
> drivers/input/joystick/iforce/Kconfig | 2 +-
> drivers/input/joystick/walkera0701.c | 2 +-
> drivers/input/misc/Kconfig | 4 ++--
> drivers/input/misc/rotary_encoder.c | 2 +-
> drivers/input/mouse/Kconfig | 6 +++---
> drivers/input/mouse/alps.c | 2 +-
> drivers/input/touchscreen/wm97xx-core.c | 2 +-
> drivers/lightnvm/pblk-rb.c | 2 +-
> drivers/md/bcache/Kconfig | 2 +-
> drivers/md/bcache/btree.c | 2 +-
> drivers/md/bcache/extents.c | 2 +-
> drivers/media/dvb-core/dvb_ringbuffer.c | 2 +-
> drivers/media/pci/meye/Kconfig | 2 +-
> drivers/media/platform/pxa_camera.c | 4 ++--
> .../soc_camera/sh_mobile_ceu_camera.c | 2 +-
> drivers/media/radio/Kconfig | 2 +-
> drivers/media/radio/si470x/Kconfig | 2 +-
> drivers/media/usb/dvb-usb-v2/lmedm04.c | 2 +-
> drivers/media/usb/zr364xx/Kconfig | 2 +-
> drivers/parport/Kconfig | 6 +++---
> drivers/staging/media/bcm2048/TODO | 2 +-
> include/keys/asymmetric-subtype.h | 2 +-
> include/keys/asymmetric-type.h | 2 +-
> include/linux/assoc_array.h | 2 +-
> include/linux/assoc_array_priv.h | 2 +-
> include/linux/circ_buf.h | 2 +-
> include/linux/ftrace.h | 2 +-
> include/linux/rculist_nulls.h | 2 +-
> include/uapi/linux/prctl.h | 2 +-
> include/xen/interface/io/kbdif.h | 2 +-
> kernel/cgroup/cpuset.c | 2 +-
> kernel/trace/Kconfig | 16 +++++++--------
> lib/Kconfig | 2 +-
> security/selinux/hooks.c | 2 +-
> sound/core/Kconfig | 4 ++--
> sound/drivers/Kconfig | 4 ++--
> sound/pci/Kconfig | 10 +++++-----
> tools/include/uapi/linux/prctl.h | 2 +-
> tools/lib/api/fs/fs.c | 2 +-
> tools/memory-model/README | 10 +++++-----
> tools/perf/util/bpf-prologue.c | 2 +-
> .../config/custom-timeline-functions.cfg | 4 ++--
> 74 files changed, 120 insertions(+), 120 deletions(-)
>
--
Masami Hiramatsu <mhiramat@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply
* Re: [PATCH] HID: i2c-hid: check if device is there before really probing
From: Benjamin Tissoires @ 2018-05-14 8:29 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jiri Kosina, open list:HID CORE LAYER, lkml, Brian Norris,
Douglas Anderson
In-Reply-To: <20180509191215.77406-1-dmitry.torokhov@gmail.com>
On Wed, May 9, 2018 at 9:12 PM, Dmitry Torokhov <dtor@google.com> wrote:
> From: Dmitry Torokhov <dtor@chromium.org>
>
> On many Chromebooks touch devices are multi-sourced; the components are
> electrically compatible and one can be freely swapped for another without
> changing the OS image or firmware.
>
> To avoid bunch of scary messages when device is not actually present in the
> system let's try testing basic communication with it and if there is no
> response terminate probe early with -ENXIO.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> ---
Looks good. Tested on a Dell XPS with an i2c-hid touchpad:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/i2c-hid/i2c-hid.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 7230243b94d30..a59d483ff316a 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1048,6 +1048,14 @@ static int i2c_hid_probe(struct i2c_client *client,
> pm_runtime_enable(&client->dev);
> device_enable_async_suspend(&client->dev);
>
> + /* Make sure there is something at this address */
> + ret = i2c_smbus_read_byte(client);
> + if (ret < 0) {
> + dev_dbg(&client->dev, "nothing at this address: %d\n", ret);
> + ret = -ENXIO;
> + goto err_pm;
> + }
> +
> ret = i2c_hid_fetch_hid_descriptor(ihid);
> if (ret < 0)
> goto err_pm;
> --
> 2.17.0.441.gb46fe60e1d-goog
>
^ permalink raw reply
* Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)
From: Benjamin Tissoires @ 2018-05-14 8:19 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: 廖崇榮, Oliver Haessler, Benjamin Berg,
Rob Herring, devicetree, open list:HID CORE LAYER, lkml, Aaron Ma
In-Reply-To: <ca40347e-44cd-aa93-75ba-1bf0a63705be@canonical.com>
Hi Dmitry,
This is your monthly reminder of the Lenov 80 pending series :)
Could you consider taking this series and Aaron's patch?
Cheers,
Benjamin
On Tue, Apr 17, 2018 at 1:42 PM, Aaron Ma <aaron.ma@canonical.com> wrote:
> Hi Dmitry and Benjamin:
>
> Could you apply my patch too?
>
> It add LEN0096 that Benjamin's patch doesn't include.
>
> + "LEN0096", /* X280 */
>
> Regards,
> Aaron
^ permalink raw reply
* Re: [PATCH v3] Input: add bu21029 touch driver
From: Andy Shevchenko @ 2018-05-13 14:56 UTC (permalink / raw)
To: Mark Jonas
Cc: Dmitry Torokhov, Rob Herring, Mark Rutland, linux-input,
devicetree, Linux Kernel Mailing List, Heiko Schocher, Zhu Yi
In-Reply-To: <1526048528-3613-1-git-send-email-mark.jonas@de.bosch.com>
On Fri, May 11, 2018 at 5:22 PM, Mark Jonas <mark.jonas@de.bosch.com> wrote:
> Add Rohm BU21029 resistive touch panel controller support with I2C
> interface.
> +#include <linux/of.h>
This becomes redundant (see below).
> +#define STOP_DELAY_US 50L
> +#define START_DELAY_MS 2L
> +#define BUF_LEN 8L
No need to use L for such small numbers. Integer promotion is a part
of C standard.
> +#define SCALE_12BIT (1 << 12)
> +#define MAX_12BIT ((1 << 12) - 1)
BIT(12)
GENMASK(11, 0)
> +static int bu21029_touch_report(struct bu21029_ts_data *bu21029)
> +{
> + struct i2c_client *i2c = bu21029->client;
> + u8 buf[BUF_LEN];
> + int error = bu21029_touch_report(bu21029);
> +
Redundant empty line.
> + if (error) {
> + dev_err(&i2c->dev, "failed to report (error: %d)\n", error);
Potential spamming case.
> + return IRQ_NONE;
> + }
> +static void bu21029_stop_chip(struct input_dev *dev)
> +{
> + struct bu21029_ts_data *bu21029 = input_get_drvdata(dev);
> +
> + disable_irq(bu21029->client->irq);
> + del_timer_sync(&bu21029->timer);
> +
> + /* put chip into reset */
> + gpiod_set_value_cansleep(bu21029->reset_gpios, 1);
> + udelay(STOP_DELAY_US);
udelay() ?!
> +}
> +
> +static int bu21029_start_chip(struct input_dev *dev)
> +{
> + u16 hwid;
> +
> + /* take chip out of reset */
> + gpiod_set_value_cansleep(bu21029->reset_gpios, 0);
> + mdelay(START_DELAY_MS);
mdelay()?!
> +
> + error = i2c_smbus_read_i2c_block_data(i2c,
> + BU21029_HWID_REG,
> + 2,
> + (u8 *)&hwid);
> + if (error < 0) {
> + dev_err(&i2c->dev, "failed to read HW ID\n");
> + goto out;
> + }
> +
> + if (cpu_to_be16(hwid) != SUPPORTED_HWID) {
Hmm... Why cpu_to_be16() is required?
> + dev_err(&i2c->dev, "unsupported HW ID 0x%x\n", hwid);
> + error = -ENODEV;
> + goto out;
> + }
> +}
> +static int bu21029_parse_dt(struct bu21029_ts_data *bu21029)
You can get rid of DT requirement by...
> +{
> + struct device *dev = &bu21029->client->dev;
> + struct device_node *np = dev->of_node;
> + u32 val32;
> + int error;
> + if (!np) {
> + dev_err(dev, "no device tree data\n");
> + return -EINVAL;
> + }
(this becomes redundant)
> +
> + bu21029->reset_gpios = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> + if (IS_ERR(bu21029->reset_gpios)) {
> + error = PTR_ERR(bu21029->reset_gpios);
> + if (error != -EPROBE_DEFER)
> + dev_err(dev, "invalid 'reset-gpios':%d\n", error);
> + return error;
> + }
> +
> + if (of_property_read_u32(np, "rohm,x-plate-ohms", &val32)) {
...simple calling device_property_read_u32() instead.
> + dev_err(dev, "invalid 'x-plate-ohms' supplied\n");
> + return -EINVAL;
> + }
> + bu21029->x_plate_ohms = val32;
> +
> + touchscreen_parse_properties(bu21029->in_dev, false, &bu21029->prop);
> +
> + return 0;
> +}
> +#ifdef CONFIG_PM_SLEEP
Instead...
> +static int bu21029_suspend(struct device *dev)
...use __maby_unused annotation.
> +static int bu21029_resume(struct device *dev)
Ditto.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply
* Re: [PATCH v2 09/11] docs: Fix some broken references
From: Takashi Iwai @ 2018-05-13 7:13 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Catalin Marinas, Will Deacon, dri-devel, Jaroslav Kysela,
Eric Paris, linux-clk, James Morris, Alan Stern, xen-devel,
Boqun Feng, Nicholas Piggin, Thomas Gleixner, Antoine Jacquet,
Greg Kroah-Hartman, linux-usb, linux-kernel, Li Zefan,
linux-crypto, Mark Rutland, alsa-devel, Linux Doc Mailing List,
David Airlie, Max Filippov, Harry Wei, selinux, Paul
In-Reply-To: <e959f23d6f6905ee606fadfda13e2bb37deed017.1525870886.git.mchehab+samsung@kernel.org>
On Wed, 09 May 2018 15:18:52 +0200,
Mauro Carvalho Chehab wrote:
>
> As we move stuff around, some doc references are broken. Fix some of
> them via this script:
> ./scripts/documentation-file-ref-check --fix-rst
>
> Manually checked if the produced result is valid, removing a few
> false-positives.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
For sound stuff, feel free to take my ack (if it's not too late):
Acked-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply
* Re: [PATCH] input: fix coding style issues in input.c
From: Nick Simonov @ 2018-05-11 23:01 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: rydberg, linux-input, linux-kernel
In-Reply-To: <20180510003313.GD91762@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 1766 bytes --]
Wed, May 09, 2018 at 05:33:13PM -0700, Dmitry Torokhov wrote:
> Hi NIck,
>
> On Wed, May 09, 2018 at 05:07:14PM +0300, Nick Simonov wrote:
> > This is a patch to the input.c file that fixes
> > up warning found by checkpatch.pl tool
> >
> > Signed-off-by: Nick Simonov <nicksimonovv@gmail.com>
> > ---
> > drivers/input/input.c | 52 ++++++++++++++++++++++++++++++++-------------------
> > 1 file changed, 33 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/input/input.c b/drivers/input/input.c
> > index 9785546..e18fdae 100644
> > --- a/drivers/input/input.c
> > +++ b/drivers/input/input.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> > * The input core
> > *
> > @@ -252,7 +253,8 @@ static int input_handle_abs_event(struct input_dev *dev,
> > }
> >
> > /* Flush pending "slot" event */
> > - if (is_mt_event && mt && mt->slot != input_abs_get_val(dev, ABS_MT_SLOT)) {
> > + if (is_mt_event && mt && mt->slot !=
> > + input_abs_get_val(dev, ABS_MT_SLOT)) {
> > input_abs_set_val(dev, ABS_MT_SLOT, mt->slot);
>
> So now it is not immediately clear what is part of condition and what is
> part of body.
>
> I am sorry to say, but with most of these changes the cure is worse than
> the disease. If you were fixing the code and adjusted the affected lines
> so they are under 80 columns limit that would be one thing, but just
> reformatting for the sake of it is not really helpful.
>
> Thanks.
>
> --
> Dmitry
Dmitry thanks for your comment. I deleted all my changes except one
and prepare a new patch for it.
In function input_set_capability when it go through default statment
it is use hard coded function name "input_set_capability" in pr_err() call.
I replace it using "%s" __func__ instead.
[-- Attachment #2: 0001-input-replace-hard-coded-string-with-__func__-in-pr_.patch --]
[-- Type: text/plain, Size: 950 bytes --]
>From 2aef27ca4896b8d9e64fd1417965793acfba3653 Mon Sep 17 00:00:00 2001
From: Nick Simonov <nicksimonovv@gmail.com>
Date: Sat, 12 May 2018 01:24:47 +0300
Subject: [PATCH] input: replace hard coded string with __func__ in pr_err()
Change hardcoded string "input_set_capability"
in pr_err() function call, replace it with
"%s" __func__ instead.
Signed-off-by: Nick Simonov <nicksimonovv@gmail.com>
---
drivers/input/input.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 9785546..6365c19 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -1943,8 +1943,7 @@ void input_set_capability(struct input_dev *dev, unsigned int type, unsigned int
break;
default:
- pr_err("input_set_capability: unknown type %u (code %u)\n",
- type, code);
+ pr_err("%s: unknown type %u (code %u)\n", __func__, type, code);
dump_stack();
return;
}
--
2.7.4
^ permalink raw reply related
* Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer
From: Juergen Gross @ 2018-05-11 15:15 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Oleksandr Andrushchenko
Cc: xen-devel, dmitry.torokhov, jandryuk, Oleksandr Andrushchenko,
linux-input
In-Reply-To: <20180511133848.GA20566@char.us.oracle.com>
On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> Add missing string constants for {feature|request}-raw-pointer
>>> to align with the rest of the interface file.
>>>
>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>>
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Juergen, you OK with an release-ack?
Yes:
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox