* Re: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.
From: Pali Rohár @ 2019-05-28 7:18 UTC (permalink / raw)
To: Xiaoxiao Liu
Cc: XiaoXiao Liu, dmitry.torokhov@gmail.com, peter.hutterer@who-t.net,
hui.wang@canonical.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, Xiaojian Cao, zhangfp1@lenovo.com,
Naoki Saito
In-Reply-To: <OSBPR01MB4855F61AE28B883CDD87F781DA1E0@OSBPR01MB4855.jpnprd01.prod.outlook.com>
On Tuesday 28 May 2019 01:37:14 Xiaoxiao Liu wrote:
> Add Saito-san.
>
> Hi Hui,
> Does it mean that your device (reported to kernel) sends only trackstick packets and not touchpad?
> -> Yes.
Ok, I think this answers all questions.
So your patch is not correct as it registers "fake" touchpad device even
there is no touchpad at all.
You should fix your patch to not register touchpad input device, in your
case it should register only trackstick device. I suggest to add some
flag which would indicate such device (e.g. ALPS_ONLY_TRACKSTICK).
Also currently kernel exports following names when device has both
trackstick and touchpad: "DualPoint Stick" and "DualPoint TouchPad".
And it exports name "GlidePoint" for touchpad-only device. So to be
consistent you need to also modify this code for trackstick-only device.
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply
* 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.
From: Xiaoxiao Liu @ 2019-05-28 7:55 UTC (permalink / raw)
To: Pali Rohár
Cc: XiaoXiao Liu, dmitry.torokhov@gmail.com, peter.hutterer@who-t.net,
hui.wang@canonical.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, Xiaojian Cao, zhangfp1@lenovo.com,
Naoki Saito, Hideo Kawase
In-Reply-To: <20190528071824.jimhixhtsynzwixe@pali>
Add Kawase-san.
-----邮件原件-----
发件人: Pali Rohár <pali.rohar@gmail.com>
发送时间: Tuesday, May 28, 2019 3:18 PM
收件人: 劉 曉曉 Xiaoxiao Liu <xiaoxiao.liu-1@cn.alps.com>
抄送: XiaoXiao Liu <sliuuxiaonxiao@gmail.com>; dmitry.torokhov@gmail.com; peter.hutterer@who-t.net; hui.wang@canonical.com; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; 曹 曉建 Xiaojian Cao <xiaojian.cao@cn.alps.com>; zhangfp1@lenovo.com; 斉藤 直樹 Naoki Saito <naoki.saito@alpsalpine.com>
主题: Re: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.
On Tuesday 28 May 2019 01:37:14 Xiaoxiao Liu wrote:
> Add Saito-san.
>
> Hi Hui,
> Does it mean that your device (reported to kernel) sends only trackstick packets and not touchpad?
> -> Yes.
Ok, I think this answers all questions.
So your patch is not correct as it registers "fake" touchpad device even there is no touchpad at all.
You should fix your patch to not register touchpad input device, in your case it should register only trackstick device. I suggest to add some flag which would indicate such device (e.g. ALPS_ONLY_TRACKSTICK).
Also currently kernel exports following names when device has both trackstick and touchpad: "DualPoint Stick" and "DualPoint TouchPad".
And it exports name "GlidePoint" for touchpad-only device. So to be consistent you need to also modify this code for trackstick-only device.
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply
* [PATCH] HID: hid-logitech-hidpp: detect wireless lightspeed devices
From: Pedro Vanzella @ 2019-05-28 16:29 UTC (permalink / raw)
To: linux-input; +Cc: Pedro Vanzella, Jiri Kosina, Benjamin Tissoires, linux-kernel
Send a low device index when the device is connected via the lightspeed
receiver so that the receiver will pass the message along to the device
instead of responding. If we don't do that, we end up thinking it's a
hidpp10 device and miss out on all new features available to newer devices.
This will enable correct detection of the following models:
G603, GPro, G305, G613, G900 and G903, and possibly others.
Signed-off-by: Pedro Vanzella <pedro@pedrovanzella.com>
---
drivers/hid/hid-logitech-hidpp.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 72fc9c0566db..621fce141d9f 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -62,6 +62,7 @@ MODULE_PARM_DESC(disable_tap_to_click,
#define HIDPP_QUIRK_CLASS_K400 BIT(2)
#define HIDPP_QUIRK_CLASS_G920 BIT(3)
#define HIDPP_QUIRK_CLASS_K750 BIT(4)
+#define HIDPP_QUIRK_CLASS_LIGHTSPEED BIT(5)
/* bits 2..20 are reserved for classes */
/* #define HIDPP_QUIRK_CONNECT_EVENTS BIT(21) disabled */
@@ -236,7 +237,11 @@ static int __hidpp_send_report(struct hid_device *hdev,
* set the device_index as the receiver, it will be overwritten by
* hid_hw_request if needed
*/
- hidpp_report->device_index = 0xff;
+ if (hidpp->quirks & HIDPP_QUIRK_CLASS_LIGHTSPEED) {
+ hidpp_report->device_index = 0x01;
+ } else {
+ hidpp_report->device_index = 0xff;
+ }
if (hidpp->quirks & HIDPP_QUIRK_FORCE_OUTPUT_REPORTS) {
ret = hid_hw_output_report(hdev, (u8 *)hidpp_report, fields_count);
@@ -3753,6 +3758,9 @@ static const struct hid_device_id hidpp_devices[] = {
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC06B) },
{ /* Logitech G900 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
+ { /* Logitech Gaming Mice over Lightspeed Receiver */
+ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC539),
+ .driver_data = HIDPP_QUIRK_CLASS_LIGHTSPEED },
{ /* Logitech G920 Wheel over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL),
.driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS},
--
2.21.0
^ permalink raw reply related
* hid-related 5.2-rc1 boot hang
From: Dave Hansen @ 2019-05-28 16:43 UTC (permalink / raw)
To: Jiri Kosina, Hans de Goede, Benjamin Tissoires,
open list:HID CORE LAYER, LKML
I have a system that works fine on 5.1. When updating to 5.2-rc1, it
hangs at boot waiting on an instance of systemd-udevd. The kernel
backtrace (https://photos.app.goo.gl/EV8rf7FofWouvdeE8) looks like it's
doing an finit_module() that dives into the hid code and is waiting on a
request_module().
This hang only occurs if I have a particular USB device inserted:
> Bus 001 Device 007: ID 046d:c52b Logitech, Inc. Unifying Receiver
Bisecting the issue points at this (unlikely to be the culprit) commit:
> [161f62cd07fde123fd52bf6d5b6fd6513cca968e] HID: macally: Add support for Macally ikey keyboard
This bisect result is probably just a bisect artifact. The first real,
bad commit is a merge commit: 63b6f0b827d. This commit merges a bunch
of stuff, but includes changes to the hid request_module() code and to
the logitech-hidpp which is the driver for the above device.
I also have a picture of the hang which includes __request_module()
dumping out the string it is passed:
https://photos.app.goo.gl/tUETiCBZHJfKqWPu8
This is easy enough to work around, and the system works fine if I just
unplug the Logitech device and plug it in after boot. But, it would be
nice to figure out what's going wrong. I guess it could easily be some
interaction between systemd, the driver and the request_module() ordering.
^ permalink raw reply
* Re: [PATCH] HID: hid-logitech-hidpp: detect wireless lightspeed devices
From: Benjamin Tissoires @ 2019-05-28 17:07 UTC (permalink / raw)
To: Pedro Vanzella; +Cc: open list:HID CORE LAYER, Jiri Kosina, lkml
In-Reply-To: <20190528162924.32754-1-pedro@pedrovanzella.com>
On Tue, May 28, 2019 at 6:30 PM Pedro Vanzella <pedro@pedrovanzella.com> wrote:
>
> Send a low device index when the device is connected via the lightspeed
> receiver so that the receiver will pass the message along to the device
> instead of responding. If we don't do that, we end up thinking it's a
> hidpp10 device and miss out on all new features available to newer devices.
>
> This will enable correct detection of the following models:
> G603, GPro, G305, G613, G900 and G903, and possibly others.
Thanks for the patch.
However, there is already support for this receiver in Linus' tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-logitech-dj.c?id=f5fb57a74e88bd1788f57bf77d587c91d4dc9d57
With kernel 5.2-rc1, the connected device should already be handled by
hid-logitech-hidpp :)
Cheers,
Benjamin
>
> Signed-off-by: Pedro Vanzella <pedro@pedrovanzella.com>
> ---
> drivers/hid/hid-logitech-hidpp.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 72fc9c0566db..621fce141d9f 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -62,6 +62,7 @@ MODULE_PARM_DESC(disable_tap_to_click,
> #define HIDPP_QUIRK_CLASS_K400 BIT(2)
> #define HIDPP_QUIRK_CLASS_G920 BIT(3)
> #define HIDPP_QUIRK_CLASS_K750 BIT(4)
> +#define HIDPP_QUIRK_CLASS_LIGHTSPEED BIT(5)
>
> /* bits 2..20 are reserved for classes */
> /* #define HIDPP_QUIRK_CONNECT_EVENTS BIT(21) disabled */
> @@ -236,7 +237,11 @@ static int __hidpp_send_report(struct hid_device *hdev,
> * set the device_index as the receiver, it will be overwritten by
> * hid_hw_request if needed
> */
> - hidpp_report->device_index = 0xff;
> + if (hidpp->quirks & HIDPP_QUIRK_CLASS_LIGHTSPEED) {
> + hidpp_report->device_index = 0x01;
> + } else {
> + hidpp_report->device_index = 0xff;
> + }
>
> if (hidpp->quirks & HIDPP_QUIRK_FORCE_OUTPUT_REPORTS) {
> ret = hid_hw_output_report(hdev, (u8 *)hidpp_report, fields_count);
> @@ -3753,6 +3758,9 @@ static const struct hid_device_id hidpp_devices[] = {
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC06B) },
> { /* Logitech G900 Gaming Mouse over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
> + { /* Logitech Gaming Mice over Lightspeed Receiver */
> + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC539),
> + .driver_data = HIDPP_QUIRK_CLASS_LIGHTSPEED },
> { /* Logitech G920 Wheel over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL),
> .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS},
> --
> 2.21.0
>
^ permalink raw reply
* Re: hid-related 5.2-rc1 boot hang
From: Jiri Kosina @ 2019-05-28 17:14 UTC (permalink / raw)
To: Dave Hansen
Cc: Hans de Goede, Benjamin Tissoires, open list:HID CORE LAYER, LKML
In-Reply-To: <2c1684f6-9def-93dc-54ab-888142fd5e71@intel.com>
On Tue, 28 May 2019, Dave Hansen wrote:
> I have a system that works fine on 5.1. When updating to 5.2-rc1, it
> hangs at boot waiting on an instance of systemd-udevd. The kernel
> backtrace (https://photos.app.goo.gl/EV8rf7FofWouvdeE8) looks like it's
> doing an finit_module() that dives into the hid code and is waiting on a
> request_module().
Dave,
thanks for the report.
Just to confirm -- I guess reverting 4ceabaf79 and a025a18fe would work
this around, right?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: hid-related 5.2-rc1 boot hang
From: Benjamin Tissoires @ 2019-05-28 17:45 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Dave Hansen, Hans de Goede, open list:HID CORE LAYER, LKML
In-Reply-To: <nycvar.YFH.7.76.1905281913140.1962@cbobk.fhfr.pm>
On Tue, May 28, 2019 at 7:15 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 28 May 2019, Dave Hansen wrote:
>
> > I have a system that works fine on 5.1. When updating to 5.2-rc1, it
> > hangs at boot waiting on an instance of systemd-udevd. The kernel
> > backtrace (https://photos.app.goo.gl/EV8rf7FofWouvdeE8) looks like it's
> > doing an finit_module() that dives into the hid code and is waiting on a
> > request_module().
>
> Dave,
>
> thanks for the report.
>
> Just to confirm -- I guess reverting 4ceabaf79 and a025a18fe would work
> this around, right?
>
It would be also interesting to know which distribution and which
systemd version you are running (if you are on systemd).
This rings a bell as I recall playing with
request_module/request_firmware a while ago, but Hans convinced me
that no such delay would be induced.
Cheers,
Benjamin
^ permalink raw reply
* Re: hid-related 5.2-rc1 boot hang
From: Dave Hansen @ 2019-05-28 18:11 UTC (permalink / raw)
To: Benjamin Tissoires, Jiri Kosina
Cc: Hans de Goede, open list:HID CORE LAYER, LKML
In-Reply-To: <CAO-hwJJzNAuFbdMVFZ4+h7J=bh6QHr_MioyK2yTV=M5R6CTm=A@mail.gmail.com>
On 5/28/19 10:45 AM, Benjamin Tissoires wrote:
> On Tue, May 28, 2019 at 7:15 PM Jiri Kosina <jikos@kernel.org> wrote:
>> Just to confirm -- I guess reverting 4ceabaf79 and a025a18fe would work
>> this around, right?
Yes, reverting that pair on top of 5.2-rc1 works around the issue.
> It would be also interesting to know which distribution and which
> systemd version you are running (if you are on systemd).
$ systemd --version
systemd 229
+PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVINIT +UTMP
+LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ -LZ4 +SECCOMP +BLKID +ELFUTILS
+KMOD -IDN
on "Ubuntu 16.04.6"
^ permalink raw reply
* Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
From: Harry Cutts @ 2019-05-28 18:13 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: 廖崇榮, Benjamin Tissoires, Rob Herring,
Aaron Ma, Hans de Goede, open list:HID CORE LAYER, lkml,
devicetree, seobrien
In-Reply-To: <20190528012101.GA193221@dtor-ws>
On Mon, 27 May 2019 at 18:21, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> Hi Benjamin, KT,
>
> On Mon, May 27, 2019 at 11:55:01AM +0800, 廖崇榮 wrote:
> > Hi
> >
> > -----Original Message-----
> > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
> > Sent: Friday, May 24, 2019 5:37 PM
> > To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de Goede
> > Cc: open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
> > Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
> >
> > On Tue, May 21, 2019 at 3:28 PM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> > >
> > > The width/height is actually in the same unit than X and Y. So we
> > > should not tamper the data, but just set the proper resolution, so
> > > that userspace can correctly detect which touch is a palm or a finger.
> > >
> > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > >
> > > --
> > >
> > > new in v2
> > > ---
> > > drivers/input/mouse/elan_i2c_core.c | 11 ++++-------
> > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > > b/drivers/input/mouse/elan_i2c_core.c
> > > index 7ff044c6cd11..6f4feedb7765 100644
> > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > @@ -45,7 +45,6 @@
> > > #define DRIVER_NAME "elan_i2c"
> > > #define ELAN_VENDOR_ID 0x04f3
> > > #define ETP_MAX_PRESSURE 255
> > > -#define ETP_FWIDTH_REDUCE 90
> > > #define ETP_FINGER_WIDTH 15
> > > #define ETP_RETRY_COUNT 3
> > >
> > > @@ -915,12 +914,8 @@ static void elan_report_contact(struct elan_tp_data *data,
> > > return;
> > > }
> > >
> > > - /*
> > > - * To avoid treating large finger as palm, let's reduce the
> > > - * width x and y per trace.
> > > - */
> > > - area_x = mk_x * (data->width_x - ETP_FWIDTH_REDUCE);
> > > - area_y = mk_y * (data->width_y - ETP_FWIDTH_REDUCE);
> > > + area_x = mk_x * data->width_x;
> > > + area_y = mk_y * data->width_y;
> > >
> > > major = max(area_x, area_y);
> > > minor = min(area_x, area_y); @@ -1123,8 +1118,10 @@
> > > static int elan_setup_input_device(struct elan_tp_data *data)
> > > ETP_MAX_PRESSURE, 0, 0);
> > > input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0,
> > > ETP_FINGER_WIDTH * max_width, 0, 0);
> > > + input_abs_set_res(input, ABS_MT_TOUCH_MAJOR, data->x_res);
> > > input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0,
> > > ETP_FINGER_WIDTH * min_width, 0, 0);
> > > + input_abs_set_res(input, ABS_MT_TOUCH_MINOR, data->y_res);
> >
> > I had a chat with Peter on Wednesday, and he mentioned that this is dangerous as Major/Minor are max/min of the width and height. And given that we might have 2 different resolutions, we would need to do some computation in the kernel to ensure the data is correct with respect to the resolution.
> >
> > TL;DR: I don't think we should export the resolution there :(
> >
> > KT, should I drop the patch entirely, or is there a strong argument for keeping the ETP_FWIDTH_REDUCE around?
> > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE existed.
> > Our FW team know nothing about ETP_FWIDTH_REDUCE ether.
> >
> > The only side effect will happen on Chromebook because such computation have stayed in ChromeOS' kernel for four years.
> > Chrome's finger/palm threshold may be different from other Linux distribution.
> > We will discuss it with Google once the patch picked by chrome and cause something wrong.
>
> Chrome has logic that contact with maximum major/minor is treated as a
> palm, so here the driver (which originally came from Chrome OS)
> artificially reduces the contact size to ensure that palm rejection
> logic does not trigger.
>
> I'm adding Harry to confirm whether we are still using this logic and to
> see if we can adjust it to be something else.
I'm not very familiar with our touchpad code, so adding Sean O'Brien, who is.
^ permalink raw reply
* Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
From: Sean O'Brien @ 2019-05-29 0:12 UTC (permalink / raw)
To: Harry Cutts
Cc: Dmitry Torokhov, 廖崇榮, Benjamin Tissoires,
Rob Herring, Aaron Ma, Hans de Goede, open list:HID CORE LAYER,
lkml, devicetree
In-Reply-To: <CA+jURcsWe=fZ-catnCaH=A85vAhrv1w1E5nSwpJvBAwgCTNYfw@mail.gmail.com>
We do still use a maxed out major axis as a signal for a palm in the touchscreen
logic, but I'm not too concerned because if that axis is maxed out, the contact
should probably be treated as a palm anyway...
I'm more concerned with this affecting our gesture detection for
touchpad. It looks
like this change would cause all contacts to reported as some percentage bigger
than they are currently. Can you give me an idea of how big that percentage is?
On Tue, May 28, 2019 at 11:13 AM Harry Cutts <hcutts@chromium.org> wrote:
>
> On Mon, 27 May 2019 at 18:21, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >
> > Hi Benjamin, KT,
> >
> > On Mon, May 27, 2019 at 11:55:01AM +0800, 廖崇榮 wrote:
> > > Hi
> > >
> > > -----Original Message-----
> > > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
> > > Sent: Friday, May 24, 2019 5:37 PM
> > > To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de Goede
> > > Cc: open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
> > > Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
> > >
> > > On Tue, May 21, 2019 at 3:28 PM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> > > >
> > > > The width/height is actually in the same unit than X and Y. So we
> > > > should not tamper the data, but just set the proper resolution, so
> > > > that userspace can correctly detect which touch is a palm or a finger.
> > > >
> > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > > >
> > > > --
> > > >
> > > > new in v2
> > > > ---
> > > > drivers/input/mouse/elan_i2c_core.c | 11 ++++-------
> > > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > > > b/drivers/input/mouse/elan_i2c_core.c
> > > > index 7ff044c6cd11..6f4feedb7765 100644
> > > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > > @@ -45,7 +45,6 @@
> > > > #define DRIVER_NAME "elan_i2c"
> > > > #define ELAN_VENDOR_ID 0x04f3
> > > > #define ETP_MAX_PRESSURE 255
> > > > -#define ETP_FWIDTH_REDUCE 90
> > > > #define ETP_FINGER_WIDTH 15
> > > > #define ETP_RETRY_COUNT 3
> > > >
> > > > @@ -915,12 +914,8 @@ static void elan_report_contact(struct elan_tp_data *data,
> > > > return;
> > > > }
> > > >
> > > > - /*
> > > > - * To avoid treating large finger as palm, let's reduce the
> > > > - * width x and y per trace.
> > > > - */
> > > > - area_x = mk_x * (data->width_x - ETP_FWIDTH_REDUCE);
> > > > - area_y = mk_y * (data->width_y - ETP_FWIDTH_REDUCE);
> > > > + area_x = mk_x * data->width_x;
> > > > + area_y = mk_y * data->width_y;
> > > >
> > > > major = max(area_x, area_y);
> > > > minor = min(area_x, area_y); @@ -1123,8 +1118,10 @@
> > > > static int elan_setup_input_device(struct elan_tp_data *data)
> > > > ETP_MAX_PRESSURE, 0, 0);
> > > > input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0,
> > > > ETP_FINGER_WIDTH * max_width, 0, 0);
> > > > + input_abs_set_res(input, ABS_MT_TOUCH_MAJOR, data->x_res);
> > > > input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0,
> > > > ETP_FINGER_WIDTH * min_width, 0, 0);
> > > > + input_abs_set_res(input, ABS_MT_TOUCH_MINOR, data->y_res);
> > >
> > > I had a chat with Peter on Wednesday, and he mentioned that this is dangerous as Major/Minor are max/min of the width and height. And given that we might have 2 different resolutions, we would need to do some computation in the kernel to ensure the data is correct with respect to the resolution.
> > >
> > > TL;DR: I don't think we should export the resolution there :(
> > >
> > > KT, should I drop the patch entirely, or is there a strong argument for keeping the ETP_FWIDTH_REDUCE around?
> > > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE existed.
> > > Our FW team know nothing about ETP_FWIDTH_REDUCE ether.
> > >
> > > The only side effect will happen on Chromebook because such computation have stayed in ChromeOS' kernel for four years.
> > > Chrome's finger/palm threshold may be different from other Linux distribution.
> > > We will discuss it with Google once the patch picked by chrome and cause something wrong.
> >
> > Chrome has logic that contact with maximum major/minor is treated as a
> > palm, so here the driver (which originally came from Chrome OS)
> > artificially reduces the contact size to ensure that palm rejection
> > logic does not trigger.
> >
> > I'm adding Harry to confirm whether we are still using this logic and to
> > see if we can adjust it to be something else.
>
> I'm not very familiar with our touchpad code, so adding Sean O'Brien, who is.
^ permalink raw reply
* Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
From: Benjamin Tissoires @ 2019-05-29 7:16 UTC (permalink / raw)
To: Sean O'Brien, Peter Hutterer
Cc: Harry Cutts, Dmitry Torokhov, 廖崇榮,
Rob Herring, Aaron Ma, Hans de Goede, open list:HID CORE LAYER,
lkml, devicetree
In-Reply-To: <CAOOzhkq+vD034Q2FKB2ryR7Q9nY=iQjdrREuihkZTaVcg+E_Xg@mail.gmail.com>
On Wed, May 29, 2019 at 2:12 AM Sean O'Brien <seobrien@chromium.org> wrote:
>
> We do still use a maxed out major axis as a signal for a palm in the touchscreen
> logic, but I'm not too concerned because if that axis is maxed out, the contact
> should probably be treated as a palm anyway...
>
> I'm more concerned with this affecting our gesture detection for
> touchpad. It looks
> like this change would cause all contacts to reported as some percentage bigger
> than they are currently. Can you give me an idea of how big that percentage is?
On the P52, I currently have:
[ +0.000009] max: (3045,1731) drivers/input/mouse/elan_i2c_core.c:428
[ +0.000003] traces: (24,14) drivers/input/mouse/elan_i2c_core.c:429
-> with the computation done in the kernel:
width_ratio: 126
height_ratio: 123
For my average finger, the reported traces are between 4 and 6:
With the ETP_FWIDTH_REDUCE:
Major between 144 to 216
Minor between 132 to 198
Without:
Major between 504 to 756
Minor between 492 to 738
So a rough augmentation of 350%
For the Synaptics devices (over SMBus), they send the raw value of the
traces, so you will get a major/minor between 2 to 5. Max on these
axes is 15, so we should get the same percentage of value comparing to
the range.
Which is why libinput has a database of which device reports which
pressure/major/minor ranges as otherwise the values are just
impossible to understand.
Cheers,
Benjamin
>
> On Tue, May 28, 2019 at 11:13 AM Harry Cutts <hcutts@chromium.org> wrote:
> >
> > On Mon, 27 May 2019 at 18:21, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > >
> > > Hi Benjamin, KT,
> > >
> > > On Mon, May 27, 2019 at 11:55:01AM +0800, 廖崇榮 wrote:
> > > > Hi
> > > >
> > > > -----Original Message-----
> > > > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
> > > > Sent: Friday, May 24, 2019 5:37 PM
> > > > To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de Goede
> > > > Cc: open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
> > > > Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
> > > >
> > > > On Tue, May 21, 2019 at 3:28 PM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> > > > >
> > > > > The width/height is actually in the same unit than X and Y. So we
> > > > > should not tamper the data, but just set the proper resolution, so
> > > > > that userspace can correctly detect which touch is a palm or a finger.
> > > > >
> > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > > > >
> > > > > --
> > > > >
> > > > > new in v2
> > > > > ---
> > > > > drivers/input/mouse/elan_i2c_core.c | 11 ++++-------
> > > > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > > > >
> > > > > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > > > > b/drivers/input/mouse/elan_i2c_core.c
> > > > > index 7ff044c6cd11..6f4feedb7765 100644
> > > > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > > > @@ -45,7 +45,6 @@
> > > > > #define DRIVER_NAME "elan_i2c"
> > > > > #define ELAN_VENDOR_ID 0x04f3
> > > > > #define ETP_MAX_PRESSURE 255
> > > > > -#define ETP_FWIDTH_REDUCE 90
> > > > > #define ETP_FINGER_WIDTH 15
> > > > > #define ETP_RETRY_COUNT 3
> > > > >
> > > > > @@ -915,12 +914,8 @@ static void elan_report_contact(struct elan_tp_data *data,
> > > > > return;
> > > > > }
> > > > >
> > > > > - /*
> > > > > - * To avoid treating large finger as palm, let's reduce the
> > > > > - * width x and y per trace.
> > > > > - */
> > > > > - area_x = mk_x * (data->width_x - ETP_FWIDTH_REDUCE);
> > > > > - area_y = mk_y * (data->width_y - ETP_FWIDTH_REDUCE);
> > > > > + area_x = mk_x * data->width_x;
> > > > > + area_y = mk_y * data->width_y;
> > > > >
> > > > > major = max(area_x, area_y);
> > > > > minor = min(area_x, area_y); @@ -1123,8 +1118,10 @@
> > > > > static int elan_setup_input_device(struct elan_tp_data *data)
> > > > > ETP_MAX_PRESSURE, 0, 0);
> > > > > input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0,
> > > > > ETP_FINGER_WIDTH * max_width, 0, 0);
> > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MAJOR, data->x_res);
> > > > > input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0,
> > > > > ETP_FINGER_WIDTH * min_width, 0, 0);
> > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MINOR, data->y_res);
> > > >
> > > > I had a chat with Peter on Wednesday, and he mentioned that this is dangerous as Major/Minor are max/min of the width and height. And given that we might have 2 different resolutions, we would need to do some computation in the kernel to ensure the data is correct with respect to the resolution.
> > > >
> > > > TL;DR: I don't think we should export the resolution there :(
> > > >
> > > > KT, should I drop the patch entirely, or is there a strong argument for keeping the ETP_FWIDTH_REDUCE around?
> > > > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE existed.
> > > > Our FW team know nothing about ETP_FWIDTH_REDUCE ether.
> > > >
> > > > The only side effect will happen on Chromebook because such computation have stayed in ChromeOS' kernel for four years.
> > > > Chrome's finger/palm threshold may be different from other Linux distribution.
> > > > We will discuss it with Google once the patch picked by chrome and cause something wrong.
> > >
> > > Chrome has logic that contact with maximum major/minor is treated as a
> > > palm, so here the driver (which originally came from Chrome OS)
> > > artificially reduces the contact size to ensure that palm rejection
> > > logic does not trigger.
> > >
> > > I'm adding Harry to confirm whether we are still using this logic and to
> > > see if we can adjust it to be something else.
> >
> > I'm not very familiar with our touchpad code, so adding Sean O'Brien, who is.
^ permalink raw reply
* Re: hid-related 5.2-rc1 boot hang
From: Hans de Goede @ 2019-05-29 9:17 UTC (permalink / raw)
To: Dave Hansen, Benjamin Tissoires, Jiri Kosina
Cc: open list:HID CORE LAYER, LKML
In-Reply-To: <8a17e6e2-b468-28fd-5b40-0c258ca7efa9@intel.com>
Hi,
On 5/28/19 8:11 PM, Dave Hansen wrote:
> On 5/28/19 10:45 AM, Benjamin Tissoires wrote:
>> On Tue, May 28, 2019 at 7:15 PM Jiri Kosina <jikos@kernel.org> wrote:
>>> Just to confirm -- I guess reverting 4ceabaf79 and a025a18fe would work
>>> this around, right?
>
> Yes, reverting that pair on top of 5.2-rc1 works around the issue.
Thank you for catching this and for testing the reverts. We've several bug
reports which I suspect are related to this.
/sbin/modprobe really should not hang when called by the kernel, as the
kernel does this in several other places too.
At the same time this clearly is a regression, so I'm afraid we will need
to revert the 2 commits.
Benjamin, Jiri, I really like the improvements these 2 commits bring
combined with Benjamin's changes removing the need for all the device specific
drivers to have HID_QUIRK_HAVE_SPECIAL_DRIVER quirk.
Maybe instead of reverting them, we wrap them in a Kconfig option, which
defaults to N, with a warning that this requires an userspace where
/sbin/modprobe does not hang ? It would be useful for the Kconfig
help text if we knew why it hangs. I guess this may have something to do
with it running from the initrd? Maybe this is not the real modprobe but
busybox's modprobe?
Dave, can you try building your initrd without the hid-logitech-dj module
included in the initrd?
Also can you check if your modprobe is provided by module-init-tools
or by kmod ?
I believe we really need more information before we can properly decide
how to deal with this. Luckily we still have same time.
Regards,
Hans
^ permalink raw reply
* RE: [PATCH v2 08/10] Input: elan_i2c - export true width/height
From: 廖崇榮 @ 2019-05-29 12:55 UTC (permalink / raw)
To: 'Benjamin Tissoires', 'Sean O'Brien',
'Peter Hutterer'
Cc: 'Harry Cutts', 'Dmitry Torokhov',
'Rob Herring', 'Aaron Ma',
'Hans de Goede', 'open list:HID CORE LAYER',
'lkml', devicetree
In-Reply-To: <CAO-hwJ+9tnmvD-K3_Ksesdvag1aNbLB7eJxb9ZKb7kM24unqQQ@mail.gmail.com>
-----Original Message-----
From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
Sent: Wednesday, May 29, 2019 3:17 PM
To: Sean O'Brien; Peter Hutterer
Cc: Harry Cutts; Dmitry Torokhov; 廖崇榮; Rob Herring; Aaron Ma; Hans de Goede; open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
On Wed, May 29, 2019 at 2:12 AM Sean O'Brien <seobrien@chromium.org> wrote:
>
> We do still use a maxed out major axis as a signal for a palm in the
> touchscreen logic, but I'm not too concerned because if that axis is
> maxed out, the contact should probably be treated as a palm anyway...
>
> I'm more concerned with this affecting our gesture detection for
> touchpad. It looks like this change would cause all contacts to
> reported as some percentage bigger than they are currently. Can you
> give me an idea of how big that percentage is?
On the P52, I currently have:
[ +0.000009] max: (3045,1731) drivers/input/mouse/elan_i2c_core.c:428
[ +0.000003] traces: (24,14) drivers/input/mouse/elan_i2c_core.c:429
-> with the computation done in the kernel:
width_ratio: 126
height_ratio: 123
For my average finger, the reported traces are between 4 and 6:
With the ETP_FWIDTH_REDUCE:
Major between 144 to 216
Minor between 132 to 198
Without:
Major between 504 to 756
Minor between 492 to 738
So a rough augmentation of 350%
For the Synaptics devices (over SMBus), they send the raw value of the traces, so you will get a major/minor between 2 to 5. Max on these axes is 15, so we should get the same percentage of value comparing to the range.
Elan's vendor report contains such information, which indicate how many trace are touched by finger/palm
mk_x = (finger_data[3] & 0x0f);
mk_y = (finger_data[3] >> 4);
Do we need to use mk_* for major/minor for keeping it consistent with other vendor?
But this modification will impact Chromebook's usability and Chrome test suite.
Which is why libinput has a database of which device reports which pressure/major/minor ranges as otherwise the values are just impossible to understand.
Cheers,
Benjamin
>
> On Tue, May 28, 2019 at 11:13 AM Harry Cutts <hcutts@chromium.org> wrote:
> >
> > On Mon, 27 May 2019 at 18:21, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > >
> > > Hi Benjamin, KT,
> > >
> > > On Mon, May 27, 2019 at 11:55:01AM +0800, 廖崇榮 wrote:
> > > > Hi
> > > >
> > > > -----Original Message-----
> > > > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
> > > > Sent: Friday, May 24, 2019 5:37 PM
> > > > To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de
> > > > Goede
> > > > Cc: open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
> > > > Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true
> > > > width/height
> > > >
> > > > On Tue, May 21, 2019 at 3:28 PM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> > > > >
> > > > > The width/height is actually in the same unit than X and Y. So
> > > > > we should not tamper the data, but just set the proper
> > > > > resolution, so that userspace can correctly detect which touch is a palm or a finger.
> > > > >
> > > > > Signed-off-by: Benjamin Tissoires
> > > > > <benjamin.tissoires@redhat.com>
> > > > >
> > > > > --
> > > > >
> > > > > new in v2
> > > > > ---
> > > > > drivers/input/mouse/elan_i2c_core.c | 11 ++++-------
> > > > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > > > >
> > > > > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > > > > b/drivers/input/mouse/elan_i2c_core.c
> > > > > index 7ff044c6cd11..6f4feedb7765 100644
> > > > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > > > @@ -45,7 +45,6 @@
> > > > > #define DRIVER_NAME "elan_i2c"
> > > > > #define ELAN_VENDOR_ID 0x04f3
> > > > > #define ETP_MAX_PRESSURE 255
> > > > > -#define ETP_FWIDTH_REDUCE 90
> > > > > #define ETP_FINGER_WIDTH 15
> > > > > #define ETP_RETRY_COUNT 3
> > > > >
> > > > > @@ -915,12 +914,8 @@ static void elan_report_contact(struct elan_tp_data *data,
> > > > > return;
> > > > > }
> > > > >
> > > > > - /*
> > > > > - * To avoid treating large finger as palm, let's reduce the
> > > > > - * width x and y per trace.
> > > > > - */
> > > > > - area_x = mk_x * (data->width_x - ETP_FWIDTH_REDUCE);
> > > > > - area_y = mk_y * (data->width_y - ETP_FWIDTH_REDUCE);
> > > > > + area_x = mk_x * data->width_x;
> > > > > + area_y = mk_y * data->width_y;
> > > > >
> > > > > major = max(area_x, area_y);
> > > > > minor = min(area_x, area_y); @@ -1123,8
> > > > > +1118,10 @@ static int elan_setup_input_device(struct elan_tp_data *data)
> > > > > ETP_MAX_PRESSURE, 0, 0);
> > > > > input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0,
> > > > > ETP_FINGER_WIDTH * max_width, 0,
> > > > > 0);
> > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MAJOR,
> > > > > + data->x_res);
> > > > > input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0,
> > > > > ETP_FINGER_WIDTH * min_width, 0,
> > > > > 0);
> > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MINOR,
> > > > > + data->y_res);
> > > >
> > > > I had a chat with Peter on Wednesday, and he mentioned that this is dangerous as Major/Minor are max/min of the width and height. And given that we might have 2 different resolutions, we would need to do some computation in the kernel to ensure the data is correct with respect to the resolution.
> > > >
> > > > TL;DR: I don't think we should export the resolution there :(
> > > >
> > > > KT, should I drop the patch entirely, or is there a strong argument for keeping the ETP_FWIDTH_REDUCE around?
> > > > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE existed.
> > > > Our FW team know nothing about ETP_FWIDTH_REDUCE ether.
> > > >
> > > > The only side effect will happen on Chromebook because such computation have stayed in ChromeOS' kernel for four years.
> > > > Chrome's finger/palm threshold may be different from other Linux distribution.
> > > > We will discuss it with Google once the patch picked by chrome and cause something wrong.
> > >
> > > Chrome has logic that contact with maximum major/minor is treated
> > > as a palm, so here the driver (which originally came from Chrome
> > > OS) artificially reduces the contact size to ensure that palm
> > > rejection logic does not trigger.
> > >
> > > I'm adding Harry to confirm whether we are still using this logic
> > > and to see if we can adjust it to be something else.
> >
> > I'm not very familiar with our touchpad code, so adding Sean
> > O'Brien, who is.
^ permalink raw reply
* Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
From: Benjamin Tissoires @ 2019-05-29 13:16 UTC (permalink / raw)
To: 廖崇榮
Cc: Sean O'Brien, Peter Hutterer, Harry Cutts, Dmitry Torokhov,
Rob Herring, Aaron Ma, Hans de Goede, open list:HID CORE LAYER,
lkml, devicetree
In-Reply-To: <010301d5161d$dd201e70$97605b50$@emc.com.tw>
On Wed, May 29, 2019 at 2:56 PM 廖崇榮 <kt.liao@emc.com.tw> wrote:
>
>
>
> -----Original Message-----
> From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
> Sent: Wednesday, May 29, 2019 3:17 PM
> To: Sean O'Brien; Peter Hutterer
> Cc: Harry Cutts; Dmitry Torokhov; 廖崇榮; Rob Herring; Aaron Ma; Hans de Goede; open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
> Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
>
> On Wed, May 29, 2019 at 2:12 AM Sean O'Brien <seobrien@chromium.org> wrote:
> >
> > We do still use a maxed out major axis as a signal for a palm in the
> > touchscreen logic, but I'm not too concerned because if that axis is
> > maxed out, the contact should probably be treated as a palm anyway...
> >
> > I'm more concerned with this affecting our gesture detection for
> > touchpad. It looks like this change would cause all contacts to
> > reported as some percentage bigger than they are currently. Can you
> > give me an idea of how big that percentage is?
>
> On the P52, I currently have:
> [ +0.000009] max: (3045,1731) drivers/input/mouse/elan_i2c_core.c:428
> [ +0.000003] traces: (24,14) drivers/input/mouse/elan_i2c_core.c:429
>
> -> with the computation done in the kernel:
> width_ratio: 126
> height_ratio: 123
>
> For my average finger, the reported traces are between 4 and 6:
> With the ETP_FWIDTH_REDUCE:
> Major between 144 to 216
> Minor between 132 to 198
>
> Without:
> Major between 504 to 756
> Minor between 492 to 738
>
> So a rough augmentation of 350%
>
> For the Synaptics devices (over SMBus), they send the raw value of the traces, so you will get a major/minor between 2 to 5. Max on these axes is 15, so we should get the same percentage of value comparing to the range.
>
> Elan's vendor report contains such information, which indicate how many trace are touched by finger/palm
> mk_x = (finger_data[3] & 0x0f);
> mk_y = (finger_data[3] >> 4);
> Do we need to use mk_* for major/minor for keeping it consistent with other vendor?
IMO, no. It is better to send something closer to an actual unit
instead of 12,5th of mm.
However, the problem here is that major/minor can be swapped depending
on how the finger is placed (horizontally or vertically), so
unfortunately, if the axes and resolutions are not the same, then we
are screwed, this would just be a value without unit.
> But this modification will impact Chromebook's usability and Chrome test suite.
Yeah, there is no point breaking things just for the fun of it.
Cheers,
Benjamin
>
>
>
> Which is why libinput has a database of which device reports which pressure/major/minor ranges as otherwise the values are just impossible to understand.
>
> Cheers,
> Benjamin
>
>
>
> >
> > On Tue, May 28, 2019 at 11:13 AM Harry Cutts <hcutts@chromium.org> wrote:
> > >
> > > On Mon, 27 May 2019 at 18:21, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > > >
> > > > Hi Benjamin, KT,
> > > >
> > > > On Mon, May 27, 2019 at 11:55:01AM +0800, 廖崇榮 wrote:
> > > > > Hi
> > > > >
> > > > > -----Original Message-----
> > > > > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
> > > > > Sent: Friday, May 24, 2019 5:37 PM
> > > > > To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de
> > > > > Goede
> > > > > Cc: open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
> > > > > Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true
> > > > > width/height
> > > > >
> > > > > On Tue, May 21, 2019 at 3:28 PM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> > > > > >
> > > > > > The width/height is actually in the same unit than X and Y. So
> > > > > > we should not tamper the data, but just set the proper
> > > > > > resolution, so that userspace can correctly detect which touch is a palm or a finger.
> > > > > >
> > > > > > Signed-off-by: Benjamin Tissoires
> > > > > > <benjamin.tissoires@redhat.com>
> > > > > >
> > > > > > --
> > > > > >
> > > > > > new in v2
> > > > > > ---
> > > > > > drivers/input/mouse/elan_i2c_core.c | 11 ++++-------
> > > > > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > > > > > b/drivers/input/mouse/elan_i2c_core.c
> > > > > > index 7ff044c6cd11..6f4feedb7765 100644
> > > > > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > > > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > > > > @@ -45,7 +45,6 @@
> > > > > > #define DRIVER_NAME "elan_i2c"
> > > > > > #define ELAN_VENDOR_ID 0x04f3
> > > > > > #define ETP_MAX_PRESSURE 255
> > > > > > -#define ETP_FWIDTH_REDUCE 90
> > > > > > #define ETP_FINGER_WIDTH 15
> > > > > > #define ETP_RETRY_COUNT 3
> > > > > >
> > > > > > @@ -915,12 +914,8 @@ static void elan_report_contact(struct elan_tp_data *data,
> > > > > > return;
> > > > > > }
> > > > > >
> > > > > > - /*
> > > > > > - * To avoid treating large finger as palm, let's reduce the
> > > > > > - * width x and y per trace.
> > > > > > - */
> > > > > > - area_x = mk_x * (data->width_x - ETP_FWIDTH_REDUCE);
> > > > > > - area_y = mk_y * (data->width_y - ETP_FWIDTH_REDUCE);
> > > > > > + area_x = mk_x * data->width_x;
> > > > > > + area_y = mk_y * data->width_y;
> > > > > >
> > > > > > major = max(area_x, area_y);
> > > > > > minor = min(area_x, area_y); @@ -1123,8
> > > > > > +1118,10 @@ static int elan_setup_input_device(struct elan_tp_data *data)
> > > > > > ETP_MAX_PRESSURE, 0, 0);
> > > > > > input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0,
> > > > > > ETP_FINGER_WIDTH * max_width, 0,
> > > > > > 0);
> > > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MAJOR,
> > > > > > + data->x_res);
> > > > > > input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0,
> > > > > > ETP_FINGER_WIDTH * min_width, 0,
> > > > > > 0);
> > > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MINOR,
> > > > > > + data->y_res);
> > > > >
> > > > > I had a chat with Peter on Wednesday, and he mentioned that this is dangerous as Major/Minor are max/min of the width and height. And given that we might have 2 different resolutions, we would need to do some computation in the kernel to ensure the data is correct with respect to the resolution.
> > > > >
> > > > > TL;DR: I don't think we should export the resolution there :(
> > > > >
> > > > > KT, should I drop the patch entirely, or is there a strong argument for keeping the ETP_FWIDTH_REDUCE around?
> > > > > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE existed.
> > > > > Our FW team know nothing about ETP_FWIDTH_REDUCE ether.
> > > > >
> > > > > The only side effect will happen on Chromebook because such computation have stayed in ChromeOS' kernel for four years.
> > > > > Chrome's finger/palm threshold may be different from other Linux distribution.
> > > > > We will discuss it with Google once the patch picked by chrome and cause something wrong.
> > > >
> > > > Chrome has logic that contact with maximum major/minor is treated
> > > > as a palm, so here the driver (which originally came from Chrome
> > > > OS) artificially reduces the contact size to ensure that palm
> > > > rejection logic does not trigger.
> > > >
> > > > I'm adding Harry to confirm whether we are still using this logic
> > > > and to see if we can adjust it to be something else.
> > >
> > > I'm not very familiar with our touchpad code, so adding Sean
> > > O'Brien, who is.
>
^ permalink raw reply
* Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
From: Peter Hutterer @ 2019-05-30 0:22 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Sean O'Brien, Harry Cutts, Dmitry Torokhov,
廖崇榮, Rob Herring, Aaron Ma, Hans de Goede,
open list:HID CORE LAYER, lkml, devicetree
In-Reply-To: <CAO-hwJ+9tnmvD-K3_Ksesdvag1aNbLB7eJxb9ZKb7kM24unqQQ@mail.gmail.com>
On Wed, May 29, 2019 at 09:16:38AM +0200, Benjamin Tissoires wrote:
> On Wed, May 29, 2019 at 2:12 AM Sean O'Brien <seobrien@chromium.org> wrote:
> >
> > We do still use a maxed out major axis as a signal for a palm in the touchscreen
> > logic, but I'm not too concerned because if that axis is maxed out, the contact
> > should probably be treated as a palm anyway...
> >
> > I'm more concerned with this affecting our gesture detection for
> > touchpad. It looks
> > like this change would cause all contacts to reported as some percentage bigger
> > than they are currently. Can you give me an idea of how big that percentage is?
>
> On the P52, I currently have:
> [ +0.000009] max: (3045,1731) drivers/input/mouse/elan_i2c_core.c:428
> [ +0.000003] traces: (24,14) drivers/input/mouse/elan_i2c_core.c:429
>
> -> with the computation done in the kernel:
> width_ratio: 126
> height_ratio: 123
>
> For my average finger, the reported traces are between 4 and 6:
> With the ETP_FWIDTH_REDUCE:
> Major between 144 to 216
> Minor between 132 to 198
>
> Without:
> Major between 504 to 756
> Minor between 492 to 738
>
> So a rough augmentation of 350%
>
> For the Synaptics devices (over SMBus), they send the raw value of the
> traces, so you will get a major/minor between 2 to 5. Max on these
> axes is 15, so we should get the same percentage of value comparing to
> the range.
> Which is why libinput has a database of which device reports which
> pressure/major/minor ranges as otherwise the values are just
> impossible to understand.
yeah, I've given up on trying to guess finger/thumb/palm sizes.
git grep for these quirk names in libinput for the ranges:
AttrTouchSizeRange
AttrThumbSizeThreshold
AttrPalmSizeThreshold
There are also matching s/Size/Pressure/ entries for touchpads without
major/minor. Looking at the database now, the palm size thresholds range
entries are 5 (Wacom) and a set of 800-1600 for apple touchpads. So yeah,
all this is really a bit random :)
Feel free to steal those entries though and/or add to them where applicable.
Cheers,
Peter
>
> >
> > On Tue, May 28, 2019 at 11:13 AM Harry Cutts <hcutts@chromium.org> wrote:
> > >
> > > On Mon, 27 May 2019 at 18:21, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > > >
> > > > Hi Benjamin, KT,
> > > >
> > > > On Mon, May 27, 2019 at 11:55:01AM +0800, 廖崇榮 wrote:
> > > > > Hi
> > > > >
> > > > > -----Original Message-----
> > > > > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com]
> > > > > Sent: Friday, May 24, 2019 5:37 PM
> > > > > To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de Goede
> > > > > Cc: open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org
> > > > > Subject: Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height
> > > > >
> > > > > On Tue, May 21, 2019 at 3:28 PM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> > > > > >
> > > > > > The width/height is actually in the same unit than X and Y. So we
> > > > > > should not tamper the data, but just set the proper resolution, so
> > > > > > that userspace can correctly detect which touch is a palm or a finger.
> > > > > >
> > > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > > > > >
> > > > > > --
> > > > > >
> > > > > > new in v2
> > > > > > ---
> > > > > > drivers/input/mouse/elan_i2c_core.c | 11 ++++-------
> > > > > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/input/mouse/elan_i2c_core.c
> > > > > > b/drivers/input/mouse/elan_i2c_core.c
> > > > > > index 7ff044c6cd11..6f4feedb7765 100644
> > > > > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > > > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > > > > @@ -45,7 +45,6 @@
> > > > > > #define DRIVER_NAME "elan_i2c"
> > > > > > #define ELAN_VENDOR_ID 0x04f3
> > > > > > #define ETP_MAX_PRESSURE 255
> > > > > > -#define ETP_FWIDTH_REDUCE 90
> > > > > > #define ETP_FINGER_WIDTH 15
> > > > > > #define ETP_RETRY_COUNT 3
> > > > > >
> > > > > > @@ -915,12 +914,8 @@ static void elan_report_contact(struct elan_tp_data *data,
> > > > > > return;
> > > > > > }
> > > > > >
> > > > > > - /*
> > > > > > - * To avoid treating large finger as palm, let's reduce the
> > > > > > - * width x and y per trace.
> > > > > > - */
> > > > > > - area_x = mk_x * (data->width_x - ETP_FWIDTH_REDUCE);
> > > > > > - area_y = mk_y * (data->width_y - ETP_FWIDTH_REDUCE);
> > > > > > + area_x = mk_x * data->width_x;
> > > > > > + area_y = mk_y * data->width_y;
> > > > > >
> > > > > > major = max(area_x, area_y);
> > > > > > minor = min(area_x, area_y); @@ -1123,8 +1118,10 @@
> > > > > > static int elan_setup_input_device(struct elan_tp_data *data)
> > > > > > ETP_MAX_PRESSURE, 0, 0);
> > > > > > input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0,
> > > > > > ETP_FINGER_WIDTH * max_width, 0, 0);
> > > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MAJOR, data->x_res);
> > > > > > input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0,
> > > > > > ETP_FINGER_WIDTH * min_width, 0, 0);
> > > > > > + input_abs_set_res(input, ABS_MT_TOUCH_MINOR, data->y_res);
> > > > >
> > > > > I had a chat with Peter on Wednesday, and he mentioned that this is dangerous as Major/Minor are max/min of the width and height. And given that we might have 2 different resolutions, we would need to do some computation in the kernel to ensure the data is correct with respect to the resolution.
> > > > >
> > > > > TL;DR: I don't think we should export the resolution there :(
> > > > >
> > > > > KT, should I drop the patch entirely, or is there a strong argument for keeping the ETP_FWIDTH_REDUCE around?
> > > > > I suggest you apply the patch, I have no idea why ETP_FWIDTH_REDUCE existed.
> > > > > Our FW team know nothing about ETP_FWIDTH_REDUCE ether.
> > > > >
> > > > > The only side effect will happen on Chromebook because such computation have stayed in ChromeOS' kernel for four years.
> > > > > Chrome's finger/palm threshold may be different from other Linux distribution.
> > > > > We will discuss it with Google once the patch picked by chrome and cause something wrong.
> > > >
> > > > Chrome has logic that contact with maximum major/minor is treated as a
> > > > palm, so here the driver (which originally came from Chrome OS)
> > > > artificially reduces the contact size to ensure that palm rejection
> > > > logic does not trigger.
> > > >
> > > > I'm adding Harry to confirm whether we are still using this logic and to
> > > > see if we can adjust it to be something else.
> > >
> > > I'm not very familiar with our touchpad code, so adding Sean O'Brien, who is.
^ permalink raw reply
* Re: [PATCH] [trivial] HID: Typo s/to back 0/back to 0/
From: Andrej Shadura @ 2019-05-30 9:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel
In-Reply-To: <20190527122532.6084-1-geert+renesas@glider.be>
On 27/05/2019 14:25, Geert Uytterhoeven wrote:
> Fix a silly word ordering typo.
>
> Fixes: 42337b9d4d958daa ("HID: add driver for U2F Zero built-in LED and RNG")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index c3c390ca369022f0..735223f90035b2bf 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -1028,7 +1028,7 @@ config HID_U2FZERO
>
> U2F Zero only supports blinking its LED, so this driver doesn't
> allow setting the brightness to anything but 1, which will
> - trigger a single blink and immediately reset to back 0.
> + trigger a single blink and immediately reset back to 0.
>
> config HID_WACOM
> tristate "Wacom Intuos/Graphire tablet support (USB)"
That was a silly typo indeed :D
Not sure this is needed, but just in case:
Acked-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
--
Cheers,
Andrej
^ permalink raw reply
* Re: hid-related 5.2-rc1 boot hang
From: Dave Hansen @ 2019-05-30 16:56 UTC (permalink / raw)
To: Hans de Goede, Benjamin Tissoires, Jiri Kosina
Cc: open list:HID CORE LAYER, LKML
In-Reply-To: <4689a737-6c40-b4ae-cc38-5df60318adce@redhat.com>
On 5/29/19 2:17 AM, Hans de Goede wrote:
...
> Dave, can you try building your initrd without the hid-logitech-dj module
> included in the initrd?
I did this on a vanilla 5.2-rc2 kernel (without the reverts) and still
experienced the boot hang while the device was inserted.
> Also can you check if your modprobe is provided by module-init-tools
> or by kmod ?
$ dpkg -S `which modprobe`
kmod: /sbin/modprobe
^ permalink raw reply
* [PATCH] drivers: hid: Add a module description line to the hid_hyperv driver
From: Sasha Levin @ 2019-05-30 17:37 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: linux-input, linux-kernel
From: Joseph Salisbury <Joseph.Salisbury@microsoft.com>
This patch only adds a MODULE_DESCRIPTION statement to the driver.
This change is only cosmetic, so there should be no runtime impact.
Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/hid/hid-hyperv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index 704049e62d58a..d3311d714d359 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void)
}
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver");
+
module_init(mousevsc_init);
module_exit(mousevsc_exit);
--
2.20.1
^ permalink raw reply related
* [PATCH] drivers: input: serio: Add a module desription to the hyperv_keyboard driver
From: Sasha Levin @ 2019-05-30 17:46 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel
From: Joseph Salisbury <Joseph.Salisbury@microsoft.com>
This patch only adds a MODULE_DESCRIPTION statement to the driver.
This change is only cosmetic, so there should be no runtime impact.
Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/input/serio/hyperv-keyboard.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c
index a8b9be3e28db7..7935e52b54358 100644
--- a/drivers/input/serio/hyperv-keyboard.c
+++ b/drivers/input/serio/hyperv-keyboard.c
@@ -440,5 +440,7 @@ static void __exit hv_kbd_exit(void)
}
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic Keyboard Driver");
+
module_init(hv_kbd_init);
module_exit(hv_kbd_exit);
--
2.20.1
^ permalink raw reply related
* Re: hid-related 5.2-rc1 boot hang
From: Jiri Kosina @ 2019-05-31 22:15 UTC (permalink / raw)
To: Dave Hansen
Cc: Hans de Goede, Benjamin Tissoires, open list:HID CORE LAYER, LKML
In-Reply-To: <a349dfac-be58-93bd-e44c-080ed935ab06@intel.com>
On Thu, 30 May 2019, Dave Hansen wrote:
> On 5/29/19 2:17 AM, Hans de Goede wrote:
> ...
> > Dave, can you try building your initrd without the hid-logitech-dj module
> > included in the initrd?
>
> I did this on a vanilla 5.2-rc2 kernel (without the reverts) and still
> experienced the boot hang while the device was inserted.
>
> > Also can you check if your modprobe is provided by module-init-tools
> > or by kmod ?
>
> $ dpkg -S `which modprobe`
> kmod: /sbin/modprobe
Benjamin, Hans, are you looking into this?
If not, I think we should start reverting (at least the request_module()
changes, not sure about the rest of logitech issues yet) next week.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] drivers: hid: Add a module description line to the hid_hyperv driver
From: Jiri Kosina @ 2019-05-31 22:19 UTC (permalink / raw)
To: Sasha Levin
Cc: benjamin.tissoires, linux-input, linux-kernel, Joseph Salisbury
In-Reply-To: <20190530173720.17994-1-sashal@kernel.org>
On Thu, 30 May 2019, Sasha Levin wrote:
> From: Joseph Salisbury <Joseph.Salisbury@microsoft.com>
>
> This patch only adds a MODULE_DESCRIPTION statement to the driver.
> This change is only cosmetic, so there should be no runtime impact.
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> drivers/hid/hid-hyperv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index 704049e62d58a..d3311d714d359 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void)
> }
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver");
> +
Is there a reason why you didn't CC Joseph on this submission?
CCing Joseph and applying. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH v3] HID: fix A4Tech horizontal scrolling
From: Jiri Kosina @ 2019-05-31 22:28 UTC (permalink / raw)
To: Błażej Szczygieł
Cc: igorkuo, peter.hutterer, Benjamin Tissoires, linux-input,
linux-kernel
In-Reply-To: <20190512203313.18756-1-spaz16@wp.pl>
On Sun, 12 May 2019, Błażej Szczygieł wrote:
> Since recent high resolution scrolling changes the A4Tech driver must
> check for the "REL_WHEEL_HI_RES" usage code.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203369
> Fixes: 2dc702c991e3774af9d7ce410eef410ca9e2357e ("HID: input: use the
> Resolution Multiplier for high-resolution scrolling")
>
> Signed-off-by: Błażej Szczygieł <spaz16@wp.pl>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply
* Re: [PATCH] drivers: hid: Add a module description line to the hid_hyperv driver
From: Sasha Levin @ 2019-06-01 18:30 UTC (permalink / raw)
To: Jiri Kosina
Cc: benjamin.tissoires, linux-input, linux-kernel, Joseph Salisbury
In-Reply-To: <nycvar.YFH.7.76.1906010018310.1962@cbobk.fhfr.pm>
On Sat, Jun 01, 2019 at 12:19:11AM +0200, Jiri Kosina wrote:
>On Thu, 30 May 2019, Sasha Levin wrote:
>
>> From: Joseph Salisbury <Joseph.Salisbury@microsoft.com>
>>
>> This patch only adds a MODULE_DESCRIPTION statement to the driver.
>> This change is only cosmetic, so there should be no runtime impact.
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
>> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> drivers/hid/hid-hyperv.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
>> index 704049e62d58a..d3311d714d359 100644
>> --- a/drivers/hid/hid-hyperv.c
>> +++ b/drivers/hid/hid-hyperv.c
>> @@ -614,5 +614,7 @@ static void __exit mousevsc_exit(void)
>> }
>>
>> MODULE_LICENSE("GPL");
>> +MODULE_DESCRIPTION("Microsoft Hyper-V Synthetic HID Driver");
>> +
>
>Is there a reason why you didn't CC Joseph on this submission?
Hm, no, I just went with my usual get_maintainers.pl + whomever git
adds. Sorry Joe!
--
Thanks,
Sasha
^ permalink raw reply
* Re: [RFC 0/2] Support for buttons on newer MS Surface devices
From: Maximilian Luz @ 2019-06-01 19:07 UTC (permalink / raw)
Cc: linux-kernel, linux-input, platform-driver-x86, Dmitry Torokhov,
Hans de Goede, Chen Yu, Darren Hart, Andy Shevchenko
In-Reply-To: <20190516142523.117978-1-luzmaximilian@gmail.com>
Hi,
any comments on this?
I should also mention that this has been tested via
https://github.com/jakeday/linux-surface.
Maximilian
On 5/16/19 4:25 PM, Maximilian Luz wrote:
> This series adds suport for power and volume buttons on 5th and 6th
> generation Microsoft Surface devices. Specifically, it adds support for
> the power-button on the Surface Laptop 1 and Laptop 2, as well as
> support for power- and (on-device) volume-buttons on the Surface Pro 5
> (2017), Pro 6, and Book 2.
>
> These devices use the same MSHW0040 device as on the Surface Pro 4,
> however, whereas the Pro 4 uses an ACPI notify handler, the newer
> devices use GPIO interrupts to signal these events.
>
> The first patch of this series ensures that the surfacepro3_button
> driver, used for MSHW0040 on the Pro 4, does not probe for the newer
> devices. The second patch adapts soc_button_array to implement the
> actual button support.
>
> I think the changes to soc_button_array in the second patch warrant a
> thorough review. I've tried to make things a bit more generic to be able
> to integrate arbitrary ACPI GPIO power-/volume-button devices more
> easily, I'm not sure if there may be reasons against this.
>
> Maximilian Luz (2):
> platform: Fix device check for surfacepro3_button
> input: soc_button_array for newer surface devices
>
> drivers/input/misc/soc_button_array.c | 134 ++++++++++++++++++++--
> drivers/platform/x86/surfacepro3_button.c | 38 ++++++
> 2 files changed, 160 insertions(+), 12 deletions(-)
>
^ permalink raw reply
* Re: hid-related 5.2-rc1 boot hang
From: Hans de Goede @ 2019-06-03 9:11 UTC (permalink / raw)
To: Jiri Kosina, Dave Hansen
Cc: Benjamin Tissoires, open list:HID CORE LAYER, LKML
In-Reply-To: <nycvar.YFH.7.76.1906010014150.1962@cbobk.fhfr.pm>
Hi,
On 01-06-19 00:15, Jiri Kosina wrote:
> On Thu, 30 May 2019, Dave Hansen wrote:
>
>> On 5/29/19 2:17 AM, Hans de Goede wrote:
>> ...
>>> Dave, can you try building your initrd without the hid-logitech-dj module
>>> included in the initrd?
>>
>> I did this on a vanilla 5.2-rc2 kernel (without the reverts) and still
>> experienced the boot hang while the device was inserted.
>>
>>> Also can you check if your modprobe is provided by module-init-tools
>>> or by kmod ?
>>
>> $ dpkg -S `which modprobe`
>> kmod: /sbin/modprobe
>
> Benjamin, Hans, are you looking into this?
Not really, I cannot reproduce the request_module problem. I was hoping some
of the info from Dave would help to pinpoint it, but it does not :|
> If not, I think we should start reverting (at least the request_module()
> changes
I agree we need to do something about the request_module changes.
I myself was thinking about somehow making them conditional, e.g. we
could add a (temporary) module option defaulting to false for this
while we investigate further.
I'm afraid that if we just revert we will never find the root cause and then
we will be stuck with the suboptimal behavior of first the generic hid driver
binding followed by a unbind + bind of the new driver shortly afterwards,
which also leads to a ton of udev events being fired to userspace (well I
guess this does make for a good stress test of the userspace hotplug code).
> not sure about the rest of logitech issues yet) next week.
The main problem seems to be the request_module patches. Although I also
have 2 reports of problems with hid-logitech-dj driving the 0xc52f product-id,
so we may need to drop that product-id from hid-logitech-dj, I'm working on
that one...
Regards,
Hans
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox