Re: [PATCH 1/7] dt-bindings: input: touchscreen: samsung,s6sy761: Add S6SY791 and reset GPIO

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: unconditional SPI properties allow I2C variant to pass with invalid properties
--

commit ea887456e038f98ac0c943c8af10e4e502dc0827
Author: Lukas Timmermann <foss@timmermann.space>

dt-bindings: input: touchscreen: samsung,s6sy761: Add S6SY791 and reset GPIO

This patch adds the S6SY791 SPI-based touchscreen controller as a variant
alongside the existing I2C-based S6SY761. It also adds support for an optional
reset GPIO and references spi-peripheral-props for the SPI bus properties.

> diff --git a/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml b/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml
> index 1ffd17af3c53f..d24f35038934a 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml
> @@ -8,13 +8,17 @@ title: Samsung S6SY761 touchscreen controller
>  
>  maintainers:
>    - Andi Shyti <andi.shyti@kernel.org>
> +  - Lukas Timmermann <foss@timmermann.space>
>  
>  allOf:
>    - $ref: touchscreen.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#

[Severity: Low]
Does this allow the I2C variant to pass validation with invalid properties?

By unconditionally referencing spi-peripheral-props.yaml in the global allOf
list, device trees for the I2C variant (samsung,s6sy761) can now include SPI
properties and silently pass schema validation.

Should this $ref be moved to an if-then block that matches only the
samsung,s6sy791 compatible string?

[ ... ]

>    avdd-supply: true
>    vdd-supply: true
>  
> +  spi-max-frequency: true
> +
> +  spi-cpha: true
> +
> +  spi-cpol: true
> +

[Severity: Low]
Similarly, these SPI properties are added at the top-level. Does this globally
permit them for both interfaces, defeating the unevaluatedProperties: false
check for the I2C variant?

Could these properties be restricted to the samsung,s6sy791 variant using an
if-then block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011-lat3st-google-raven-touch-upstream-v1-0-2a9f55159b9e@timmermann.space?part=1