Re: [PATCH 2/7] Input: s6sy761 - split into core and I2C modules

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] i2c: missing named initializer for struct i2c_device_id array
--

commit 51d3d608cec412c03a6a7e8a8664d2c06b76fa92
Author: Lukas Timmermann <foss@timmermann.space>

Input: s6sy761 - split into core and I2C modules

This commit splits the s6sy761 touchscreen driver into a bus-agnostic core
and an I2C transport module in preparation for SPI support. It also adds a
mutex to protect the shared transfer buffer across threads.

> diff --git a/drivers/input/touchscreen/s6sy761_i2c.c b/drivers/input/touchscreen/s6sy761_i2c.c
> new file mode 100644
> index 0000000000000..b5cbebfd722a8
> --- /dev/null
> +++ b/drivers/input/touchscreen/s6sy761_i2c.c
[ ... ]
> +static const struct of_device_id s6sy761_of_match[] = {
> +	{ .compatible = "samsung,s6sy761", },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, s6sy761_of_match);
> +
> +static const struct i2c_device_id s6sy761_id[] = {
> +	{ "s6sy761" },

[Severity: Low]
Does this array declaration intentionally omit the named initializer? The I2C
subsystem guidelines require initialized arrays of type struct i2c_device_id
to use named initializers (e.g., { .name = "s6sy761" }) to remain robust
against layout changes. It looks like the named initializer was present in the
original code but was dropped during the driver split.

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, s6sy761_id);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011-lat3st-google-raven-touch-upstream-v1-0-2a9f55159b9e@timmermann.space?part=2