[PATCH] xpad.c: Add support to Hori Real Arcade Pro 4

[PATCH] xpad.c: Add support to Hori Real Arcade Pro 4

[Juan Parrado García]

Add specific support to Hori Real Arcade Pro 4.

Signed-off-by: Juan Parrado <jparrado1817@gmail.com>

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 810e52782..2567ea3bd 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -255,6 +255,7 @@ static const struct xpad_device {
  { 0x0f0d, 0x0063, "Hori Real Arcade Pro Hayabusa (USA) Xbox One",
MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
  { 0x0f0d, 0x0067, "HORIPAD ONE", 0, XTYPE_XBOXONE },
  { 0x0f0d, 0x0078, "Hori Real Arcade Pro V Kai Xbox One",
MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
+ { 0x0f0d, 0x008c, "Real Arcade Pro 4", 0, XTYPE_XBOX360 },
  { 0x0f0d, 0x00c5, "Hori Fighting Commander ONE",
MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
  { 0x0f0d, 0x00dc, "HORIPAD FPS for Nintendo Switch",
MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
  { 0x0f0d, 0x0151, "Hori Racing Wheel Overdrive for Xbox Series X",
0, XTYPE_XBOXONE },

[PATCH v2] [PATCH v2] xpad.c: Add support to Hori Real Arcade Pro 4

[Juan Parrado]

Add specific support to Hori Real Arcade Pro 4.

v2 fixed format

Signed-off-by: Juan Parrado <jparrado1817@gmail.com>
---
 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 810e52782..2567ea3bd 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -255,6 +255,7 @@ static const struct xpad_device {
 	{ 0x0f0d, 0x0063, "Hori Real Arcade Pro Hayabusa (USA) Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x0067, "HORIPAD ONE", 0, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x0078, "Hori Real Arcade Pro V Kai Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
+	{ 0x0f0d, 0x008c, "Real Arcade Pro 4", 0, XTYPE_XBOX360 },
 	{ 0x0f0d, 0x00c5, "Hori Fighting Commander ONE", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x00dc, "HORIPAD FPS for Nintendo Switch", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
 	{ 0x0f0d, 0x0151, "Hori Racing Wheel Overdrive for Xbox Series X", 0, XTYPE_XBOXONE },
-- 
2.56.0

Re: [PATCH v2] [PATCH v2] xpad.c: Add support to Hori Real Arcade Pro 4

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] Input: xpad - missing MAP_TRIGGERS_TO_BUTTONS for Hori Real
  Arcade Pro 4
- [Low] Input: xpad - Author/Signed-off-by email mismatch and changelog
  issues
--

commit ae6f93fb0a7ea08dae09b3962836f14f01d5f458
Author: Juan Parrado <jparrado.1817@gmail.com>

> xpad.c: Add support to Hori Real Arcade Pro 4
>
> Add specific support to Hori Real Arcade Pro 4.
>
> v2 fixed format
>
> Signed-off-by: Juan Parrado <jparrado1817@gmail.com>

[Severity: Low]
The Author address (jparrado.1817@gmail.com) does not match the
Signed-off-by address (jparrado1817@gmail.com), and the "v2 fixed format"
revision note should be placed below the "---" separator rather than in the
commit log.

Also, the commit subject should use the "Input: xpad - ..." prefix, and the
changelog should explain why an explicit xpad_device[] entry is needed when
vendor 0x0f0d is already matched by XPAD_XBOX360_VENDOR(0x0f0d) in
xpad_table[].

> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 810e52782ae89..2567ea3bd2604 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -255,6 +255,7 @@ static const struct xpad_device {
>  	{ 0x0f0d, 0x0063, "Hori Real Arcade Pro Hayabusa (USA) Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
>  	{ 0x0f0d, 0x0067, "HORIPAD ONE", 0, XTYPE_XBOXONE },
>  	{ 0x0f0d, 0x0078, "Hori Real Arcade Pro V Kai Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
> +	{ 0x0f0d, 0x008c, "Real Arcade Pro 4", 0, XTYPE_XBOX360 },
>  	{ 0x0f0d, 0x00c5, "Hori Fighting Commander ONE", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
>  	{ 0x0f0d, 0x00dc, "HORIPAD FPS for Nintendo Switch", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
>  	{ 0x0f0d, 0x0151, "Hori Racing Wheel Overdrive for Xbox Series X", 0, XTYPE_XBOXONE },

[Severity: Medium]
Should this entry set MAP_TRIGGERS_TO_BUTTONS instead of 0?

The Hori Real Arcade Pro 4 is an arcade fightstick with digital pushbuttons
for L2/R2 rather than analog triggers, and the other Hori Real Arcade Pro
entries in xpad_device[] set MAP_TRIGGERS_TO_BUTTONS so LT/RT are reported
as BTN_TL2/BTN_TR2 instead of ABS_Z/ABS_RZ.  Previously, 0x0f0d:0x008c bound
via XPAD_XBOX360_VENDOR(0x0f0d) with XTYPE_UNKNOWN, where xpad_probe()
auto-detected XTYPE_XBOX360 and still honored the triggers_to_buttons module
parameter; adding an explicit XTYPE_XBOX360 entry with mapping 0 bypasses
that XTYPE_UNKNOWN fallback in xpad_probe() and prevents overriding the
trigger mapping via module parameters.

Also, all surrounding 0x0f0d entries in xpad_device[] include the "Hori "
vendor prefix in the device name string ("Hori Real Arcade Pro 4").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109103715.11017-1-jparrado1817@gmail.com?part=1

[PATCH v3] [PATCH v3] xpad.c - Add support to Hori Real Arcade Pro 4

[Juan Parrado]

The HORI Real Arcade Pro 4 in PC mode is currently recognized by xpad.c as
a 'Generic X-Box pad' and works out of the box. However, this generic name
does not match the actual device name, making it difficult for users to
distinguish this controller when multiple devices are connected.

Tested on physical hardware. The proposed change works perfectly as is.
The MAP_TRIGGERS_TO_BUTTONS parameter does not work here. Other arcade
sticks use an identical configuration, such as the 'Street Fighter IV
FightPad' and the 'Hori Real Arcade Pro.EX Premium VLX'.

Signed-off-by: Juan Parrado <jparrado.1817@gmail.com>
---
v3:
 - Updated commit subject and description details.
 - Fixed metadata and updated patch version history.
v2:
 - Fixed truncated code lines in xpad.c.
 
 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 810e52782..2567ea3bd 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -255,6 +255,7 @@ static const struct xpad_device {
 	{ 0x0f0d, 0x0063, "Hori Real Arcade Pro Hayabusa (USA) Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x0067, "HORIPAD ONE", 0, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x0078, "Hori Real Arcade Pro V Kai Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
+	{ 0x0f0d, 0x008c, "Real Arcade Pro 4", 0, XTYPE_XBOX360 },
 	{ 0x0f0d, 0x00c5, "Hori Fighting Commander ONE", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x00dc, "HORIPAD FPS for Nintendo Switch", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
 	{ 0x0f0d, 0x0151, "Hori Racing Wheel Overdrive for Xbox Series X", 0, XTYPE_XBOXONE },
-- 
2.56.0

[PATCH v3] [PATCH v3] xpad.c - Add support to Hori Real Arcade Pro 4

[Juan Parrado]

The HORI Real Arcade Pro 4 in PC mode is currently recognized by xpad.c as
a 'Generic X-Box pad' and works out of the box. However, this generic name
does not match the actual device name, making it difficult for users to
distinguish this controller when multiple devices are connected.

Tested on physical hardware. The proposed change works perfectly as is.
The MAP_TRIGGERS_TO_BUTTONS parameter does not work here. Other arcade
sticks use an identical configuration, such as the 'Street Fighter IV
FightPad' and the 'Hori Real Arcade Pro.EX Premium VLX'.

Signed-off-by: Juan Parrado <jparrado.1817@gmail.com>
---
v3:
 - Updated commit subject and description details.
 - Fixed metadata and updated patch version history.
 - Corrected device name in code.
v2:
 - Fixed truncated code lines in xpad.c.
 
 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 810e52782..2567ea3bd 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -255,6 +255,7 @@ static const struct xpad_device {
 	{ 0x0f0d, 0x0063, "Hori Real Arcade Pro Hayabusa (USA) Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x0067, "HORIPAD ONE", 0, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x0078, "Hori Real Arcade Pro V Kai Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
+	{ 0x0f0d, 0x008c, "Hori Real Arcade Pro 4", 0, XTYPE_XBOX360 },
 	{ 0x0f0d, 0x00c5, "Hori Fighting Commander ONE", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
 	{ 0x0f0d, 0x00dc, "HORIPAD FPS for Nintendo Switch", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
 	{ 0x0f0d, 0x0151, "Hori Racing Wheel Overdrive for Xbox Series X", 0, XTYPE_XBOXONE },
-- 
2.56.0

Re: [PATCH v3] [PATCH v3] xpad.c - Add support to Hori Real Arcade Pro 4

[Dmitry Torokhov]

On Mon, Nov 09, 2026 at 08:58:30PM +0100, Juan Parrado wrote:
> The HORI Real Arcade Pro 4 in PC mode is currently recognized by xpad.c as
> a 'Generic X-Box pad' and works out of the box. However, this generic name
> does not match the actual device name, making it difficult for users to
> distinguish this controller when multiple devices are connected.
> 
> Tested on physical hardware. The proposed change works perfectly as is.
> The MAP_TRIGGERS_TO_BUTTONS parameter does not work here. Other arcade
> sticks use an identical configuration, such as the 'Street Fighter IV
> FightPad' and the 'Hori Real Arcade Pro.EX Premium VLX'.
> 
> Signed-off-by: Juan Parrado <jparrado.1817@gmail.com>

Applied, thank you.

-- 
Dmitry