Linux Input/HID development
 help / color / mirror / Atom feed
* [PATCH v3 00/18] HID: logitech-hidpp: G920 force-feedback rework and driver cleanups
@ 2026-11-20  8:43 Dmitry Torokhov
  2026-11-20  8:43 ` [PATCH v3 01/18] HID: logitech-hidpp: keep connect work disabled until hid_connect() completes Dmitry Torokhov
                   ` (17 more replies)
  0 siblings, 18 replies; 21+ messages in thread
From: Dmitry Torokhov @ 2026-11-20  8:43 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires, Gideon Heinz
  Cc: Filipe Laíns, Bastien Nocera, Hans de Goede, Edwin Velds,
	Stuart Hayhurst, Andrey Smirnov, linux-input, linux-kernel

Per Jiri Kosina's request, this 18-patch series for v7.5 is split out
from v2 and applies on top of:
[PATCH v3 00/14] HID: logitech-hidpp: G920 force-feedback and battery fixes

Note that v2 patch 22/33 ("HID: logitech-hidpp: shut down G920 force
feedback on input unregister") has been dropped in favor of "Input:
destroy force-feedback device on input unregistration" in input core.

The first group of patches improves transport handling and error
propagation: keeping connect work disabled during probe until
hid_connect() completes, preserving transport error codes in
__hidpp_send_report(), and translating HID++ protocol errors into
standard negative Linux error codes in hidpp_send_message_sync().

The G920 force-feedback rework moves capability discovery back into
hidpp_probe() while device I/O is active (excluding generic USB PID
force feedback for validated HID++ devices), separates device-level
wheel settings from the input FF queue lifetime, moves the G920 range
sysfs attribute to driver dev_groups using sysfs_emit(), executes range
stores, effect uploads, and effect erases synchronously, indexes FF
slot arrays directly by effect ID, and cleans up FF helpers.

The final patches modernize the driver by switching multi-byte protocol
fields to unaligned accessors, storing device serials as byte arrays,
using guard(mutex), __free(kfree), alloc_ordered_workqueue(),
devm_mutex_init(), and devm_device_add_group(), and removing unused
kfifo and wtp_data fields and redundant helpers.

Thanks.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Changes in v3:
- Split out from v2 as a separate 18-patch series for v7.5 per Jiri
  Kosina, applying on top of the v7.4 fixes series.
- Dropped "HID: logitech-hidpp: shut down G920 force feedback on input
  unregister" (v2 patch 22/33) in favor of "Input: destroy
  force-feedback device on input unregistration" in input core.
- Collected Tested-by tags from Gideon Heinz across all patches in this
  series.
- Link to v2: https://patch.msgid.link/20261110-hid-logitech-hidpp-v2-0-30743e91d83b@gmail.com

Changes in v2:
- Rebased the series on top of linux-next.
- Kept connect work disabled during probe until hid_connect() succeeds.
- Switched hidpp_send_message_sync() to translate RAP and FAP protocol
  error codes into negative Linux error codes (-EBUSY, -EIO, -EPROTO)
  instead of returning positive protocol values, and preserved transport
  error codes in __hidpp_send_report().
- Converted G920 range store, effect upload, and effect erase to
  synchronous execution with slot indexing by effect ID.
- Added G920 force-feedback helper cleanups, removed unused kfifo and
  struct wtp_data fields, and cleaned up minor helpers.
- Link to v1: https://patch.msgid.link/20261109061103.2887636-1-dmitry.torokhov@gmail.com

---
Dmitry Torokhov (18):
      HID: logitech-hidpp: keep connect work disabled until hid_connect() completes
      HID: logitech-hidpp: preserve transport error codes in __hidpp_send_report()
      HID: logitech-hidpp: return negative error codes from hidpp_send_message_sync()
      HID: logitech-hidpp: rework G920 force-feedback initialization
      HID: logitech-hidpp: use sysfs_emit() in hidpp_ff_range_show()
      HID: logitech-hidpp: manage G920 range sysfs attribute via dev_groups
      HID: logitech-hidpp: execute G920 range sysfs store synchronously
      HID: logitech-hidpp: index G920 force-feedback slots by effect ID
      HID: logitech-hidpp: execute G920 effect upload and erase synchronously
      HID: logitech-hidpp: clean up G920 force-feedback helpers
      HID: logitech-hidpp: use unaligned accessors for multi-byte values
      HID: logitech-hidpp: store device serial as a byte array
      HID: logitech-hidpp: use guard() for send_mutex
      HID: logitech-hidpp: use __free(kfree) for temporary allocations
      HID: logitech-hidpp: use alloc_ordered_workqueue() for FF queue
      HID: logitech-hidpp: manage send_mutex with devm_mutex_init()
      HID: logitech-hidpp: manage ps_attribute_group with devm_device_add_group()
      HID: logitech-hidpp: remove unused kfifo and clean up minor helpers

 drivers/hid/hid-logitech-hidpp.c | 798 ++++++++++++++++-----------------------
 1 file changed, 323 insertions(+), 475 deletions(-)
---
base-commit: 84abb955b1015477aa11a96e2f3ac1b938b77f48
change-id: 20261119-hid-logitech-hidpp-next-adcd534abca8
prerequisite-change-id: 20261110-hid-logitech-hidpp-6884bfb6a348:v3
prerequisite-patch-id: e1416a97b0f876b3ad2c58d961bc858fc894d90d
prerequisite-patch-id: a7c7a0921c6903c5cb52598f422b76593030eefc
prerequisite-patch-id: e250d48e371cf39225c26a2830059e1ef0f84100
prerequisite-patch-id: 19ed5cf936a31bcfb2e6743c64bdbfaf4cd4c497
prerequisite-patch-id: 7d9f088caf73b37fffaa521ab2fa01154bc725d5
prerequisite-patch-id: fd2e52e0c7fb38fbb457f1a133b21cc2e82bad7d
prerequisite-patch-id: 26d251375b09680f430f05d1cfe6f1a7049d7699
prerequisite-patch-id: 452b96def4814eb20770c50cda5ba2cdf934e1e6
prerequisite-patch-id: 99be7ec097ed9b8c9fcae3a1e769c65bd40d0e5e
prerequisite-patch-id: f42ce025d79d5bce980e061ee7bfd79fac6db59f
prerequisite-patch-id: 1f1d98c497c6f72f2468a7b136b38d3b1673a843
prerequisite-patch-id: 1ae006ac01f09e4fab516f0925b69f6683011ca4
prerequisite-patch-id: 1d063d2ee308c2ac3a57dfa9029b2d826b7f2a42
prerequisite-patch-id: 417cd6cae264a8b5dd5714ddeef4e75bbd959b17

Thanks.

-- 
Dmitry


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2026-11-20  9:00 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20  8:43 [PATCH v3 00/18] HID: logitech-hidpp: G920 force-feedback rework and driver cleanups Dmitry Torokhov
2026-11-20  8:43 ` [PATCH v3 01/18] HID: logitech-hidpp: keep connect work disabled until hid_connect() completes Dmitry Torokhov
2026-11-20  8:43 ` [PATCH v3 02/18] HID: logitech-hidpp: preserve transport error codes in __hidpp_send_report() Dmitry Torokhov
2026-11-20  8:49   ` sashiko-bot
2026-11-20  8:43 ` [PATCH v3 03/18] HID: logitech-hidpp: return negative error codes from hidpp_send_message_sync() Dmitry Torokhov
2026-11-20  8:43 ` [PATCH v3 04/18] HID: logitech-hidpp: rework G920 force-feedback initialization Dmitry Torokhov
2026-11-20  8:43 ` [PATCH v3 05/18] HID: logitech-hidpp: use sysfs_emit() in hidpp_ff_range_show() Dmitry Torokhov
2026-11-20  8:43 ` [PATCH v3 06/18] HID: logitech-hidpp: manage G920 range sysfs attribute via dev_groups Dmitry Torokhov
2026-11-20  9:00   ` sashiko-bot
2026-11-20  8:43 ` [PATCH v3 07/18] HID: logitech-hidpp: execute G920 range sysfs store synchronously Dmitry Torokhov
2026-11-20  8:43 ` [PATCH v3 08/18] HID: logitech-hidpp: index G920 force-feedback slots by effect ID Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 09/18] HID: logitech-hidpp: execute G920 effect upload and erase synchronously Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 10/18] HID: logitech-hidpp: clean up G920 force-feedback helpers Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 11/18] HID: logitech-hidpp: use unaligned accessors for multi-byte values Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 12/18] HID: logitech-hidpp: store device serial as a byte array Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 13/18] HID: logitech-hidpp: use guard() for send_mutex Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 14/18] HID: logitech-hidpp: use __free(kfree) for temporary allocations Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 15/18] HID: logitech-hidpp: use alloc_ordered_workqueue() for FF queue Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 16/18] HID: logitech-hidpp: manage send_mutex with devm_mutex_init() Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 17/18] HID: logitech-hidpp: manage ps_attribute_group with devm_device_add_group() Dmitry Torokhov
2026-11-20  8:44 ` [PATCH v3 18/18] HID: logitech-hidpp: remove unused kfifo and clean up minor helpers Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox