Linux Input/HID development
 help / color / mirror / Atom feed
* [PATCH 0/3] Touchscreen wakeup for the OnePlus 6 and 6T
@ 2026-11-22  5:13 EMCP333 via B4 Relay
  2026-11-22  5:13 ` [PATCH 1/3] dt-bindings: input: syna,rmi4: Document wakeup-source EMCP333 via B4 Relay
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: EMCP333 via B4 Relay @ 2026-11-22  5:13 UTC (permalink / raw)
  To: Dmitry Torokhov, Bjorn Andersson, Konrad Dybcio
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Jason A. Donenfeld, Matthias Schiffer, Vincent Huang, Abel Vesa,
	Casey Connolly, linux-input, linux-arm-msm, devicetree,
	linux-kernel, EMCP333

The Synaptics touchscreen on the OnePlus 6 and 6T is meant to wake the
SoC from s2idle. The I2C core and the rmi4 driver already handle
"wakeup-source", but rmi_i2c cuts the controller's supplies in system
suspend right after it arms the wake interrupt. Unpowered, the
controller cannot report a touch, and on these phones cutting the
supplies also raises the attention interrupt, which ends every s2idle
within a few seconds.

Patch 1 lets the rmi4 binding accept "wakeup-source". Patch 2 keeps an
rmi4 I2C device that may wake the system powered in system suspend, as
edt-ft5x06 does. Patch 3 sets the property in
sdm845-oneplus-common.dtsi.

Patches 1 and 2 are for the input tree and patch 3 for the Qualcomm
tree. Patch 3 needs patch 1 for dtbs_check, and should not land before
patch 2: without it, every s2idle on these phones ends at once.

Tested on a OnePlus 6T on v7.4-rc3 with all three patches, rmi_core and
rmi_i2c built as modules from patch 2's commit. With nobody touching the
phone, "rtcwake -m freeze -s 30" slept the full 30 seconds with no
attention interrupt (2 of 2); without patch 2 it came back after 3 to 4
seconds, one attention interrupt each time (3 of 3). A double-tap on the
dark phone woke it from "rtcwake -m freeze -s 120" after 3 and 7
seconds, one attention interrupt burst each. With wakeup disabled the
supplies are cut as before and it slept the full 30 seconds (2 of 2).

On v7.4-rc2, dt_binding_check is clean, dtbs_check reports nothing new
for fajita or enchilada, and rmi_i2c.c builds cleanly with W=1.

---
EMCP333 (3):
      dt-bindings: input: syna,rmi4: Document wakeup-source
      Input: synaptics-rmi4 - keep an I2C device that may wake the system powered
      arm64: dts: qcom: sdm845-oneplus: Mark the touchscreen as a wakeup source

 .../devicetree/bindings/input/syna,rmi4.yaml       |  2 ++
 .../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi |  1 +
 drivers/input/rmi4/rmi_i2c.c                       | 22 +++++++++++++++-------
 3 files changed, 18 insertions(+), 7 deletions(-)
---
base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
change-id: 20261122-b4-rmi4-wakeup-5948487a39ed

Best regards,
--  
EMCP333 <emcp@enser.io>



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-22  6:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22  5:13 [PATCH 0/3] Touchscreen wakeup for the OnePlus 6 and 6T EMCP333 via B4 Relay
2026-11-22  5:13 ` [PATCH 1/3] dt-bindings: input: syna,rmi4: Document wakeup-source EMCP333 via B4 Relay
2026-11-22  5:13 ` [PATCH 2/3] Input: synaptics-rmi4 - keep an I2C device that may wake the system powered EMCP333 via B4 Relay
2026-11-22  5:23   ` sashiko-bot
2026-11-22  6:42     ` Erik Peterson
2026-11-22  5:13 ` [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark the touchscreen as a wakeup source EMCP333 via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox