From: shaopeijie@cestc.cn
To: jarkko@kernel.org
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, Peijie Shao <shaopeijie@cestc.cn>
Subject: [PATCH v2] tpm_tis_spi: fix:release chip select when flow control fails
Date: Mon, 22 May 2023 15:01:40 +0800 [thread overview]
Message-ID: <20230522070140.33719-1-shaopeijie@cestc.cn> (raw)
From: Peijie Shao <shaopeijie@cestc.cn>
The failure paths in tpm_tis_spi_transfer() do not deactivate
chip select. Send an empty message (cs_select == 0) to overcome
this.
Signed-off-by: Peijie Shao <shaopeijie@cestc.cn>
---
Changes since v1:
1. Deactive cs all of the failure path, not only flow control.
2. change and update comments.
---
drivers/char/tpm/tpm_tis_spi_main.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
index 1f5207974..9bfaba092 100644
--- a/drivers/char/tpm/tpm_tis_spi_main.c
+++ b/drivers/char/tpm/tpm_tis_spi_main.c
@@ -136,6 +136,14 @@ int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
}
exit:
+ if (ret < 0) {
+ /* Deactivate chip select */
+ memset(&spi_xfer, 0, sizeof(spi_xfer));
+ spi_message_init(&m);
+ spi_message_add_tail(&spi_xfer, &m);
+ spi_sync_locked(phy->spi_device, &m);
+ }
+
spi_bus_unlock(phy->spi_device->master);
return ret;
}
--
2.39.1
next reply other threads:[~2023-05-22 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 7:01 shaopeijie [this message]
2023-05-22 8:17 ` [PATCH v2] tpm_tis_spi: fix:release chip select when flow control fails Paul Menzel
2023-05-24 2:52 ` Jarkko Sakkinen
2023-05-23 2:45 ` shaopeijie
2023-05-23 2:45 ` [PATCH v3] tpm_tis_spi: Release " shaopeijie
2023-05-24 2:06 ` Jarkko Sakkinen
2023-05-24 3:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522070140.33719-1-shaopeijie@cestc.cn \
--to=shaopeijie@cestc.cn \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox