From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Paul Menzel" <pmenzel@molgen.mpg.de>,
"Peijie Shao" <shaopeijie@cestc.cn>
Cc: <peterhuewe@gmx.de>, <jgg@ziepe.ca>,
<linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tpm_tis_spi: fix:release chip select when flow control fails
Date: Wed, 24 May 2023 05:52:29 +0300 [thread overview]
Message-ID: <CSU61T6XP2L8.3RHK45A4J0C2C@suppilovahvero> (raw)
In-Reply-To: <7840f8c2-a903-7d80-c4bd-8568ad1c8682@molgen.mpg.de>
On Mon May 22, 2023 at 11:17 AM EEST, Paul Menzel wrote:
> Dear Peijie,
>
>
> Thank you for your patch.
>
> The fix: tag in your commit message summary is uncommon. I suggest:
>
> > tpm_tis_spi: Release chip select when flow control fails
>
>
> Am 22.05.23 um 09:01 schrieb shaopeijie@cestc.cn:
> > From: Peijie Shao <shaopeijie@cestc.cn>
> >
> > The failure paths in tpm_tis_spi_transfer() do not deactivate
> > chip select. Send an empty message (cs_select == 0) to overcome
> > this.
>
> Does the standard require to deactivate it?
>
> A note on your test setup would be nice to have in the commit message.
I think it is "good enough", not to say it couldn't be improved.
I can accept as it is, or substitute with one with an updated commit
message. This is going earliest to v6.5.
BR, Jarkko
next prev parent reply other threads:[~2023-05-24 2:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 7:01 [PATCH v2] tpm_tis_spi: fix:release chip select when flow control fails shaopeijie
2023-05-22 8:17 ` Paul Menzel
2023-05-24 2:52 ` Jarkko Sakkinen [this message]
2023-05-23 2:45 ` shaopeijie
2023-05-23 2:45 ` [PATCH v3] tpm_tis_spi: Release " shaopeijie
2023-05-24 2:06 ` Jarkko Sakkinen
2023-05-24 3:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CSU61T6XP2L8.3RHK45A4J0C2C@suppilovahvero \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=shaopeijie@cestc.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox