[PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[Marek Vasut]

Add the ST chip st33tphf2ei2c to the supported compatible strings of the
TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
Profile specification.

For reference, a databrief is available at:
https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-integrity@vger.kernel.org
---
 Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
index af7720dc4a12c..fdd7fd874e01e 100644
--- a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
+++ b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
@@ -33,6 +33,7 @@ properties:
               - infineon,slb9673
               - nuvoton,npct75x
               - st,st33ktpm2xi2c
+              - st,st33tphf2ei2c
           - const: tcg,tpm-tis-i2c
 
       - description: TPM 1.2 and 2.0 chips with vendor-specific I²C interface
-- 
2.45.2

Re: [PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[Jarkko Sakkinen]

On Thu Dec 26, 2024 at 7:10 PM EET, Marek Vasut wrote:
> Add the ST chip st33tphf2ei2c to the supported compatible strings of the
> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
                          ~~~~
			  chip

> Profile specification.
>
> For reference, a databrief is available at:
> https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf

Or just this would be enough:

Link: https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf

>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Lukas Wunner <lukas@wunner.de>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-integrity@vger.kernel.org
> ---
>  Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> index af7720dc4a12c..fdd7fd874e01e 100644
> --- a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml
> @@ -33,6 +33,7 @@ properties:
>                - infineon,slb9673
>                - nuvoton,npct75x
>                - st,st33ktpm2xi2c
> +              - st,st33tphf2ei2c
>            - const: tcg,tpm-tis-i2c
>  
>        - description: TPM 1.2 and 2.0 chips with vendor-specific I²C interface


BR, Jarkko

Re: [PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[Marek Vasut]

On 12/26/24 8:54 PM, Jarkko Sakkinen wrote:
> On Thu Dec 26, 2024 at 7:10 PM EET, Marek Vasut wrote:
>> Add the ST chip st33tphf2ei2c to the supported compatible strings of the
>> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
>                            ~~~~
> 			  chip

Fixed, thanks.

>> Profile specification.
>>
>> For reference, a databrief is available at:
>> https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf
> 
> Or just this would be enough:
> 
> Link: https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf
I don't think Link: tag should be used for datasheets and other such 
stuff, my understanding of the Link: tag is that it is used to point to 
the patch at lore.k.o once applied ?

Re: [PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[Jarkko Sakkinen]

On Thu Dec 26, 2024 at 10:29 PM EET, Marek Vasut wrote:
> On 12/26/24 8:54 PM, Jarkko Sakkinen wrote:
> > On Thu Dec 26, 2024 at 7:10 PM EET, Marek Vasut wrote:
> >> Add the ST chip st33tphf2ei2c to the supported compatible strings of the
> >> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
> >                            ~~~~
> > 			  chip
>
> Fixed, thanks.
>
> >> Profile specification.
> >>
> >> For reference, a databrief is available at:
> >> https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf
> > 
> > Or just this would be enough:
> > 
> > Link: https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf
> I don't think Link: tag should be used for datasheets and other such 
> stuff, my understanding of the Link: tag is that it is used to point to 
> the patch at lore.k.o once applied ?

Oh, you are right and I did not know this :-) I've never read this page
before (ever) because I did not know it was necessary:

https://www.kernel.org/doc/html/latest/maintainer/configure-git.html

So I've used up until today link-tag for links... I just thought that
"well, I have Git configured"...

BR, Jarkko

Re: [PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[Krzysztof Kozlowski]

On 26/12/2024 18:10, Marek Vasut wrote:
> Add the ST chip st33tphf2ei2c to the supported compatible strings of the
> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
> Profile specification.
> 

Where is any user of this?

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[Marek Vasut]

On 12/27/24 8:00 AM, Krzysztof Kozlowski wrote:
> On 26/12/2024 18:10, Marek Vasut wrote:
>> Add the ST chip st33tphf2ei2c to the supported compatible strings of the
>> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
>> Profile specification.
>>
> 
> Where is any user of this?
Submitted to linux-arm-kernel in

[PATCH] arm64: dts: imx8mp: Update Data Modul i.MX8M Plus eDM SBC DT to 
rev.903

Re: [PATCH] dt-bindings: tpm: Add st,st33tphf2ei2c

[Krzysztof Kozlowski]

On Thu, Dec 26, 2024 at 06:10:52PM +0100, Marek Vasut wrote:
> Add the ST chip st33tphf2ei2c to the supported compatible strings of the
> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client TPM
> Profile specification.
> 
> For reference, a databrief is available at:
> https://www.st.com/resource/en/data_brief/st33tphf2ei2c.pdf
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof