Linux Integrity Measurement development
 help / color / mirror / Atom feed
* [PATCH] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX
@ 2026-08-24 16:22 Julian Braha
  2026-09-02  0:54 ` Mimi Zohar
  0 siblings, 1 reply; 3+ messages in thread
From: Julian Braha @ 2026-08-24 16:22 UTC (permalink / raw)
  To: zohar, roberto.sassu, dmitry.kasatkin, paul, jmorris, serge
  Cc: eric.snowberg, linux-integrity, linux-security-module,
	linux-kernel, Julian Braha

The IMA_MEASURE_PCR_IDX option is currently not visible in the kconfig
frontend, so it always uses its default, 10. This means that the
'range 8 14' is dead code, and users are unable to specify the pcr index
value.

In a previous discussion, Mimi explained that users should be able to use
this config option to specify the pcr index. [1]

Let's add a prompt for users to specify the pcr index, when EXPERT is
enabled.

This dead range was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Link: https://lore.kernel.org/all/1feff118-4afa-4b9c-86f1-271a7a88208f@gmail.com/T/#mc4efa2491b4937eb7c9e532c29ffba516a70e662 [1]
---
 security/integrity/ima/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
index b3a9f86809b0..2d5bb19ea6ac 100644
--- a/security/integrity/ima/Kconfig
+++ b/security/integrity/ima/Kconfig
@@ -46,6 +46,7 @@ config IMA_KEXEC
 
 config IMA_MEASURE_PCR_IDX
 	int
+	prompt "PCR Index for Aggregate" if EXPERT
 	range 8 14
 	default 10
 	help
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX
  2026-08-24 16:22 [PATCH] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX Julian Braha
@ 2026-09-02  0:54 ` Mimi Zohar
  2026-09-02 11:38   ` Julian Braha
  0 siblings, 1 reply; 3+ messages in thread
From: Mimi Zohar @ 2026-09-02  0:54 UTC (permalink / raw)
  To: Julian Braha, roberto.sassu, dmitry.kasatkin, paul, jmorris,
	serge
  Cc: eric.snowberg, linux-integrity, linux-security-module,
	linux-kernel

On Mon, 2026-08-24 at 17:22 +0100, Julian Braha wrote:
> The IMA_MEASURE_PCR_IDX option is currently not visible in the kconfig
> frontend, so it always uses its default, 10. This means that the
> 'range 8 14' is dead code, and users are unable to specify the pcr index
> value.
> 
> In a previous discussion, Mimi explained that users should be able to use
> this config option to specify the pcr index. [1]
> 
> Let's add a prompt for users to specify the pcr index, when EXPERT is
> enabled.
> 
> This dead range was found by kconfirm, a static analysis tool for Kconfig.
> 
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> Link: https://lore.kernel.org/all/1feff118-4afa-4b9c-86f1-271a7a88208f@gmail.com/T/#mc4efa2491b4937eb7c9e532c29ffba516a70e662 [1]
> ---
>  security/integrity/ima/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
> index b3a9f86809b0..2d5bb19ea6ac 100644
> --- a/security/integrity/ima/Kconfig
> +++ b/security/integrity/ima/Kconfig
> @@ -46,6 +46,7 @@ config IMA_KEXEC
>  
>  config IMA_MEASURE_PCR_IDX
>  	int
> +	prompt "PCR Index for Aggregate" if EXPERT
>  	range 8 14
>  	default 10
>  	help

Thanks, Julian.  The existing Help says, "If unsure, use the default 10."  Could
we make this recommendation stronger?  AI suggested:

	  IMA_MEASURE_PCR_IDX determines the TPM PCR register index
	  that IMA uses to maintain the integrity aggregate of the
	  measurement list. Most attestation tooling expects PCR 10.

	  The default is almost always what you want. Only change
	  this if you know what you are doing.

Thanks,

Mimi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX
  2026-09-02  0:54 ` Mimi Zohar
@ 2026-09-02 11:38   ` Julian Braha
  0 siblings, 0 replies; 3+ messages in thread
From: Julian Braha @ 2026-09-02 11:38 UTC (permalink / raw)
  To: Mimi Zohar, roberto.sassu, dmitry.kasatkin, paul, jmorris, serge
  Cc: eric.snowberg, linux-integrity, linux-security-module,
	linux-kernel

Hi Mimi,

On 9/2/26 01:54, Mimi Zohar wrote:
> On Mon, 2026-08-24 at 17:22 +0100, Julian Braha wrote:
>> The IMA_MEASURE_PCR_IDX option is currently not visible in the kconfig
>> frontend, so it always uses its default, 10. This means that the
>> 'range 8 14' is dead code, and users are unable to specify the pcr index
>> value.
>>
>> In a previous discussion, Mimi explained that users should be able to use
>> this config option to specify the pcr index. [1]
>>
>> Let's add a prompt for users to specify the pcr index, when EXPERT is
>> enabled.
>>
>> This dead range was found by kconfirm, a static analysis tool for Kconfig.
>>
>> Signed-off-by: Julian Braha <julianbraha@gmail.com>
>> ---
>> Link: https://lore.kernel.org/all/1feff118-4afa-4b9c-86f1-271a7a88208f@gmail.com/T/#mc4efa2491b4937eb7c9e532c29ffba516a70e662 [1]
>> ---
>>  security/integrity/ima/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
>> index b3a9f86809b0..2d5bb19ea6ac 100644
>> --- a/security/integrity/ima/Kconfig
>> +++ b/security/integrity/ima/Kconfig
>> @@ -46,6 +46,7 @@ config IMA_KEXEC
>>  
>>  config IMA_MEASURE_PCR_IDX
>>  	int
>> +	prompt "PCR Index for Aggregate" if EXPERT
>>  	range 8 14
>>  	default 10
>>  	help
> 
> Thanks, Julian.  The existing Help says, "If unsure, use the default 10."  Could
> we make this recommendation stronger?  AI suggested:
> 
> 	  IMA_MEASURE_PCR_IDX determines the TPM PCR register index
> 	  that IMA uses to maintain the integrity aggregate of the
> 	  measurement list. Most attestation tooling expects PCR 10.
> 
> 	  The default is almost always what you want. Only change
> 	  this if you know what you are doing.


Thank you for your feedback, will include this in v2!

- Julian Braha

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-02 11:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24 16:22 [PATCH] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX Julian Braha
2026-09-02  0:54 ` Mimi Zohar
2026-09-02 11:38   ` Julian Braha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox