From: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
peterhuewe@gmx.de, jgg@ziepe.ca, shuah@kernel.org
Cc: linux-integrity@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: tpm2: create a dedicated .gitignore
Date: Sat, 25 Jan 2025 10:58:42 +0200 [thread overview]
Message-ID: <518c6b84-63f0-4192-89a1-af0e8000318c@gmail.com> (raw)
In-Reply-To: <D7AGBYQ5T2P2.3L3HM84HUCS1V@kernel.org>
On 1/24/25 6:42 PM, Jarkko Sakkinen wrote:
> Shortest ever commit message tutorial:
>
> 1. Problem
> 2. Motivation
> 3. Solution with explanation how it will map on addressing the problem.
>
> Do this for every possible commit and you will get it right 99%
> of time. I can admit that even today I don't always get this myself
> fully right but I try my best ;-) That does not mean you could not
> do better than me.
>
> And generally, depending on subsystem tho, people usually feel more
> confortable with "imperative form" rather than "science paper" form.
>
> BR, Jarkko
Ah great, thank you for the review the tutorial.
Hopefully, I will do better in v3 :)
Many thanks,
Khaled
next prev parent reply other threads:[~2025-01-25 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 6:50 [PATCH v2] selftests: tpm2: create a dedicated .gitignore Khaled Elnaggar
2025-01-23 9:47 ` Jarkko Sakkinen
2025-01-24 14:35 ` Khaled Elnaggar
2025-01-24 16:37 ` Jarkko Sakkinen
2025-01-24 16:42 ` Jarkko Sakkinen
2025-01-25 8:58 ` Khaled Elnaggar [this message]
2025-01-25 19:20 ` Jarkko Sakkinen
2025-01-26 10:50 ` Khaled Elnaggar
2025-01-26 14:22 ` [PATCH v3] " Khaled Elnaggar
2025-01-26 16:30 ` Jarkko Sakkinen
2025-01-26 19:51 ` [PATCH v4] " Khaled Elnaggar
2025-01-27 17:18 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518c6b84-63f0-4192-89a1-af0e8000318c@gmail.com \
--to=khaledelnaggarlinux@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox