public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
	"Khaled Elnaggar" <khaledelnaggarlinux@gmail.com>,
	<peterhuewe@gmx.de>, <jgg@ziepe.ca>, <shuah@kernel.org>
Cc: <linux-kernel-mentees@vger.kernel.org>,
	<linux-integrity@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] selftests: tpm2: create a dedicated .gitignore
Date: Fri, 24 Jan 2025 18:42:13 +0200	[thread overview]
Message-ID: <D7AGBYQ5T2P2.3L3HM84HUCS1V@kernel.org> (raw)
In-Reply-To: <D7AG8K6T8KRI.LZFD4J6OFGGZ@kernel.org>

On Fri Jan 24, 2025 at 6:37 PM EET, Jarkko Sakkinen wrote:
> On Fri Jan 24, 2025 at 4:35 PM EET, Khaled Elnaggar wrote:
> > On 1/23/25 11:47 AM, Jarkko Sakkinen wrote: 
> > > Why?
> >
> > Sorry I should have included v1 in the thread but I am still
> > new to the LKML process.
>
> No worries, relax, it was just  a one wonder question :-)

Shortest ever commit message tutorial:

1. Problem
2. Motivation
3. Solution with explanation how it will map on addressing the problem.

Do this for every possible commit and you will get it right 99%
of time. I can admit that even today I don't always get this myself
fully right but I try my best ;-) That does not mean you could not
do better than me.

And generally, depending on subsystem tho, people usually feel more
confortable with "imperative form" rather than "science paper" form.

Example:

1. Imperative: "Check the pointer for nullness."
2. Sciency: "We must check the the pointer for nullness."

BR, Jarkko

  reply	other threads:[~2025-01-24 16:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22  6:50 [PATCH v2] selftests: tpm2: create a dedicated .gitignore Khaled Elnaggar
2025-01-23  9:47 ` Jarkko Sakkinen
2025-01-24 14:35   ` Khaled Elnaggar
2025-01-24 16:37     ` Jarkko Sakkinen
2025-01-24 16:42       ` Jarkko Sakkinen [this message]
2025-01-25  8:58         ` Khaled Elnaggar
2025-01-25 19:20           ` Jarkko Sakkinen
2025-01-26 10:50             ` Khaled Elnaggar
2025-01-26 14:22 ` [PATCH v3] " Khaled Elnaggar
2025-01-26 16:30   ` Jarkko Sakkinen
2025-01-26 19:51   ` [PATCH v4] " Khaled Elnaggar
2025-01-27 17:18     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D7AGBYQ5T2P2.3L3HM84HUCS1V@kernel.org \
    --to=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=khaledelnaggarlinux@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel-mentees@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox