RE: [RFC PATCH 1/2] ima: differentiate between EVM failures in the audit log

[Roberto Sassu <roberto.sassu@huawei.com>]

> From: Mimi Zohar [mailto:zohar@linux.ibm.com]
> Sent: Thursday, June 3, 2021 5:18 PM
> Differenatiate between an invalid EVM portable signature failure

Typo.

> from other EVM HMAC/signature failures.
> 
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>

Thanks, looks good.

Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>

Roberto

HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Li Peng, Li Jian, Shi Yanli

> ---
>  security/integrity/ima/ima_appraise.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_appraise.c
> b/security/integrity/ima/ima_appraise.c
> index 940695e7b535..ef9dcfce45d4 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -422,7 +422,8 @@ int ima_appraise_measurement(enum ima_hooks
> func,
>  		goto out;
>  	case INTEGRITY_FAIL_IMMUTABLE:
>  		set_bit(IMA_DIGSIG, &iint->atomic_flags);
> -		fallthrough;
> +		cause = "invalid-fail-immutable";
> +		goto out;
>  	case INTEGRITY_FAIL:		/* Invalid HMAC/signature. */
>  		cause = "invalid-HMAC";
>  		goto out;
> --
> 2.27.0