Re: [RFC PATCH 2/2] evm: output EVM digest calculation info needed for debugging

[Mimi Zohar <zohar@linux.ibm.com>]

Hi Lakshmi,

On Thu, 2021-06-03 at 09:34 -0700, nramas wrote:
> > +void evm_bin2hex_print(const char *prefix, const void *src, size_t
> > count);
> >  
> 
> For evm_bin2hex_print() can we could do the following in evm.h?
> 
> #ifdef DEBUG
> void evm_bin2hex_print(const char *prefix, const void *src, size_t
> count);
> #else
> void evm_bin2hex_print(const char *prefix, const void *src, size_t
> count) {}
> #endif /* DEBUG */

Yes, if we decide that it needs to be based on DEBUG, this would be the
proper way of doing it.  However, since there's nothing really private
here, it's just displaying the security xattrs and other file metadata,
should enabling/disabling the debugging be runtime configurable?   Kind
of like how print_hex_dump() relies on loglevel.  Or should it be more
granular?

thanks,

Mimi