From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Nayna" <nayna@linux.vnet.ibm.com>
Cc: "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>
Subject: Re: Build failure on tpmdd master branch
Date: Thu, 10 Aug 2023 22:02:36 +0300 [thread overview]
Message-ID: <CUP3J2UX8SUI.3GHD0KUWB72YP@suppilovahvero> (raw)
In-Reply-To: <ebe1d154-962b-4a8b-ad08-b26e99804c1b@linux.vnet.ibm.com>
On Tue Aug 8, 2023 at 4:40 PM EEST, Nayna wrote:
> Hi Jarkko,
>
> I rebased the "Enable loading local and third party keys on PowerVM
> guest"(
> https://lore.kernel.org/linux-integrity/20230714153435.28155-1-nayna@linux.ibm.com/)
> on top of tpmdd master branch.
>
> The build is failing due to commit cfa7522f280a ("sysctl: set variable
> key_sysctls storage-class-specifier to static"). A patch with the same
> subject line is already in your tree. Refer to commit 0de030b30823
> ("sysctl: set variable key_sysctls storage-class-specifier to static").
>
> Thanks & Regards,
>
> - Nayna
Thanks for reporting, I rebased my tree and did:
make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- defconfig
make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
I get this now:
security/integrity/ima/ima_crypto.c: In function ‘ima_pcrread’:
security/integrity/ima/ima_crypto.c:785:13: error: too few arguments to function ‘tpm_pcr_read’
785 | if (tpm_pcr_read(ima_tpm_chip, idx, d) != 0)
| ^~~~~~~~~~~~
In file included from security/integrity/ima/ima.h:21,
from security/integrity/ima/ima_crypto.c:23:
./include/linux/tpm.h:428:12: note: declared here
428 | extern int tpm_pcr_read(struct tpm_chip *chip, u32 pcr_idx,
| ^~~~~~~~~~~~
BTW, in future, please also provide both arch and .config. I made
my guesses because I had neither (not meaning to complain, just
telling what would be useful, no worries).
BR, Jarkko
next prev parent reply other threads:[~2023-08-10 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 13:40 Build failure on tpmdd master branch Nayna
2023-08-10 15:34 ` Jarkko Sakkinen
2023-08-10 19:02 ` Jarkko Sakkinen [this message]
2023-08-10 19:13 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CUP3J2UX8SUI.3GHD0KUWB72YP@suppilovahvero \
--to=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox