Linux Integrity Measurement development
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <petr.vorel@gmail.com>, linux-integrity@vger.kernel.org
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Subject: Re: [PATCH ima-evm-utils] boot_aggregate.test: Skip if CONFIG_IMA not enabled
Date: Fri, 23 Oct 2020 08:46:01 -0400	[thread overview]
Message-ID: <a8f7aee73cb834184fc89d87d0fe72263952a0e7.camel@linux.ibm.com> (raw)
In-Reply-To: <e274a823ca408f33c11ea03878442189e62d9f9b.camel@linux.ibm.com>

Hi Petr,

On Mon, 2020-10-19 at 19:10 -0400, Mimi Zohar wrote:
> On Mon, 2020-10-19 at 22:08 +0200, Petr Vorel wrote:
> > This is required, because when TPM HW available (i.e. -c /dev/tpm0),
> > evmctl ima_boot_aggregate returns sha1:xxxx.
> > 
> > skip requires to move cleanup().
> > 
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> 
> Nice.
> > ---
> > Hi Mimi,
> > 
> > this Fixes problems on current Debian, which has still disabled CONFIG_IMA
> > (FYI [1]). I was not able to figure out how to get it working with
> > sample-* files, but maybe there is a way.

Moving the test down to within "if [ "$(id -u)" = 0 ] && [ -c
"/dev/tpm0" ]; then" will allow the sample tests to work.  I've
modified your patch and pushed it out to next-testing.

thanks,

Mimi


      parent reply	other threads:[~2020-10-23 12:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 20:08 [PATCH ima-evm-utils] boot_aggregate.test: Skip if CONFIG_IMA not enabled Petr Vorel
2020-10-19 23:10 ` Mimi Zohar
2020-10-20 18:02   ` Petr Vorel
2020-10-27 16:06     ` Mimi Zohar
2020-10-27 18:51       ` Mikhail Novosyolov
2020-10-27 19:06         ` Mimi Zohar
2020-10-27 19:29           ` Mikhail Novosyolov
2020-10-27 20:01             ` Petr Vorel
2020-10-27 18:49     ` Tyler Hicks
2020-10-27 18:57       ` Mikhail Novosyolov
2020-10-23 12:46   ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8f7aee73cb834184fc89d87d0fe72263952a0e7.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=petr.vorel@gmail.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox