* [PATCH v1 0/1] tpm_ffa_crb: handle tpm busy return code @ 2025-06-09 14:15 Prachotan Bathi 2025-06-09 14:16 ` [PATCH v1 1/1] " Prachotan Bathi 2025-06-09 21:00 ` [PATCH v1 0/1] " Jarkko Sakkinen 0 siblings, 2 replies; 6+ messages in thread From: Prachotan Bathi @ 2025-06-09 14:15 UTC (permalink / raw) To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Stuart Yoder Cc: linux-integrity, linux-kernel, Prachotan Bathi Platforms supporting direct message request v2 can support SPs that support multiple services. If the TPM service is sharing the SP with another service, it could get an error code of BUSY if the other service is in process. We need a way for the driver to retry sending the message to the TPM service until it succeeds or we know that no forward progress can be made. This patch adds a parameterized variable (default 2000ms) that indicates the maximum time to keep retrying for. Prachotan Bathi (1): tpm_ffa_crb: handle tpm busy return code drivers/char/tpm/tpm_crb_ffa.c | 74 +++++++++++++++++++++++----------- 1 file changed, 50 insertions(+), 24 deletions(-) -- 2.43.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/1] tpm_ffa_crb: handle tpm busy return code 2025-06-09 14:15 [PATCH v1 0/1] tpm_ffa_crb: handle tpm busy return code Prachotan Bathi @ 2025-06-09 14:16 ` Prachotan Bathi 2025-06-09 21:02 ` Jarkko Sakkinen 2025-06-09 21:00 ` [PATCH v1 0/1] " Jarkko Sakkinen 1 sibling, 1 reply; 6+ messages in thread From: Prachotan Bathi @ 2025-06-09 14:16 UTC (permalink / raw) To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Stuart Yoder Cc: linux-integrity, linux-kernel, Prachotan Bathi Platforms supporting direct message request v2 can support SPs that support multiple services. If the TPM service is sharing the SP with another service, it could get an error code of BUSY if the other service is in process. This patch adds a parameterized variable (default 2000ms) that indicates the maximum time to keep retrying for. Signed-off-by: Prachotan Bathi <prachotan.bathi@arm.com> --- drivers/char/tpm/tpm_crb_ffa.c | 74 +++++++++++++++++++++++----------- 1 file changed, 50 insertions(+), 24 deletions(-) diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c index 4ead61f01299..e47e110bac9e 100644 --- a/drivers/char/tpm/tpm_crb_ffa.c +++ b/drivers/char/tpm/tpm_crb_ffa.c @@ -10,6 +10,8 @@ #define pr_fmt(fmt) "CRB_FFA: " fmt #include <linux/arm_ffa.h> +#include <linux/delay.h> +#include <linux/moduleparam.h> #include "tpm_crb_ffa.h" /* TPM service function status codes */ @@ -178,6 +180,17 @@ int tpm_crb_ffa_init(void) } EXPORT_SYMBOL_GPL(tpm_crb_ffa_init); +static unsigned int busy_timeout = 2000; +/** + * busy_timeout - Maximum time to retry before giving up on busy + * + * This parameter defines the maximum time in milliseconds to retry + * sending a message to the TPM service before giving up. + */ +module_param(busy_timeout, uint, 0644); +MODULE_PARM_DESC(busy_timeout, + "Maximum time to retry before giving up on busy"); + static int __tpm_crb_ffa_send_recieve(unsigned long func_id, unsigned long a0, unsigned long a1, @@ -191,34 +204,47 @@ static int __tpm_crb_ffa_send_recieve(unsigned long func_id, msg_ops = tpm_crb_ffa->ffa_dev->ops->msg_ops; - if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) { - memset(&tpm_crb_ffa->direct_msg_data2, 0x00, - sizeof(struct ffa_send_direct_data2)); + ktime_t start; + ktime_t stop; + + start = ktime_get(); + stop = ktime_add(start, ms_to_ktime(busy_timeout)); + + do { + if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) { + memset(&tpm_crb_ffa->direct_msg_data2, 0x00, + sizeof(struct ffa_send_direct_data2)); - tpm_crb_ffa->direct_msg_data2.data[0] = func_id; - tpm_crb_ffa->direct_msg_data2.data[1] = a0; - tpm_crb_ffa->direct_msg_data2.data[2] = a1; - tpm_crb_ffa->direct_msg_data2.data[3] = a2; + tpm_crb_ffa->direct_msg_data2.data[0] = func_id; + tpm_crb_ffa->direct_msg_data2.data[1] = a0; + tpm_crb_ffa->direct_msg_data2.data[2] = a1; + tpm_crb_ffa->direct_msg_data2.data[3] = a2; - ret = msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev, + ret = msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev, &tpm_crb_ffa->direct_msg_data2); - if (!ret) - ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[0]); - } else { - memset(&tpm_crb_ffa->direct_msg_data, 0x00, - sizeof(struct ffa_send_direct_data)); - - tpm_crb_ffa->direct_msg_data.data1 = func_id; - tpm_crb_ffa->direct_msg_data.data2 = a0; - tpm_crb_ffa->direct_msg_data.data3 = a1; - tpm_crb_ffa->direct_msg_data.data4 = a2; - - ret = msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev, - &tpm_crb_ffa->direct_msg_data); - if (!ret) - ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data.data1); - } + if (!ret) + ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[0]); + } else { + memset(&tpm_crb_ffa->direct_msg_data, 0x00, + sizeof(struct ffa_send_direct_data)); + tpm_crb_ffa->direct_msg_data.data1 = func_id; + tpm_crb_ffa->direct_msg_data.data2 = a0; + tpm_crb_ffa->direct_msg_data.data3 = a1; + tpm_crb_ffa->direct_msg_data.data4 = a2; + + ret = msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev, + &tpm_crb_ffa->direct_msg_data); + if (!ret) + ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data.data1); + } + if (ret == -EBUSY) + pr_err("TPM says busy, trying again, value, ret: %d\n", + ret); + else + break; + usleep_range(50, 100); + } while (ktime_before(ktime_get(), stop)); return ret; } -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] tpm_ffa_crb: handle tpm busy return code 2025-06-09 14:16 ` [PATCH v1 1/1] " Prachotan Bathi @ 2025-06-09 21:02 ` Jarkko Sakkinen 0 siblings, 0 replies; 6+ messages in thread From: Jarkko Sakkinen @ 2025-06-09 21:02 UTC (permalink / raw) To: Prachotan Bathi Cc: Peter Huewe, Jason Gunthorpe, Stuart Yoder, linux-integrity, linux-kernel On Mon, Jun 09, 2025 at 09:16:00AM -0500, Prachotan Bathi wrote: > Platforms supporting direct message request v2 can > support SPs that support multiple services. > If the TPM service is sharing the SP with another service, > it could get an error code of BUSY if the other service is > in process. > This patch adds a parameterized variable (default 2000ms) > that indicates the maximum time to keep retrying for. Patch is not a patch once it is in a Git repository. Instead: "Add a ...". > > Signed-off-by: Prachotan Bathi <prachotan.bathi@arm.com> > --- > drivers/char/tpm/tpm_crb_ffa.c | 74 +++++++++++++++++++++++----------- > 1 file changed, 50 insertions(+), 24 deletions(-) > > diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c > index 4ead61f01299..e47e110bac9e 100644 > --- a/drivers/char/tpm/tpm_crb_ffa.c > +++ b/drivers/char/tpm/tpm_crb_ffa.c > @@ -10,6 +10,8 @@ > #define pr_fmt(fmt) "CRB_FFA: " fmt > > #include <linux/arm_ffa.h> > +#include <linux/delay.h> > +#include <linux/moduleparam.h> > #include "tpm_crb_ffa.h" > > /* TPM service function status codes */ > @@ -178,6 +180,17 @@ int tpm_crb_ffa_init(void) > } > EXPORT_SYMBOL_GPL(tpm_crb_ffa_init); > > +static unsigned int busy_timeout = 2000; > +/** > + * busy_timeout - Maximum time to retry before giving up on busy > + * > + * This parameter defines the maximum time in milliseconds to retry > + * sending a message to the TPM service before giving up. > + */ > +module_param(busy_timeout, uint, 0644); > +MODULE_PARM_DESC(busy_timeout, > + "Maximum time to retry before giving up on busy"); > + > static int __tpm_crb_ffa_send_recieve(unsigned long func_id, > unsigned long a0, > unsigned long a1, > @@ -191,34 +204,47 @@ static int __tpm_crb_ffa_send_recieve(unsigned long func_id, > > msg_ops = tpm_crb_ffa->ffa_dev->ops->msg_ops; > > - if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) { > - memset(&tpm_crb_ffa->direct_msg_data2, 0x00, > - sizeof(struct ffa_send_direct_data2)); > + ktime_t start; > + ktime_t stop; > + > + start = ktime_get(); > + stop = ktime_add(start, ms_to_ktime(busy_timeout)); > + > + do { > + if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) { > + memset(&tpm_crb_ffa->direct_msg_data2, 0x00, > + sizeof(struct ffa_send_direct_data2)); > > - tpm_crb_ffa->direct_msg_data2.data[0] = func_id; > - tpm_crb_ffa->direct_msg_data2.data[1] = a0; > - tpm_crb_ffa->direct_msg_data2.data[2] = a1; > - tpm_crb_ffa->direct_msg_data2.data[3] = a2; > + tpm_crb_ffa->direct_msg_data2.data[0] = func_id; > + tpm_crb_ffa->direct_msg_data2.data[1] = a0; > + tpm_crb_ffa->direct_msg_data2.data[2] = a1; > + tpm_crb_ffa->direct_msg_data2.data[3] = a2; > > - ret = msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev, > + ret = msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev, > &tpm_crb_ffa->direct_msg_data2); > - if (!ret) > - ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[0]); > - } else { > - memset(&tpm_crb_ffa->direct_msg_data, 0x00, > - sizeof(struct ffa_send_direct_data)); > - > - tpm_crb_ffa->direct_msg_data.data1 = func_id; > - tpm_crb_ffa->direct_msg_data.data2 = a0; > - tpm_crb_ffa->direct_msg_data.data3 = a1; > - tpm_crb_ffa->direct_msg_data.data4 = a2; > - > - ret = msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev, > - &tpm_crb_ffa->direct_msg_data); > - if (!ret) > - ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data.data1); > - } > + if (!ret) > + ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[0]); > + } else { > + memset(&tpm_crb_ffa->direct_msg_data, 0x00, > + sizeof(struct ffa_send_direct_data)); > > + tpm_crb_ffa->direct_msg_data.data1 = func_id; > + tpm_crb_ffa->direct_msg_data.data2 = a0; > + tpm_crb_ffa->direct_msg_data.data3 = a1; > + tpm_crb_ffa->direct_msg_data.data4 = a2; > + > + ret = msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev, > + &tpm_crb_ffa->direct_msg_data); > + if (!ret) > + ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data.data1); > + } > + if (ret == -EBUSY) > + pr_err("TPM says busy, trying again, value, ret: %d\n", > + ret); > + else > + break; > + usleep_range(50, 100); > + } while (ktime_before(ktime_get(), stop)); I'd describe the code change also in more detail i.e. what is this loop about. > > return ret; > } > -- > 2.43.0 > > BR, Jarkko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] tpm_ffa_crb: handle tpm busy return code 2025-06-09 14:15 [PATCH v1 0/1] tpm_ffa_crb: handle tpm busy return code Prachotan Bathi 2025-06-09 14:16 ` [PATCH v1 1/1] " Prachotan Bathi @ 2025-06-09 21:00 ` Jarkko Sakkinen 2025-06-10 21:12 ` Prachotan Bathi 1 sibling, 1 reply; 6+ messages in thread From: Jarkko Sakkinen @ 2025-06-09 21:00 UTC (permalink / raw) To: Prachotan Bathi Cc: Peter Huewe, Jason Gunthorpe, Stuart Yoder, linux-integrity, linux-kernel On Mon, Jun 09, 2025 at 09:15:59AM -0500, Prachotan Bathi wrote: > Platforms supporting direct message request v2 can > support SPs that support multiple services. What is "direct message request v2"? > If the TPM service is sharing the SP with another service, > it could get an error code of BUSY if the other service is > in process. > We need a way for the driver to retry sending the message > to the TPM service until it succeeds or we know that no forward progress > can be made. > This patch adds a parameterized variable (default 2000ms) > that indicates the maximum time to keep retrying for. > > Prachotan Bathi (1): > tpm_ffa_crb: handle tpm busy return code > > drivers/char/tpm/tpm_crb_ffa.c | 74 +++++++++++++++++++++++----------- > 1 file changed, 50 insertions(+), 24 deletions(-) > > -- > 2.43.0 > > BR, Jarkko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] tpm_ffa_crb: handle tpm busy return code 2025-06-09 21:00 ` [PATCH v1 0/1] " Jarkko Sakkinen @ 2025-06-10 21:12 ` Prachotan Bathi 2025-06-11 16:43 ` Jarkko Sakkinen 0 siblings, 1 reply; 6+ messages in thread From: Prachotan Bathi @ 2025-06-10 21:12 UTC (permalink / raw) To: Jarkko Sakkinen Cc: Peter Huewe, Jason Gunthorpe, Stuart Yoder, linux-integrity, linux-kernel Hi Jarkko Replying again, since the last email was rejected due to html content. This is building on top of commit a85b55ee64a5da58c6e2c69e2648023189210eae. A tpm service can be accessed by the driver using direct message request v2 interface according to chapter 3.3, TPM Service Command Response Buffer Interface Over FF-A specificationi v1.0 EAC. Best Prachotan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] tpm_ffa_crb: handle tpm busy return code 2025-06-10 21:12 ` Prachotan Bathi @ 2025-06-11 16:43 ` Jarkko Sakkinen 0 siblings, 0 replies; 6+ messages in thread From: Jarkko Sakkinen @ 2025-06-11 16:43 UTC (permalink / raw) To: Prachotan Bathi Cc: Peter Huewe, Jason Gunthorpe, Stuart Yoder, linux-integrity, linux-kernel On Tue, Jun 10, 2025 at 04:12:25PM -0500, Prachotan Bathi wrote: > Hi Jarkko > Replying again, since the last email was rejected due to html content. > This is building on top of commit a85b55ee64a5da58c6e2c69e2648023189210eae. > A tpm service can be accessed by the driver using direct message request v2 > interface according to chapter 3.3, TPM Service Command Response Buffer > Interface Over FF-A specificationi v1.0 EAC. > Best > Prachotan Can you mention that spec please in the next version? It's useful information to document. BR, Jarkko ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-11 16:43 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-06-09 14:15 [PATCH v1 0/1] tpm_ffa_crb: handle tpm busy return code Prachotan Bathi 2025-06-09 14:16 ` [PATCH v1 1/1] " Prachotan Bathi 2025-06-09 21:02 ` Jarkko Sakkinen 2025-06-09 21:00 ` [PATCH v1 0/1] " Jarkko Sakkinen 2025-06-10 21:12 ` Prachotan Bathi 2025-06-11 16:43 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox