* [PATCH 0/3] char: Remove redundant error messages on IRQ request failure
@ 2026-07-10 10:53 Pan Chuang
2026-07-10 10:53 ` [PATCH 2/3] tpm: Remove redundant dev_err() Pan Chuang
0 siblings, 1 reply; 3+ messages in thread
From: Pan Chuang @ 2026-07-10 10:53 UTC (permalink / raw)
To: Olivia Mackall, Herbert Xu, Hadar Gat, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Jia Jie Ho, Deepak Saxena,
Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Eli Billauer,
Arnd Bergmann, Greg Kroah-Hartman, Danilo Krummrich,
Aleksander Jan Bajkowski, Takashi Sakamoto, Bjorn Helgaas,
Pan Chuang, Uwe Kleine-König (The Capable Hub), Alper Ak,
Stefano Garzarella,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE, open list,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:TPM DEVICE DRIVER
Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()") added automatic error logging to
devm_request_threaded_irq() and devm_request_any_context_irq()
via the new devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code on failure.
Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.
Remove the now-redundant dev_err() and dev_err_probe() calls
in char drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.
Pan Chuang (3):
hwrng: drivers - Remove redundant dev_err()/dev_err_probe()
tpm: Remove redundant dev_err()
char: xillybus: Remove redundant dev_err()
drivers/char/hw_random/airoha-trng.c | 4 +---
drivers/char/hw_random/cctrng.c | 2 +-
drivers/char/hw_random/imx-rngc.c | 2 +-
drivers/char/hw_random/jh7110-trng.c | 3 +--
drivers/char/hw_random/omap-rng.c | 5 +----
drivers/char/hw_random/xgene-rng.c | 2 +-
drivers/char/tpm/st33zp24/st33zp24.c | 5 +----
drivers/char/tpm/tpm_i2c_nuvoton.c | 2 --
drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 +---
drivers/char/xillybus/xillybus_of.c | 5 +----
drivers/char/xillybus/xillybus_pcie.c | 5 +----
11 files changed, 10 insertions(+), 29 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/3] tpm: Remove redundant dev_err()
2026-07-10 10:53 [PATCH 0/3] char: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-10 10:53 ` Pan Chuang
2026-07-11 17:37 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: Pan Chuang @ 2026-07-10 10:53 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Stefano Garzarella,
Alper Ak, Pan Chuang, open list:TPM DEVICE DRIVER, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/char/tpm/st33zp24/st33zp24.c | 5 +----
drivers/char/tpm/tpm_i2c_nuvoton.c | 2 --
drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 +---
3 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
index e2b7451ea7cc..8d5179367eac 100644
--- a/drivers/char/tpm/st33zp24/st33zp24.c
+++ b/drivers/char/tpm/st33zp24/st33zp24.c
@@ -506,11 +506,8 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops,
ret = devm_request_irq(dev, irq, tpm_ioserirq_handler,
IRQF_TRIGGER_HIGH, "TPM SERIRQ management",
chip);
- if (ret < 0) {
- dev_err(&chip->dev, "TPM SERIRQ signals %d not available\n",
- irq);
+ if (ret < 0)
goto _tpm_clean_answer;
- }
intmask |= TPM_INTF_CMD_READY_INT
| TPM_INTF_STS_VALID_INT
diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_nuvoton.c
index aa3673002f3a..c84afb29d548 100644
--- a/drivers/char/tpm/tpm_i2c_nuvoton.c
+++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
@@ -576,8 +576,6 @@ static int i2c_nuvoton_probe(struct i2c_client *client)
dev_name(&chip->dev),
chip);
if (rc) {
- dev_err(dev, "%s() Unable to request irq: %d for use\n",
- __func__, priv->irq);
priv->irq = 0;
} else {
chip->flags |= TPM_CHIP_FLAG_IRQ;
diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
index b48cacacc066..7f828fae70d3 100644
--- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
+++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
@@ -751,10 +751,8 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client)
rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN,
dev->driver->name, chip);
- if (rc < 0) {
- dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
+ if (rc < 0)
return rc;
- }
priv->irq = client->irq;
} else {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/3] tpm: Remove redundant dev_err()
2026-07-10 10:53 ` [PATCH 2/3] tpm: Remove redundant dev_err() Pan Chuang
@ 2026-07-11 17:37 ` Jarkko Sakkinen
0 siblings, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2026-07-11 17:37 UTC (permalink / raw)
To: Pan Chuang
Cc: Peter Huewe, Jason Gunthorpe, Stefano Garzarella, Alper Ak,
open list:TPM DEVICE DRIVER, open list
On Fri, Jul 10, 2026 at 06:53:07PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Applied: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/
> ---
> drivers/char/tpm/st33zp24/st33zp24.c | 5 +----
> drivers/char/tpm/tpm_i2c_nuvoton.c | 2 --
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 +---
> 3 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
> index e2b7451ea7cc..8d5179367eac 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.c
> +++ b/drivers/char/tpm/st33zp24/st33zp24.c
> @@ -506,11 +506,8 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops,
> ret = devm_request_irq(dev, irq, tpm_ioserirq_handler,
> IRQF_TRIGGER_HIGH, "TPM SERIRQ management",
> chip);
> - if (ret < 0) {
> - dev_err(&chip->dev, "TPM SERIRQ signals %d not available\n",
> - irq);
> + if (ret < 0)
> goto _tpm_clean_answer;
> - }
>
> intmask |= TPM_INTF_CMD_READY_INT
> | TPM_INTF_STS_VALID_INT
> diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_nuvoton.c
> index aa3673002f3a..c84afb29d548 100644
> --- a/drivers/char/tpm/tpm_i2c_nuvoton.c
> +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
> @@ -576,8 +576,6 @@ static int i2c_nuvoton_probe(struct i2c_client *client)
> dev_name(&chip->dev),
> chip);
> if (rc) {
> - dev_err(dev, "%s() Unable to request irq: %d for use\n",
> - __func__, priv->irq);
> priv->irq = 0;
> } else {
> chip->flags |= TPM_CHIP_FLAG_IRQ;
> diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> index b48cacacc066..7f828fae70d3 100644
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -751,10 +751,8 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client)
> rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
> IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN,
> dev->driver->name, chip);
> - if (rc < 0) {
> - dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
> + if (rc < 0)
> return rc;
> - }
>
> priv->irq = client->irq;
> } else {
> --
> 2.34.1
>
BR, Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-11 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 10:53 [PATCH 0/3] char: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-10 10:53 ` [PATCH 2/3] tpm: Remove redundant dev_err() Pan Chuang
2026-07-11 17:37 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox