Linux Integrity Measurement development
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Takashi Iwai <tiwai@suse.de>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joey Lee <jlee@suse.com>
Subject: Re: [PATCH] ima: Fix undefined arch_ima_get_secureboot() and co
Date: Tue, 14 Dec 2021 10:31:21 -0500	[thread overview]
Message-ID: <d99fc78005d8a245449dd6ca0158cf9e2a897465.camel@linux.ibm.com> (raw)
In-Reply-To: <20211213161145.3447-1-tiwai@suse.de>

Hi Takashi,

On Mon, 2021-12-13 at 17:11 +0100, Takashi Iwai wrote:
> Currently arch_ima_get_secureboot() and arch_get_ima_policy() are
> defined only when CONFIG_IMA is set, and this makes the code calling
> those functions without CONFIG_IMA failing.  Although there is no such
> in-tree users, but the out-of-tree users already hit it.
> 
> Move the declaration and the dummy definition of those functions
> outside ifdef-CONFIG_IMA block for fixing the undefined symbols.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Before lockdown was upstreamed, we made sure that IMA and lockdown
could co-exist.  This patch makes the stub functions available even
when IMA is not configured.  Do the remaining downstream patches
require IMA to be disabled or can IMA co-exist?

thanks,

Mimi


  reply	other threads:[~2021-12-14 15:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 16:11 [PATCH] ima: Fix undefined arch_ima_get_secureboot() and co Takashi Iwai
2021-12-14 15:31 ` Mimi Zohar [this message]
2021-12-14 15:58   ` Takashi Iwai
2021-12-15 16:03     ` joeyli
2021-12-15 18:16       ` Mimi Zohar
2021-12-16  4:32         ` joeyli
2021-12-16 13:22           ` Mimi Zohar
2021-12-18  2:27             ` joeyli
2021-12-22 17:10 ` Mimi Zohar
2021-12-22 19:15   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d99fc78005d8a245449dd6ca0158cf9e2a897465.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=jlee@suse.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox