From: Takashi Iwai <tiwai@suse.de>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
Joey Lee <jlee@suse.com>
Subject: Re: [PATCH] ima: Fix undefined arch_ima_get_secureboot() and co
Date: Wed, 22 Dec 2021 20:15:51 +0100 [thread overview]
Message-ID: <s5hmtksqwm0.wl-tiwai@suse.de> (raw)
In-Reply-To: <be59880bb5be18207eeb91b920f43d05fa3a1dd2.camel@linux.ibm.com>
On Wed, 22 Dec 2021 18:10:05 +0100,
Mimi Zohar wrote:
>
> Hi Takashi,
>
> On Mon, 2021-12-13 at 17:11 +0100, Takashi Iwai wrote:
> > Currently arch_ima_get_secureboot() and arch_get_ima_policy() are
> > defined only when CONFIG_IMA is set, and this makes the code calling
> > those functions without CONFIG_IMA failing. Although there is no such
> > in-tree users, but the out-of-tree users already hit it.
> >
> > Move the declaration and the dummy definition of those functions
> > outside ifdef-CONFIG_IMA block for fixing the undefined symbols.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> Joey's patch has a dependency on your patch, as seen by the kernel test
> robot report. I'll drop the one line referencing in-tree/out-of-tree
> sentence in the patch description, before picking it up as well.
Sure, feel free to cook it :)
thanks,
Takashi
prev parent reply other threads:[~2021-12-22 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 16:11 [PATCH] ima: Fix undefined arch_ima_get_secureboot() and co Takashi Iwai
2021-12-14 15:31 ` Mimi Zohar
2021-12-14 15:58 ` Takashi Iwai
2021-12-15 16:03 ` joeyli
2021-12-15 18:16 ` Mimi Zohar
2021-12-16 4:32 ` joeyli
2021-12-16 13:22 ` Mimi Zohar
2021-12-18 2:27 ` joeyli
2021-12-22 17:10 ` Mimi Zohar
2021-12-22 19:15 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmtksqwm0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dmitry.kasatkin@gmail.com \
--cc=jlee@suse.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox