Re: [PATCH v1 12/13] iommu/amd: Remove unused flush pasid functions

[Vasant Hegde <vasant.hegde@amd.com>]

On 11/5/2023 11:28 PM, Jason Gunthorpe wrote:
> On Fri, Oct 06, 2023 at 10:16:23AM +0000, Vasant Hegde wrote:
>> We have removed iommu_v2 module and converted v2 page table to use
>> common flush functions. PASID related functions are not used.
>>
>> Also when we add SVA support we will be moving to per device GCR3 table.
>> We cannot use current flush pasid functions as is. Hence remove these
>> unused functions.
>>
>> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
>> ---
>>  drivers/iommu/amd/amd_iommu.h |   3 +-
>>  drivers/iommu/amd/iommu.c     | 100 ----------------------------------
>>  2 files changed, 1 insertion(+), 102 deletions(-)
>>
>> diff --git a/drivers/iommu/amd/amd_iommu.h b/drivers/iommu/amd/amd_iommu.h
>> index 088890f9618a..38b3f4562f3b 100644
>> --- a/drivers/iommu/amd/amd_iommu.h
>> +++ b/drivers/iommu/amd/amd_iommu.h
>> @@ -53,7 +53,6 @@ int amd_iommu_pdev_enable_cap_pri(struct pci_dev *pdev);
>>  void amd_iommu_pdev_disable_cap_pri(struct pci_dev *pdev);
> 
> Maybe this addresses my earlier remark about _pages?

Yes.

-Vasant

> 
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> 
> Jason