Re: [PATCH 3/7] iommu/vtd: Do not wipe out the page table NID when devices detach

[Baolu Lu <baolu.lu@linux.intel.com>]

On 6/10/25 03:58, Jason Gunthorpe wrote:
> The NID is used to control which NUMA node memory for the page table is
> allocated it from. It should be a permanent property of the page table
> when it was allocated and not change during attach/detach of devices.
> 
> Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
> ---
>   drivers/iommu/intel/iommu.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index ceb960a796e2ba..72b0769c391008 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1391,7 +1391,6 @@ void domain_detach_iommu(struct dmar_domain *domain, struct intel_iommu *iommu)
>   	if (--info->refcnt == 0) {
>   		ida_free(&iommu->domain_ida, info->did);
>   		xa_erase(&domain->iommu_array, iommu->seq_id);
> -		domain->nid = NUMA_NO_NODE;

It appears that this is a fix. Before domain_alloc()'s retirement, no
device pointer was passed to the domain allocation callback. Thus, the
NUMA node ID could only be determined when the domain was attached to a
device. Since we have introduced domain_alloc_paging, this should be
removed. So,

Fixes: 7c204426b818 ("iommu/vt-d: Add domain_alloc_paging support")

?

Thanks,
baolu