Linux IOMMU Development
 help / color / mirror / Atom feed
* [RFC Patch V1] iommu/vt-d: Fix build failure caused by incorrect Kconfig
       [not found] ` <1422713299.3030.23.camel-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
@ 2015-02-02  3:07   ` Jiang Liu
  0 siblings, 0 replies; only message in thread
From: Jiang Liu @ 2015-02-02  3:07 UTC (permalink / raw)
  To: Joerg Roedel, David Woodhouse, Yann Droneaud, Tony Luck,
	Fenghua Yu
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	x86-DgEjT+Ai2ygdnm+yROfE0A, Jiang Liu,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org> reported one build failure as
below, which should be caused by incorrect Kconfig.
  CC      arch/ia64/kernel/pci-dma.o
../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_init':
../arch/ia64/kernel/pci-dma.c:41:3: error: implicit declaration of function 'intel_iommu_init' [-Werror=implicit-function-declaration]
   intel_iommu_init();
   ^
../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_alloc':
../arch/ia64/kernel/pci-dma.c:103:2: error: implicit declaration of function 'detect_intel_iommu' [-Werror=implicit-function-declaration]
  detect_intel_iommu();
  ^

It should be noted Kconfig complain with the following:

warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))

Signed-off-by: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
Hi Yann,
	Could you please help to test whether this patch fix the build
failure and the Kconfig warnings?
Thanks!
Gerry
---
 drivers/iommu/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index 325188eef1c1..718a0c9f7bdc 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -89,7 +89,7 @@ config DMAR_TABLE
 
 config INTEL_IOMMU
 	bool "Support for Intel IOMMU using DMA Remapping Devices"
-	depends on PCI_MSI && ACPI && (X86 || IA64_GENERIC)
+	depends on PCI_MSI && ACPI && (X86 || IA64_DIG_VTD)
 	select IOMMU_API
 	select DMAR_TABLE
 	help
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-02-02  3:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1422713299.3030.23.camel@opteya.com>
     [not found] ` <1422713299.3030.23.camel-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2015-02-02  3:07   ` [RFC Patch V1] iommu/vt-d: Fix build failure caused by incorrect Kconfig Jiang Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox