From: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Alex Williamson
<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [GIT PULL] Intel IOMMU for 4.1
Date: Mon, 27 Apr 2015 18:12:32 +0100 [thread overview]
Message-ID: <1430154752.6377.19.camel@infradead.org> (raw)
In-Reply-To: <1430149195.4472.43.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1303 bytes --]
On Mon, 2015-04-27 at 09:39 -0600, Alex Williamson wrote:
> David,
>
> Since this got pulled anyway, do you plan to follow-up with patches to
> limit the graphics RMRR exception to the known and acceptable uses and
> document them, or should I send a revert patch? I don't think what we
> have here is acceptable going forward or being backported to stable.
> Thanks,
I didn't plan to, no. So far we *only* know of acceptable uses of RMRR
on graphics devices, and the false positives that Linda mentioned.
The only cases we ever saw of RMRR being *problematic* when we tried
to assign devices to guests were non-graphics devices, weren't they?
Although obviously I'm looking into the oops that sl4ever reported;
currently I'm wondering if that was broken even before your patch that
blacklisted all RMRR-afflicted devices. It looks like
device_to_iommu() doesn't return the correct results for devices
behind a disabled IOMMU; it incorrectly attributes them to a catch-all
IOMMU instead.
Or perhaps this is probably tied into the fact that your patch broke
iommu=pt for RMRR-afflicted devices too. They currently get full
translation. Which surely shouldn't be necessary, since passthrough
mode would obviously *also* preserve the RMRR regions of 1:1 mappings.
--
dwmw2
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-04-27 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 8:51 [GIT PULL] Intel IOMMU for 4.1 David Woodhouse
[not found] ` <1430038266.4833.14.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-26 17:33 ` Alex Williamson
[not found] ` <1430069591.8301.91.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-26 17:55 ` David Woodhouse
[not found] ` <1430070924.13479.5.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-26 18:16 ` Alex Williamson
[not found] ` <1430072207.8301.103.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-27 14:00 ` Linda Knippers
[not found] ` <553E4109.5060903-VXdhtT5mjnY@public.gmane.org>
2015-04-27 15:39 ` Alex Williamson
[not found] ` <1430149195.4472.43.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-27 15:48 ` Linus Torvalds
[not found] ` <CA+55aFx+QhMZpCtnG2sHib+kk5BR+PeEa99-CCushSA5oAqVxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-27 16:09 ` Linda Knippers
2015-04-27 16:16 ` Alex Williamson
2015-04-27 17:28 ` David Woodhouse
2015-04-27 17:12 ` David Woodhouse [this message]
[not found] ` <1430154752.6377.19.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-04-27 17:30 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430154752.6377.19.camel@infradead.org \
--to=dwmw2-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox