Linux IOMMU Development
 help / color / mirror / Atom feed
From: Suravee Suthikulpanit <Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org
Subject: [PATCH v7 5/7] perf/amd/iommu: Clean up perf_iommu_enable_event
Date: Mon, 9 Jan 2017 21:33:45 -0600	[thread overview]
Message-ID: <1484019227-11473-6-git-send-email-Suravee.Suthikulpanit@amd.com> (raw)
In-Reply-To: <1484019227-11473-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>

This patch cleans up:
  * Various bitwise operations in perf_iommu_enable_event
  * Make use macros BIT(x)

This should not affect logic and functionality.

Cc: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
---
 arch/x86/events/amd/iommu.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
index 9bff41d..2403c78 100644
--- a/arch/x86/events/amd/iommu.c
+++ b/arch/x86/events/amd/iommu.c
@@ -258,21 +258,21 @@ static void perf_iommu_enable_event(struct perf_event *ev)
 	amd_iommu_pc_set_reg(0, devid, bank, cntr,
 			     IOMMU_PC_COUNTER_SRC_REG, &reg);
 
-	reg = 0ULL | devid | (_GET_DEVID_MASK(ev) << 32);
+	reg = devid | (_GET_DEVID_MASK(ev) << 32);
 	if (reg)
-		reg |= (1UL << 31);
+		reg |= BIT(31);
 	amd_iommu_pc_set_reg(0, devid, bank, cntr,
 			     IOMMU_PC_DEVID_MATCH_REG, &reg);
 
-	reg = 0ULL | _GET_PASID(ev) | (_GET_PASID_MASK(ev) << 32);
+	reg = _GET_PASID(ev) | (_GET_PASID_MASK(ev) << 32);
 	if (reg)
-		reg |= (1UL << 31);
+		reg |= BIT(31);
 	amd_iommu_pc_set_reg(0, devid, bank, cntr,
 			     IOMMU_PC_PASID_MATCH_REG, &reg);
 
-	reg = 0ULL | _GET_DOMID(ev) | (_GET_DOMID_MASK(ev) << 32);
+	reg = _GET_DOMID(ev) | (_GET_DOMID_MASK(ev) << 32);
 	if (reg)
-		reg |= (1UL << 31);
+		reg |= BIT(31);
 	amd_iommu_pc_set_reg(0, devid, bank, cntr,
 			     IOMMU_PC_DOMID_MATCH_REG, &reg);
 }
-- 
1.8.3.1

  parent reply	other threads:[~2017-01-10  3:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10  3:33 [PATCH v7 0/7] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
     [not found] ` <1484019227-11473-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-10  3:33   ` [PATCH v7 1/7] perf/amd/iommu: Misc fix up perf_iommu_read Suravee Suthikulpanit
     [not found]     ` <1484019227-11473-2-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-11 10:32       ` Borislav Petkov
2017-01-11 11:57       ` Peter Zijlstra
     [not found]         ` <20170111115735.GI3107-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-01-15  2:36           ` Suravee Suthikulpanit
     [not found]             ` <8d529523-21b4-d917-e83f-ed616a29083c-5C7GfCeVMHo@public.gmane.org>
2017-01-19 10:14               ` Peter Zijlstra
2017-01-10  3:33   ` [PATCH v7 2/7] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
     [not found]     ` <1484019227-11473-3-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-10 14:43       ` Joerg Roedel
     [not found]         ` <20170110144340.GT17255-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-11  3:03           ` Suravee Suthikulpanit
     [not found]             ` <862635a0-a4fc-066e-0a45-e8626a02775c-5C7GfCeVMHo@public.gmane.org>
2017-01-11  8:13               ` Boris Petkov
     [not found]                 ` <1EEB747F-DD67-4BEC-9B07-F449520B3666-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2017-01-11  9:14                   ` Suravee Suthikulpanit
2017-01-10  3:33   ` [PATCH v7 3/7] perf/amd/iommu: Modify IOMMU API to allow specifying IOMMU index Suravee Suthikulpanit
2017-01-11 17:23     ` Borislav Petkov
2017-01-10  3:33   ` [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Suravee Suthikulpanit
2017-01-12 10:19     ` Borislav Petkov
     [not found]       ` <20170112101942.5z6e6s344awbi4uk-fF5Pk5pvG8Y@public.gmane.org>
2017-01-14 10:13         ` Suravee Suthikulpanit
2017-01-10  3:33   ` Suravee Suthikulpanit [this message]
     [not found]     ` <1484019227-11473-6-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-12 14:14       ` [PATCH v7 5/7] perf/amd/iommu: Clean up perf_iommu_enable_event Borislav Petkov
2017-01-10  3:33   ` [PATCH v7 6/7] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2017-01-12 14:21     ` Borislav Petkov
2017-01-10  3:33   ` [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
     [not found]     ` <1484019227-11473-8-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-12 17:52       ` Borislav Petkov
     [not found]         ` <20170112175223.qsui53kln7vpmwop-fF5Pk5pvG8Y@public.gmane.org>
2017-01-13 10:24           ` Suravee Suthikulpanit
2017-01-13 11:49             ` Borislav Petkov
     [not found]               ` <20170113114925.x6f4r5qcidksnfes-fF5Pk5pvG8Y@public.gmane.org>
2017-01-14  2:58                 ` Suravee Suthikulpanit
     [not found]                   ` <46834d61-d8b2-201f-99dd-5727994281a5-5C7GfCeVMHo@public.gmane.org>
2017-01-14 10:29                     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484019227-11473-6-git-send-email-Suravee.Suthikulpanit@amd.com \
    --to=suravee.suthikulpanit-5c7gfcevmho@public.gmane.org \
    --cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox