From: Suravee Suthikulpanit <Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
To: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug
Date: Sat, 14 Jan 2017 17:13:33 +0700 [thread overview]
Message-ID: <fdbd3d91-9b01-20a2-50a7-1ae6a0d71a47@amd.com> (raw)
In-Reply-To: <20170112101942.5z6e6s344awbi4uk-fF5Pk5pvG8Y@public.gmane.org>
On 1/12/17 17:19, Borislav Petkov wrote:
> Also, looking at that driver more, this needs to die, like now:
>
> #define format_group attr_groups[0]
> #define cpumask_group attr_groups[1]
> #define events_group attr_groups[2]
> #define null_group attr_groups[3]
>
> Like, kill it dead. Define a separate array, look what the other drivers
> do, whatever, but this is too ugly to live.
>
> Thanks.
>
> --
Okay... you got it :)
S
next prev parent reply other threads:[~2017-01-14 10:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 3:33 [PATCH v7 0/7] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
[not found] ` <1484019227-11473-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-10 3:33 ` [PATCH v7 1/7] perf/amd/iommu: Misc fix up perf_iommu_read Suravee Suthikulpanit
[not found] ` <1484019227-11473-2-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-11 10:32 ` Borislav Petkov
2017-01-11 11:57 ` Peter Zijlstra
[not found] ` <20170111115735.GI3107-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-01-15 2:36 ` Suravee Suthikulpanit
[not found] ` <8d529523-21b4-d917-e83f-ed616a29083c-5C7GfCeVMHo@public.gmane.org>
2017-01-19 10:14 ` Peter Zijlstra
2017-01-10 3:33 ` [PATCH v7 2/7] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
[not found] ` <1484019227-11473-3-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-10 14:43 ` Joerg Roedel
[not found] ` <20170110144340.GT17255-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-11 3:03 ` Suravee Suthikulpanit
[not found] ` <862635a0-a4fc-066e-0a45-e8626a02775c-5C7GfCeVMHo@public.gmane.org>
2017-01-11 8:13 ` Boris Petkov
[not found] ` <1EEB747F-DD67-4BEC-9B07-F449520B3666-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2017-01-11 9:14 ` Suravee Suthikulpanit
2017-01-10 3:33 ` [PATCH v7 3/7] perf/amd/iommu: Modify IOMMU API to allow specifying IOMMU index Suravee Suthikulpanit
2017-01-11 17:23 ` Borislav Petkov
2017-01-10 3:33 ` [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Suravee Suthikulpanit
2017-01-12 10:19 ` Borislav Petkov
[not found] ` <20170112101942.5z6e6s344awbi4uk-fF5Pk5pvG8Y@public.gmane.org>
2017-01-14 10:13 ` Suravee Suthikulpanit [this message]
2017-01-10 3:33 ` [PATCH v7 5/7] perf/amd/iommu: Clean up perf_iommu_enable_event Suravee Suthikulpanit
[not found] ` <1484019227-11473-6-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-12 14:14 ` Borislav Petkov
2017-01-10 3:33 ` [PATCH v7 6/7] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2017-01-12 14:21 ` Borislav Petkov
2017-01-10 3:33 ` [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
[not found] ` <1484019227-11473-8-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-01-12 17:52 ` Borislav Petkov
[not found] ` <20170112175223.qsui53kln7vpmwop-fF5Pk5pvG8Y@public.gmane.org>
2017-01-13 10:24 ` Suravee Suthikulpanit
2017-01-13 11:49 ` Borislav Petkov
[not found] ` <20170113114925.x6f4r5qcidksnfes-fF5Pk5pvG8Y@public.gmane.org>
2017-01-14 2:58 ` Suravee Suthikulpanit
[not found] ` <46834d61-d8b2-201f-99dd-5727994281a5-5C7GfCeVMHo@public.gmane.org>
2017-01-14 10:29 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdbd3d91-9b01-20a2-50a7-1ae6a0d71a47@amd.com \
--to=suravee.suthikulpanit-5c7gfcevmho@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox