Linux IOMMU Development
 help / color / mirror / Atom feed
* [RFC PATCHv3 02/11] iommu/omap: Use get_vm_area directly
       [not found] <1388699609-18214-1-git-send-email-lauraa@codeaurora.org>
@ 2014-01-02 21:53 ` Laura Abbott
  2014-01-03  2:40   ` Chen, Gong
  0 siblings, 1 reply; 2+ messages in thread
From: Laura Abbott @ 2014-01-02 21:53 UTC (permalink / raw)
  To: Andrew Morton, Kyungmin Park, Dave Hansen, linux-mm, Joerg Roedel
  Cc: linux-kernel, Laura Abbott, iommu

There is no need to call __get_vm_area with VMALLOC_START and
VMALLOC_END when get_vm_area already does that. Call get_vm_area
directly.

Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
---
 drivers/iommu/omap-iovmm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c
index d147259..6280d50 100644
--- a/drivers/iommu/omap-iovmm.c
+++ b/drivers/iommu/omap-iovmm.c
@@ -214,7 +214,7 @@ static void *vmap_sg(const struct sg_table *sgt)
 	if (!total)
 		return ERR_PTR(-EINVAL);
 
-	new = __get_vm_area(total, VM_IOREMAP, VMALLOC_START, VMALLOC_END);
+	new = get_vm_area(total, VM_IOREMAP);
 	if (!new)
 		return ERR_PTR(-ENOMEM);
 	va = (u32)new->addr;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC PATCHv3 02/11] iommu/omap: Use get_vm_area directly
  2014-01-02 21:53 ` [RFC PATCHv3 02/11] iommu/omap: Use get_vm_area directly Laura Abbott
@ 2014-01-03  2:40   ` Chen, Gong
  0 siblings, 0 replies; 2+ messages in thread
From: Chen, Gong @ 2014-01-03  2:40 UTC (permalink / raw)
  To: Laura Abbott
  Cc: Andrew Morton, Kyungmin Park, Dave Hansen, linux-mm, Joerg Roedel,
	linux-kernel, iommu

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On Thu, Jan 02, 2014 at 01:53:20PM -0800, Laura Abbott wrote:
> diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c
> index d147259..6280d50 100644
> --- a/drivers/iommu/omap-iovmm.c
> +++ b/drivers/iommu/omap-iovmm.c
> @@ -214,7 +214,7 @@ static void *vmap_sg(const struct sg_table *sgt)
>  	if (!total)
>  		return ERR_PTR(-EINVAL);
>  
> -	new = __get_vm_area(total, VM_IOREMAP, VMALLOC_START, VMALLOC_END);
> +	new = get_vm_area(total, VM_IOREMAP);
This driver is a module but get_vm_area is not exported. You need to add
one extra EXPORT_SYMBOL_GPL(get_vm_area).


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-03  2:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1388699609-18214-1-git-send-email-lauraa@codeaurora.org>
2014-01-02 21:53 ` [RFC PATCHv3 02/11] iommu/omap: Use get_vm_area directly Laura Abbott
2014-01-03  2:40   ` Chen, Gong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox