* [PATCH] iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids
@ 2015-03-17 0:06 Axel Lin
2015-03-17 23:28 ` Laurent Pinchart
2015-03-23 14:24 ` Joerg Roedel
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2015-03-17 0:06 UTC (permalink / raw)
To: Joerg Roedel
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Laurent Pinchart
The of_device_id table is supposed to be zero-terminated.
Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
drivers/iommu/ipmmu-vmsa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
index 10186ca..bc39bdf 100644
--- a/drivers/iommu/ipmmu-vmsa.c
+++ b/drivers/iommu/ipmmu-vmsa.c
@@ -851,6 +851,7 @@ static int ipmmu_remove(struct platform_device *pdev)
static const struct of_device_id ipmmu_of_ids[] = {
{ .compatible = "renesas,ipmmu-vmsa", },
+ { }
};
static struct platform_driver ipmmu_driver = {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids
2015-03-17 0:06 [PATCH] iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids Axel Lin
@ 2015-03-17 23:28 ` Laurent Pinchart
2015-03-18 16:05 ` [V4.0 REGRESSION FIX] " Laurent Pinchart
2015-03-23 14:24 ` Joerg Roedel
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2015-03-17 23:28 UTC (permalink / raw)
To: Axel Lin,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Hi Axel,
Thank you for the patch.
On Tuesday 17 March 2015 08:06:45 Axel Lin wrote:
> The of_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Joerg, I don't have anything queued up at the moment, could you please pick
the patch from the list ?
> ---
> drivers/iommu/ipmmu-vmsa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index 10186ca..bc39bdf 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -851,6 +851,7 @@ static int ipmmu_remove(struct platform_device *pdev)
>
> static const struct of_device_id ipmmu_of_ids[] = {
> { .compatible = "renesas,ipmmu-vmsa", },
> + { }
> };
>
> static struct platform_driver ipmmu_driver = {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [V4.0 REGRESSION FIX] [PATCH] iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids
2015-03-17 23:28 ` Laurent Pinchart
@ 2015-03-18 16:05 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2015-03-18 16:05 UTC (permalink / raw)
To: Joerg Roedel
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Axel Lin
Hi Joerg,
On Wednesday 18 March 2015 01:28:50 Laurent Pinchart wrote:
> On Tuesday 17 March 2015 08:06:45 Axel Lin wrote:
> > The of_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
>
> Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
>
> Joerg, I don't have anything queued up at the moment, could you please pick
> the patch from the list ?
Thinking twice about this, as DT support has been introduced in v4.0-rc1, so
this is a v4.0 regression fix. Could you push it to Linus for v4.0 ?
> > ---
> >
> > drivers/iommu/ipmmu-vmsa.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> > index 10186ca..bc39bdf 100644
> > --- a/drivers/iommu/ipmmu-vmsa.c
> > +++ b/drivers/iommu/ipmmu-vmsa.c
> > @@ -851,6 +851,7 @@ static int ipmmu_remove(struct platform_device *pdev)
> >
> > static const struct of_device_id ipmmu_of_ids[] = {
> > { .compatible = "renesas,ipmmu-vmsa", },
> > + { }
> > };
> >
> > static struct platform_driver ipmmu_driver = {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids
2015-03-17 0:06 [PATCH] iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids Axel Lin
2015-03-17 23:28 ` Laurent Pinchart
@ 2015-03-23 14:24 ` Joerg Roedel
1 sibling, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2015-03-23 14:24 UTC (permalink / raw)
To: Axel Lin
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Laurent Pinchart
On Tue, Mar 17, 2015 at 08:06:45AM +0800, Axel Lin wrote:
> The of_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Applied to iommu/fixes, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-23 14:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-17 0:06 [PATCH] iommu: ipmmu-vmsa: Add terminating entry for ipmmu_of_ids Axel Lin
2015-03-17 23:28 ` Laurent Pinchart
2015-03-18 16:05 ` [V4.0 REGRESSION FIX] " Laurent Pinchart
2015-03-23 14:24 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox