[PATCH] intel-iommu: fix up comment

[PATCH] intel-iommu: fix up comment

[Michael S. Tsirkin]

dma_pte_free_pagetable no longer depends on
last level ptes being clear, it clears them itself.
Fix up the comment to match.

Cc: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Suggested-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index a2e1b7f..0100553 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -1143,7 +1143,7 @@ next:
 	} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
 }
 
-/* free page table pages. last level pte should already be cleared */
+/* clear last level (leaf) ptes and free page table pages. */
 static void dma_pte_free_pagetable(struct dmar_domain *domain,
 				   unsigned long start_pfn,
 				   unsigned long last_pfn)
-- 
MST

Re: [PATCH] intel-iommu: fix up comment

[Michael S. Tsirkin]

On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
> 
> Cc: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Suggested-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Anyone?

> ---
>  drivers/iommu/intel-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index a2e1b7f..0100553 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -1143,7 +1143,7 @@ next:
>  	} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
>  }
>  
> -/* free page table pages. last level pte should already be cleared */
> +/* clear last level (leaf) ptes and free page table pages. */
>  static void dma_pte_free_pagetable(struct dmar_domain *domain,
>  				   unsigned long start_pfn,
>  				   unsigned long last_pfn)
> -- 
> MST

Re: [PATCH] intel-iommu: fix up comment

[Joerg Roedel]

On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
> 
> Cc: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Suggested-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/iommu/intel-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied. I changed the subject to:

	x86/vt-d: Fix comment for dma_pte_free_pagetable()

Please use similar format for iommu-patches in the future.


Thanks,

	Joerg