* [PATCH 0/3] iommu: Kerneldoc improvements
@ 2019-02-20 13:00 Geert Uytterhoeven
2019-02-20 13:00 ` [PATCH 1/3] iommu: Fix kerneldoc for iommu_ops.flush_iotlb_all() Geert Uytterhoeven
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-02-20 13:00 UTC (permalink / raw)
To: Joerg Roedel
Cc: Dmitry Osipenko, Baoquan He, iommu, linux-kernel,
Geert Uytterhoeven
Hi Jörg,
This series contains a fix for an incorrect kerneldoc parameter, and
adds the missing kerneldoc for two recently added IOMMU methods.
Thanks!
Geert Uytterhoeven (3):
iommu: Fix kerneldoc for iommu_ops.flush_iotlb_all()
iommu: Document iommu_ops.iotlb_sync_map()
iommu: Document iommu_ops.is_attach_deferred()
include/linux/iommu.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/3] iommu: Fix kerneldoc for iommu_ops.flush_iotlb_all()
2019-02-20 13:00 [PATCH 0/3] iommu: Kerneldoc improvements Geert Uytterhoeven
@ 2019-02-20 13:00 ` Geert Uytterhoeven
2019-02-20 13:00 ` [PATCH 2/3] iommu: Document iommu_ops.iotlb_sync_map() Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-02-20 13:00 UTC (permalink / raw)
To: Joerg Roedel
Cc: Dmitry Osipenko, Baoquan He, iommu, linux-kernel,
Geert Uytterhoeven
While the API wrapper is called iommu_flush_tlb_all(), the actual
iommu_ops method is called .flush_iotlb_all(), not .flush_tlb_all().
Fixes: add02cfdc9bc2987 ("iommu: Introduce Interface for IOMMU TLB Flushing")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
include/linux/iommu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 477ef47c357c0553..848fb07026b67169 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -167,7 +167,7 @@ struct iommu_resv_region {
* @detach_dev: detach device from an iommu domain
* @map: map a physically contiguous memory region to an iommu domain
* @unmap: unmap a physically contiguous memory region from an iommu domain
- * @flush_tlb_all: Synchronously flush all hardware TLBs for this domain
+ * @flush_iotlb_all: Synchronously flush all hardware TLBs for this domain
* @iotlb_range_add: Add a given iova range to the flush queue for this domain
* @iotlb_sync: Flush all queued ranges from the hardware TLBs and empty flush
* queue
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] iommu: Document iommu_ops.iotlb_sync_map()
2019-02-20 13:00 [PATCH 0/3] iommu: Kerneldoc improvements Geert Uytterhoeven
2019-02-20 13:00 ` [PATCH 1/3] iommu: Fix kerneldoc for iommu_ops.flush_iotlb_all() Geert Uytterhoeven
@ 2019-02-20 13:00 ` Geert Uytterhoeven
2019-02-20 13:39 ` Dmitry Osipenko
2019-02-20 13:00 ` [PATCH 3/3] iommu: Document iommu_ops.is_attach_deferred() Geert Uytterhoeven
2019-02-26 10:10 ` [PATCH 0/3] iommu: Kerneldoc improvements Joerg Roedel
3 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-02-20 13:00 UTC (permalink / raw)
To: Joerg Roedel
Cc: Dmitry Osipenko, Baoquan He, iommu, linux-kernel,
Geert Uytterhoeven
Add missing kerneldoc for iommu_ops.iotlb_sync_map().
Fixes: 1d7ae53b152dbc5b ("iommu: Introduce iotlb_sync_map callback")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
include/linux/iommu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 848fb07026b67169..3ed5d372b090af54 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -169,6 +169,7 @@ struct iommu_resv_region {
* @unmap: unmap a physically contiguous memory region from an iommu domain
* @flush_iotlb_all: Synchronously flush all hardware TLBs for this domain
* @iotlb_range_add: Add a given iova range to the flush queue for this domain
+ * @iotlb_sync_map: Sync mappings created recently using @map to the hardware
* @iotlb_sync: Flush all queued ranges from the hardware TLBs and empty flush
* queue
* @iova_to_phys: translate iova to physical address
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/3] iommu: Document iommu_ops.iotlb_sync_map()
2019-02-20 13:00 ` [PATCH 2/3] iommu: Document iommu_ops.iotlb_sync_map() Geert Uytterhoeven
@ 2019-02-20 13:39 ` Dmitry Osipenko
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2019-02-20 13:39 UTC (permalink / raw)
To: Geert Uytterhoeven, Joerg Roedel; +Cc: Baoquan He, iommu, linux-kernel
20.02.2019 16:00, Geert Uytterhoeven пишет:
> Add missing kerneldoc for iommu_ops.iotlb_sync_map().
>
> Fixes: 1d7ae53b152dbc5b ("iommu: Introduce iotlb_sync_map callback")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> include/linux/iommu.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 848fb07026b67169..3ed5d372b090af54 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -169,6 +169,7 @@ struct iommu_resv_region {
> * @unmap: unmap a physically contiguous memory region from an iommu domain
> * @flush_iotlb_all: Synchronously flush all hardware TLBs for this domain
> * @iotlb_range_add: Add a given iova range to the flush queue for this domain
> + * @iotlb_sync_map: Sync mappings created recently using @map to the hardware
> * @iotlb_sync: Flush all queued ranges from the hardware TLBs and empty flush
> * queue
> * @iova_to_phys: translate iova to physical address
>
Pretty sure there was a kerneldoc in some version of the original patch that introduced the iotlb_sync_map(), but probably it got lost after a rebase. The kerneldoc comment is correct, thank you! BTW, for some reason gmail marked this series as a spam, maybe you need to check the email headers and whatnot.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] iommu: Document iommu_ops.is_attach_deferred()
2019-02-20 13:00 [PATCH 0/3] iommu: Kerneldoc improvements Geert Uytterhoeven
2019-02-20 13:00 ` [PATCH 1/3] iommu: Fix kerneldoc for iommu_ops.flush_iotlb_all() Geert Uytterhoeven
2019-02-20 13:00 ` [PATCH 2/3] iommu: Document iommu_ops.iotlb_sync_map() Geert Uytterhoeven
@ 2019-02-20 13:00 ` Geert Uytterhoeven
2019-02-26 10:10 ` [PATCH 0/3] iommu: Kerneldoc improvements Joerg Roedel
3 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-02-20 13:00 UTC (permalink / raw)
To: Joerg Roedel
Cc: Dmitry Osipenko, Baoquan He, iommu, linux-kernel,
Geert Uytterhoeven
Add missing kerneldoc for iommu_ops.is_attach_deferred().
Fixes: e01d1913b0d08171 ("iommu: Add is_attach_deferred call-back to iommu-ops")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
include/linux/iommu.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 3ed5d372b090af54..ffbbc7e39ceeba3e 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -184,6 +184,8 @@ struct iommu_resv_region {
* @domain_window_enable: Configure and enable a particular window for a domain
* @domain_window_disable: Disable a particular window for a domain
* @of_xlate: add OF master IDs to iommu grouping
+ * @is_attach_deferred: Check if domain attach should be deferred from iommu
+ * driver init to device driver init (default no)
* @pgsize_bitmap: bitmap of all possible supported page sizes
*/
struct iommu_ops {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] iommu: Kerneldoc improvements
2019-02-20 13:00 [PATCH 0/3] iommu: Kerneldoc improvements Geert Uytterhoeven
` (2 preceding siblings ...)
2019-02-20 13:00 ` [PATCH 3/3] iommu: Document iommu_ops.is_attach_deferred() Geert Uytterhoeven
@ 2019-02-26 10:10 ` Joerg Roedel
3 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2019-02-26 10:10 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Dmitry Osipenko, Baoquan He, iommu, linux-kernel
Hi Geert,
On Wed, Feb 20, 2019 at 02:00:50PM +0100, Geert Uytterhoeven wrote:
> This series contains a fix for an incorrect kerneldoc parameter, and
> adds the missing kerneldoc for two recently added IOMMU methods.
>
> Thanks!
>
> Geert Uytterhoeven (3):
> iommu: Fix kerneldoc for iommu_ops.flush_iotlb_all()
> iommu: Document iommu_ops.iotlb_sync_map()
> iommu: Document iommu_ops.is_attach_deferred()
>
> include/linux/iommu.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied patches 2 and 3, I already have a change similar to patch 1 in
the tree.
Thanks,
Joerg
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-26 10:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-20 13:00 [PATCH 0/3] iommu: Kerneldoc improvements Geert Uytterhoeven
2019-02-20 13:00 ` [PATCH 1/3] iommu: Fix kerneldoc for iommu_ops.flush_iotlb_all() Geert Uytterhoeven
2019-02-20 13:00 ` [PATCH 2/3] iommu: Document iommu_ops.iotlb_sync_map() Geert Uytterhoeven
2019-02-20 13:39 ` Dmitry Osipenko
2019-02-20 13:00 ` [PATCH 3/3] iommu: Document iommu_ops.is_attach_deferred() Geert Uytterhoeven
2019-02-26 10:10 ` [PATCH 0/3] iommu: Kerneldoc improvements Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox