Linux IOMMU Development
 help / color / mirror / Atom feed
* [linux-next:master 4470/4908] drivers/iommu/iommu.c:1857:5: sparse: sparse: symbol '__iommu_map' was not declared. Should it be static?
@ 2019-10-16 18:16 kbuild test robot
  2019-10-16 18:16 ` [RFC PATCH linux-next] iommu: Add gfp parameter to iommu_ops:: __iommu_map() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-10-16 18:16 UTC (permalink / raw)
  To: Tom Murphy
  Cc: Joerg Roedel, kbuild-all, linux-kernel, iommu, Robin Murphy,
	Christoph Hellwig

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   78662bffde37ccbb66ac3311fa709d8960435e98
commit: 781ca2de89bae1b1d2c96df9ef33e9a324415995 [4470/4908] iommu: Add gfp parameter to iommu_ops::map
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-dirty
        git checkout 781ca2de89bae1b1d2c96df9ef33e9a324415995
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/iommu/iommu.c:292:5: sparse: sparse: symbol 'iommu_insert_resv_region' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH linux-next] iommu: Add gfp parameter to iommu_ops:: __iommu_map() can be static
  2019-10-16 18:16 [linux-next:master 4470/4908] drivers/iommu/iommu.c:1857:5: sparse: sparse: symbol '__iommu_map' was not declared. Should it be static? kbuild test robot
@ 2019-10-16 18:16 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-10-16 18:16 UTC (permalink / raw)
  To: Tom Murphy
  Cc: Joerg Roedel, kbuild-all, linux-kernel, iommu, Robin Murphy,
	Christoph Hellwig


Fixes: 781ca2de89ba ("iommu: Add gfp parameter to iommu_ops::map")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index f8853dbf1c4eb..89bfdbbfaa11b 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1854,7 +1854,7 @@ static size_t iommu_pgsize(struct iommu_domain *domain,
 	return pgsize;
 }
 
-int __iommu_map(struct iommu_domain *domain, unsigned long iova,
+static int __iommu_map(struct iommu_domain *domain, unsigned long iova,
 	      phys_addr_t paddr, size_t size, int prot, gfp_t gfp)
 {
 	const struct iommu_ops *ops = domain->ops;
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-16 18:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-16 18:16 [linux-next:master 4470/4908] drivers/iommu/iommu.c:1857:5: sparse: sparse: symbol '__iommu_map' was not declared. Should it be static? kbuild test robot
2019-10-16 18:16 ` [RFC PATCH linux-next] iommu: Add gfp parameter to iommu_ops:: __iommu_map() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox