public inbox for iommu@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Tony Luck <tony.luck@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
	Kyung Min Park <kyung.min.park@intel.com>,
	iommu@lists.linux-foundation.org, Longpeng <longpeng2@huawei.com>
Subject: [PATCH 7/9] iommu/vt-d: Clean up unused PASID updating functions
Date: Thu, 14 Oct 2021 13:38:37 +0800	[thread overview]
Message-ID: <20211014053839.727419-8-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20211014053839.727419-1-baolu.lu@linux.intel.com>

From: Fenghua Yu <fenghua.yu@intel.com>

update_pasid() and its call chain are currently unused in the tree because
Thomas disabled the ENQCMD feature. The feature will be re-enabled shortly
using a different approach and update_pasid() and its call chain will not
be used in the new approach.

Remove the useless functions.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20210920192349.2602141-1-fenghua.yu@intel.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 arch/x86/include/asm/fpu/api.h |  2 --
 drivers/iommu/intel/svm.c      | 24 +-----------------------
 2 files changed, 1 insertion(+), 25 deletions(-)

diff --git a/arch/x86/include/asm/fpu/api.h b/arch/x86/include/asm/fpu/api.h
index 23bef08a8388..ca4d0dee1ecd 100644
--- a/arch/x86/include/asm/fpu/api.h
+++ b/arch/x86/include/asm/fpu/api.h
@@ -106,6 +106,4 @@ extern int cpu_has_xfeatures(u64 xfeatures_mask, const char **feature_name);
  */
 #define PASID_DISABLED	0
 
-static inline void update_pasid(void) { }
-
 #endif /* _ASM_X86_FPU_API_H */
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index 0c228787704f..5b5d69b04fcc 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -505,21 +505,6 @@ int intel_svm_unbind_gpasid(struct device *dev, u32 pasid)
 	return ret;
 }
 
-static void _load_pasid(void *unused)
-{
-	update_pasid();
-}
-
-static void load_pasid(struct mm_struct *mm, u32 pasid)
-{
-	mutex_lock(&mm->context.lock);
-
-	/* Update PASID MSR on all CPUs running the mm's tasks. */
-	on_each_cpu_mask(mm_cpumask(mm), _load_pasid, NULL, true);
-
-	mutex_unlock(&mm->context.lock);
-}
-
 static int intel_svm_alloc_pasid(struct device *dev, struct mm_struct *mm,
 				 unsigned int flags)
 {
@@ -614,10 +599,6 @@ static struct iommu_sva *intel_svm_bind_mm(struct intel_iommu *iommu,
 	if (ret)
 		goto free_sdev;
 
-	/* The newly allocated pasid is loaded to the mm. */
-	if (!(flags & SVM_FLAG_SUPERVISOR_MODE) && list_empty(&svm->devs))
-		load_pasid(mm, svm->pasid);
-
 	list_add_rcu(&sdev->list, &svm->devs);
 success:
 	return &sdev->sva;
@@ -670,11 +651,8 @@ static int intel_svm_unbind_mm(struct device *dev, u32 pasid)
 			kfree_rcu(sdev, rcu);
 
 			if (list_empty(&svm->devs)) {
-				if (svm->notifier.ops) {
+				if (svm->notifier.ops)
 					mmu_notifier_unregister(&svm->notifier, mm);
-					/* Clear mm's pasid. */
-					load_pasid(mm, PASID_DISABLED);
-				}
 				pasid_private_remove(svm->pasid);
 				/* We mandate that no page faults may be outstanding
 				 * for the PASID when intel_svm_unbind_mm() is called.
-- 
2.25.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  parent reply	other threads:[~2021-10-14  5:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  5:38 [PATCH 0/9] [PULL REQUEST] Intel IOMMU Updates for Linux v5.16 Lu Baolu
2021-10-14  5:38 ` [PATCH 1/9] iommu/vt-d: Do not falsely log intel_iommu is unsupported kernel option Lu Baolu
2021-10-14  5:38 ` [PATCH 2/9] iommu/vt-d: Dump DMAR translation structure when DMA fault occurs Lu Baolu
2021-10-14  5:38 ` [PATCH 3/9] iommu/vt-d: Remove duplicate identity domain flag Lu Baolu
2021-10-14  5:38 ` [PATCH 4/9] iommu/vt-d: Check FL and SL capability sanity in scalable mode Lu Baolu
2021-10-14  5:38 ` [PATCH 5/9] iommu/vt-d: Use second level for GPA->HPA translation Lu Baolu
2021-10-14  5:38 ` [PATCH 6/9] iommu/vt-d: Delete dev_has_feat callback Lu Baolu
2021-10-14  5:38 ` Lu Baolu [this message]
2021-10-14  5:38 ` [PATCH 8/9] iommu/vt-d: Convert the return type of first_pte_in_page to bool Lu Baolu
2021-10-14  5:38 ` [PATCH 9/9] iommu/vt-d: Avoid duplicate removing in __domain_mapping() Lu Baolu
2021-10-18 18:33 ` [PATCH 0/9] [PULL REQUEST] Intel IOMMU Updates for Linux v5.16 Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014053839.727419-8-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kyung.min.park@intel.com \
    --cc=longpeng2@huawei.com \
    --cc=tony.luck@intel.com \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox