From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Kevin Tian <kevin.tian@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Kyung Min Park <kyung.min.park@intel.com>,
iommu@lists.linux-foundation.org, Longpeng <longpeng2@huawei.com>
Subject: [PATCH 8/9] iommu/vt-d: Convert the return type of first_pte_in_page to bool
Date: Thu, 14 Oct 2021 13:38:38 +0800 [thread overview]
Message-ID: <20211014053839.727419-9-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20211014053839.727419-1-baolu.lu@linux.intel.com>
From: "Longpeng(Mike)" <longpeng2@huawei.com>
The first_pte_in_page() returns true or false, so let's convert its
return type to bool. In addition, use 'IS_ALIGNED' to make the
code more readable and neater.
Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
Link: https://lore.kernel.org/r/20211008000433.1115-1-longpeng2@huawei.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
include/linux/intel-iommu.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
index 65b15af3cf1a..52481625838c 100644
--- a/include/linux/intel-iommu.h
+++ b/include/linux/intel-iommu.h
@@ -705,9 +705,9 @@ static inline bool dma_pte_superpage(struct dma_pte *pte)
return (pte->val & DMA_PTE_LARGE_PAGE);
}
-static inline int first_pte_in_page(struct dma_pte *pte)
+static inline bool first_pte_in_page(struct dma_pte *pte)
{
- return !((unsigned long)pte & ~VTD_PAGE_MASK);
+ return IS_ALIGNED((unsigned long)pte, VTD_PAGE_SIZE);
}
extern struct dmar_drhd_unit * dmar_find_matched_drhd_unit(struct pci_dev *dev);
--
2.25.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-10-14 5:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 5:38 [PATCH 0/9] [PULL REQUEST] Intel IOMMU Updates for Linux v5.16 Lu Baolu
2021-10-14 5:38 ` [PATCH 1/9] iommu/vt-d: Do not falsely log intel_iommu is unsupported kernel option Lu Baolu
2021-10-14 5:38 ` [PATCH 2/9] iommu/vt-d: Dump DMAR translation structure when DMA fault occurs Lu Baolu
2021-10-14 5:38 ` [PATCH 3/9] iommu/vt-d: Remove duplicate identity domain flag Lu Baolu
2021-10-14 5:38 ` [PATCH 4/9] iommu/vt-d: Check FL and SL capability sanity in scalable mode Lu Baolu
2021-10-14 5:38 ` [PATCH 5/9] iommu/vt-d: Use second level for GPA->HPA translation Lu Baolu
2021-10-14 5:38 ` [PATCH 6/9] iommu/vt-d: Delete dev_has_feat callback Lu Baolu
2021-10-14 5:38 ` [PATCH 7/9] iommu/vt-d: Clean up unused PASID updating functions Lu Baolu
2021-10-14 5:38 ` Lu Baolu [this message]
2021-10-14 5:38 ` [PATCH 9/9] iommu/vt-d: Avoid duplicate removing in __domain_mapping() Lu Baolu
2021-10-18 18:33 ` [PATCH 0/9] [PULL REQUEST] Intel IOMMU Updates for Linux v5.16 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014053839.727419-9-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kyung.min.park@intel.com \
--cc=longpeng2@huawei.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox