From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dma-pool: limit DMA and DMA32 zone size pools
Date: Sun, 21 Aug 2022 12:43:21 +0200 [thread overview]
Message-ID: <20220821104321.GB30530@lst.de> (raw)
In-Reply-To: <04790bd9-4f20-4d51-b988-ad4b44eeee98@arm.com>
On Wed, Aug 17, 2022 at 01:50:09PM +0100, Robin Murphy wrote:
>> +#if defined(CONFIG_ZONE_DMA) || defined(CONFIG_ZONE_DMA32)
>
> This #ifdeffery seems horribly clunky - I think it would be much nicer to
> mark this __maybe_unused, and preserve the has_managed_dma/IS_ENABLED logic
> below.
>> static int __init dma_atomic_pool_init(void)
>> {
>> + unsigned long nr_zone_dma_pages, nr_zone_dma32_pages;
>
> ...otherwise, I expect the buildbots will be along shortly with unused
> variable warnings for these :)
Amazingly they haven't complained yet, even if they should. But
simple IS_ENABLED won't work either as the ZONE_DMA / ZONE_DMA32
constants are not defined unless the corresponding config options
are set. I'll see what I can do here using helpers.
next prev parent reply other threads:[~2022-08-21 10:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 6:06 fix dma coherent pool sizing Christoph Hellwig
2022-08-17 6:06 ` [PATCH 1/3] dma-pool: factor out a calculate_pool_size helper Christoph Hellwig
2022-08-17 12:32 ` Robin Murphy
2022-08-21 10:41 ` Christoph Hellwig
2022-08-17 6:06 ` [PATCH 2/3] dma-pool: don't return errors from dma_atomic_pool_init Christoph Hellwig
2022-08-17 12:36 ` Robin Murphy
2022-08-17 6:06 ` [PATCH 3/3] dma-pool: limit DMA and DMA32 zone size pools Christoph Hellwig
2022-08-17 12:50 ` Robin Murphy
2022-08-21 10:43 ` Christoph Hellwig [this message]
2022-08-17 12:53 ` Michal Hocko
2022-08-21 10:44 ` Christoph Hellwig
2022-08-22 8:41 ` Michal Hocko
2022-08-22 11:14 ` Christoph Hellwig
2022-08-22 12:09 ` Michal Hocko
2022-08-22 12:27 ` Christoph Hellwig
2022-08-22 14:21 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2022-08-22 6:12 fix dma coherent pool sizing Christoph Hellwig
2022-08-22 6:12 ` [PATCH 3/3] dma-pool: limit DMA and DMA32 zone size pools Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821104321.GB30530@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox