From: Jason Gunthorpe <jgg@nvidia.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
kevin.tian@intel.com, nicolinc@nvidia.com, mshavit@google.com,
eric.auger@redhat.com, joao.m.martins@oracle.com,
jiangkunkun@huawei.com, zhukeqian1@huawei.com,
linuxarm@huawei.com
Subject: Re: [PATCH 3/5] iommu/arm-smmu-v3: Add read_and_clear_dirty() support
Date: Wed, 29 Nov 2023 15:35:06 -0400 [thread overview]
Message-ID: <20231129193506.GB436702@nvidia.com> (raw)
In-Reply-To: <20231128094940.1344-4-shameerali.kolothum.thodi@huawei.com>
On Tue, Nov 28, 2023 at 09:49:38AM +0000, Shameer Kolothum wrote:
> +static int arm_smmu_read_and_clear_dirty(struct iommu_domain *domain,
> + unsigned long iova, size_t size,
> + unsigned long flags,
> + struct iommu_dirty_bitmap *dirty)
> +{
> + struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain);
> + struct io_pgtable_ops *ops = smmu_domain->pgtbl_ops;
> + int ret;
> +
> + if (smmu_domain->stage != ARM_SMMU_DOMAIN_S1)
> + return -EINVAL;
> +
> + if (!ops || !ops->read_and_clear_dirty) {
> + pr_err_once("io-pgtable don't support dirty tracking\n");
> + return -ENODEV;
All these prints concern me, either these can never happen due to
constraints on the caller, eg iommufd, in which case use WARN_ON_ONCe
Or iommufd does allow these improper things and thus it should
silently fail.
Jason
next prev parent reply other threads:[~2023-11-29 19:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 9:49 [PATCH 0/5] iommu/smmuv3: Add IOMMUFD dirty tracking support for SMMUv3 Shameer Kolothum
2023-11-28 9:49 ` [PATCH 1/5] iommu/arm-smmu-v3: Add feature detection for HTTU Shameer Kolothum
2023-11-29 19:49 ` Jason Gunthorpe
2023-11-28 9:49 ` [PATCH 2/5] iommu/arm-smmu-v3: Enable HTTU for stage1 with io-pgtable mapping Shameer Kolothum
2023-11-29 19:30 ` Jason Gunthorpe
2023-11-30 9:17 ` Shameerali Kolothum Thodi
2023-11-28 9:49 ` [PATCH 3/5] iommu/arm-smmu-v3: Add read_and_clear_dirty() support Shameer Kolothum
2023-11-29 19:35 ` Jason Gunthorpe [this message]
2023-11-30 9:05 ` Shameerali Kolothum Thodi
2023-11-28 9:49 ` [PATCH 4/5] iommu/arm-smmu-v3: Add set_dirty_tracking() support Shameer Kolothum
2023-11-29 19:42 ` Jason Gunthorpe
2023-11-30 8:56 ` Shameerali Kolothum Thodi
2023-11-30 12:54 ` Jason Gunthorpe
2023-11-30 14:04 ` Shameerali Kolothum Thodi
2023-12-14 16:23 ` Joao Martins
2023-11-28 9:49 ` [PATCH 5/5] iommu/arm-smmu-v3: Enforce dirty tracking in domain attach/alloc Shameer Kolothum
2023-11-29 19:48 ` Jason Gunthorpe
2023-11-30 9:01 ` Shameerali Kolothum Thodi
2023-12-14 16:29 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129193506.GB436702@nvidia.com \
--to=jgg@nvidia.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jiangkunkun@huawei.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox