Re: [PATCH rc] iommu/sva: Restore SVA handle sharing

[Jason Gunthorpe <jgg@nvidia.com>]

On Mon, Feb 26, 2024 at 04:38:52PM +0800, Zhangfei Gao wrote:
> Hi, Jason
> 
> I am testing on 6.8-rc6 with more test and found one issue, sorry about this.
> When test openssl rsa, it will use two devices, one is sec, the other is hpre.
> I found the second handle can not be shared since bind_dev directly
> goto out but not add_list.
> 
> So still need a minor fix like this
> 
>     iommu/sva: Fix SVA handle sharing in multi device case
> 
> 
>     iommu_sva_bind_device will directly goto out in multi-device
>     case when found existing domain, ignoring list_add handle,
>     which causes the handle to fail to be shared.
> 
>     Fixs: 65d4418c5002 (iommu/sva: Restore SVA handle sharing)
>     Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> 
> diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c
> index 7f91c8d0064b..b1f3a864e124 100644
> --- a/drivers/iommu/iommu-sva.c
> +++ b/drivers/iommu/iommu-sva.c
> @@ -117,11 +117,10 @@ struct iommu_sva *iommu_sva_bind_device(struct
> device *dev, struct mm_struct *mm
>         if (ret)
>                 goto out_free_domain;
>         domain->users = 1;
> -       refcount_set(&handle->users, 1);
>         list_add(&domain->next, &mm->iommu_mm->sva_domains);
> -       list_add(&handle->handle_item, &mm->iommu_mm->sva_handles);
> 
>  out:
> +       refcount_set(&handle->users, 1);
> +       list_add(&handle->handle_item, &mm->iommu_mm->sva_handles);
>         mutex_unlock(&iommu_sva_lock);
>         handle->dev = dev;
>         handle->domain = domain;
> 
> What do you think.

Yes, please send a patch

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason