From: Pranjal Shrivastava <praan@google.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: Mostafa Saleh <smostafa@google.com>,
iommu@lists.linux.dev, Daniel Mentz <danielmentz@google.com>,
Pranjal Shrivastava <praan@google.com>
Subject: [PATCH] iommu/arm-smmu-v3: Use str_read_write helper w/ logs
Date: Tue, 7 Jan 2025 16:51:00 +0000 [thread overview]
Message-ID: <20250107165100.1093357-1-praan@google.com> (raw)
Adopt the `str_read_write` helper in event logging as highlighted [1].
[1] https://lore.kernel.org/all/20250107130053.GC6991@willie-the-truck/
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index 34b424c87be0..0e4cbb2c64d7 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -1907,7 +1907,7 @@ static void arm_smmu_dump_event(struct arm_smmu_device *smmu, u64 *raw,
dev_err(smmu->dev, "%s %s %s %s \"%s\"%s%s stag: %#x",
evt->privileged ? "priv" : "unpriv",
evt->instruction ? "inst" : "data",
- evt->read ? "read" : "write",
+ str_read_write(evt->read),
evt->s2 ? "s2" : "s1", event_class_str[evt->class],
evt->class_tt ? (evt->ttrnw ? " ttd_read" : " ttd_write") : "",
evt->stall ? " stall" : "", evt->stag);
--
2.47.1.613.gc27f4b7a9f-goog
next reply other threads:[~2025-01-07 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250110111804eucas1p2a5fa56e1a9fabbba5dacd4486517c9fe@eucas1p2.samsung.com>
2025-01-07 16:51 ` Pranjal Shrivastava [this message]
2025-01-07 22:21 ` [PATCH] iommu/arm-smmu-v3: Use str_read_write helper w/ logs Nicolin Chen
2025-01-08 16:38 ` Will Deacon
2025-01-10 11:18 ` Marek Szyprowski
2025-01-10 12:53 ` Will Deacon
2025-01-10 13:17 ` Will Deacon
2025-01-10 16:25 ` Will Deacon
2025-01-10 17:47 ` Pranjal Shrivastava
2025-01-14 19:08 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107165100.1093357-1-praan@google.com \
--to=praan@google.com \
--cc=danielmentz@google.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox