Re: [PATCH] iommu/arm-smmu-v3: Use str_read_write helper w/ logs

[Pranjal Shrivastava <praan@google.com>]

> > > On Fri, Jan 10, 2025 at 12:18:02PM +0100, Marek Szyprowski wrote:
> > > > On 07.01.2025 17:51, Pranjal Shrivastava wrote:
> > > > > Adopt the `str_read_write` helper in event logging as highlighted [1].
> > > > >
> > > > > [1] https://lore.kernel.org/all/20250107130053.GC6991@willie-the-truck/
> > > > >
> > > > > Signed-off-by: Pranjal Shrivastava <praan@google.com>
> > > > 
> > > > This change landed in today's linux-next as commit f2c77f6e41e6 
> > > > ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs"). It fails to 
> > > > build here with arm64/defconfig on my setup. It looks that it misses to 
> > > > add the following include:
> > > > 
> > > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c 
> > > > b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > > > index 0e4cbb2c64d7..a0e395da8a88 100644
> > > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > > > @@ -26,6 +26,7 @@
> > > >   #include <linux/pci.h>
> > > >   #include <linux/pci-ats.h>
> > > >   #include <linux/platform_device.h>
> > > > +#include <linux/string_choices.h>
> > > >   #include <kunit/visibility.h>
> > > >   #include <uapi/linux/iommufd.h>
> > > 
> > > Hmm, I build and test my branches before I push them so this is a bit
> > > surprising. I just confirmed that it's building with arm64/defconfig
> > > for me, so lemme dig into this some more...
> > 
> > Aha, there seems to be a transitive include of string_choices.h via
> > linux/acpi.h. So while I still think the arm64 defconfig should build,
> > if I go in and disable CONFIG_ACPI then I see the failure.
> > 
> > So for my test builds:
> > allnoconfig:	Builds as there isn't an SMMU driver
> > defconfig:	Builds because CONFIG_ACPI=y
> > allmodconfig:	Same as above
> > 

Ahh, apologies for not building with CONFIG_ACPI=n, I'll be more
careful next time!

> > I'll add the missing #include.
> 
> I pushed the fix to arm/smmu/updates [1] which should appear in -next
> when Joerg next rebuilds the branch.

Thanks for fixing this!
Regards,
Praan