From: Jason Gunthorpe <jgg@ziepe.ca>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Will Deacon <will@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
joro@8bytes.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, heiko@sntech.de,
nicolas.dufresne@collabora.com, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v6 3/5] iommu: Add verisilicon IOMMU driver
Date: Fri, 18 Jul 2025 10:26:22 -0300 [thread overview]
Message-ID: <20250718132622.GC2206214@ziepe.ca> (raw)
In-Reply-To: <b4169471-fcd0-4415-8281-c5bd722e5f2b@arm.com>
On Fri, Jul 18, 2025 at 01:56:36PM +0100, Robin Murphy wrote:
> All they really have in common is that they're 2-level formats with 32-bit
> PTEs and 10 bits per level (as is tegra-smmu too). The permission encodings
> have some overlap but are not fully equivalent. Crucially, the schemes for
> packing >32-bit PAs into PTEs are incompatibly different, so if you're
> really keen to genericise things to *that* extent, that's what Jason's
> already working on.
Right, I agree with this. The page table code is duplicated
extensively across iommu and the way to fix it is what I'm working on.
It is all the same code, same patterns, same problems, same bugs :)
I think it is best to leave this as is for now.
Jason
next prev parent reply other threads:[~2025-07-18 13:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 8:24 [PATCH v6 0/5] Add support for Verisilicon IOMMU used by media codec blocks Benjamin Gaignard
2025-07-10 8:24 ` [PATCH v6 1/5] dt-bindings: vendor-prefixes: Add Verisilicon Benjamin Gaignard
2025-07-10 8:24 ` [PATCH v6 2/5] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU Benjamin Gaignard
2025-07-10 8:24 ` [PATCH v6 3/5] iommu: Add verisilicon IOMMU driver Benjamin Gaignard
2025-07-14 12:08 ` Will Deacon
2025-07-14 14:56 ` Benjamin Gaignard
2025-07-18 11:45 ` Will Deacon
2025-07-18 12:56 ` Robin Murphy
2025-07-18 13:26 ` Jason Gunthorpe [this message]
2025-07-18 13:47 ` Will Deacon
2025-07-18 14:14 ` Jason Gunthorpe
2025-07-21 11:14 ` Benjamin Gaignard
2025-07-21 17:00 ` Will Deacon
2025-07-10 8:24 ` [PATCH v6 4/5] arm64: dts: rockchip: Add verisilicon IOMMU node on RK3588 Benjamin Gaignard
2025-07-10 8:24 ` [PATCH v6 5/5] arm64: defconfig: enable Verisilicon IOMMU Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718132622.GC2206214@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox