Re: [PATCH v6 3/5] iommu: Add verisilicon IOMMU driver

[Benjamin Gaignard <benjamin.gaignard@collabora.com>]

Le 18/07/2025 à 16:14, Jason Gunthorpe a écrit :
> On Fri, Jul 18, 2025 at 02:47:11PM +0100, Will Deacon wrote:
>
>> Just because the existing drivers are a mess doesn't mean we should
>> proliferate it!
> If you want to insist on something here it should be for this driver
> to use the new generic page table code I've written.
>
> Otherwise I don't see the point in trying to improve this in some
> lesser way.
>
> If this had come in a years time I would probably insist on that, but
> right now it isn't merged yet and it will still be a little bit before
> people have time to review it.
>
> Perhaps a compromise where Benjamin comes with an iommupt format
> header that works for this and we can progress this series and be
> ready to swap it out down the road?

I have take some time to try to understand this new framework and I have
to admit it isn't super clear in my mind how to use it right now.
I don't have catch the benefit behind the macro and the nested structures.

Anyway, if VSI driver need to be updated I could, at least, validate the
changes on my board or make the fix make self (but I will need to see
more example of drivers using this new feature.

Benjamin

>
> Jason