From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Yi Liu <yi.l.liu@intel.com>
Cc: joro@8bytes.org, kevin.tian@intel.com, iommu@lists.linux.dev,
jacob.pan@linux.microsoft.com, robin.murphy@arm.com,
nicolinc@nvidia.com, will@kernel.org
Subject: Re: [PATCH 1/2] iommu: Store either domain or handle in group->pasid_array
Date: Tue, 21 Jan 2025 10:02:11 +0800 [thread overview]
Message-ID: <220d60c8-036e-4394-85e6-334a8d09a8fd@linux.intel.com> (raw)
In-Reply-To: <20250120155535.GK5556@nvidia.com>
On 1/20/25 23:55, Jason Gunthorpe wrote:
>> @@ -3397,10 +3400,14 @@ int iommu_attach_device_pasid(struct iommu_domain *domain,
>> }
>> }
>>
>> - if (handle)
>> + if (handle) {
>> handle->domain = domain;
>> + xa_entry = xa_tag_pointer(handle, IOMMU_PASID_ARRAY_HANDLE);
>> + } else {
>> + xa_entry = xa_tag_pointer(domain, IOMMU_PASID_ARRAY_DOMAIN);
>> + }
> What about iommu_attach_group_handle() ?
>
> mutex_lock(&group->mutex);
> ret = xa_insert(&group->pasid_array, IOMMU_NO_PASID, handle, GFP_KERNEL);
> if (ret)
>
> And iommu_replace_group_handle() ?
>
> curr = xa_store(&group->pasid_array, IOMMU_NO_PASID, handle, GFP_KERNEL);
>
> I think it should be consistent and it should call xa_tag_poiner() too
> (even though it implicitly always is since the domain is stored in the
> group)??
We may eventually consider retiring group->domain.
---
baolu
next prev parent reply other threads:[~2025-01-21 2:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 3:08 [PATCH 0/2] Two enhancements to iommu_attach_device_pasid() Yi Liu
2025-01-20 3:08 ` [PATCH 1/2] iommu: Store either domain or handle in group->pasid_array Yi Liu
2025-01-20 5:55 ` Tian, Kevin
2025-01-20 15:55 ` Jason Gunthorpe
2025-01-21 2:02 ` Baolu Lu [this message]
2025-01-21 7:22 ` Yi Liu
2025-01-20 3:08 ` [PATCH 2/2] iommu: Swap the order of setting group->pasid_array and __iommu_set_group_pasid() Yi Liu
2025-01-20 5:58 ` Tian, Kevin
2025-01-20 6:57 ` Yi Liu
2025-01-20 16:13 ` Jason Gunthorpe
2025-01-21 9:27 ` Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220d60c8-036e-4394-85e6-334a8d09a8fd@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox