From: Yi Liu <yi.l.liu@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"jgg@nvidia.com" <jgg@nvidia.com>
Cc: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"jacob.pan@linux.microsoft.com" <jacob.pan@linux.microsoft.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"will@kernel.org" <will@kernel.org>
Subject: Re: [PATCH 2/2] iommu: Swap the order of setting group->pasid_array and __iommu_set_group_pasid()
Date: Mon, 20 Jan 2025 14:57:28 +0800 [thread overview]
Message-ID: <ceb12e1f-c052-44e4-a700-c9154109dc83@intel.com> (raw)
In-Reply-To: <BN9PR11MB5276B907CFD594D7A49349938CE72@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2025/1/20 13:58, Tian, Kevin wrote:
>> From: Yi Liu <yi.l.liu@intel.com>
>> Sent: Monday, January 20, 2025 11:09 AM
>>
>> - ret = xa_insert(&group->pasid_array, pasid, xa_entry, GFP_KERNEL);
>> - if (ret)
>> - goto out_unlock;
>> + curr = xa_store(&group->pasid_array, pasid, handle, GFP_KERNEL);
>> + if (curr) {
>> + __iommu_remove_group_pasid(group, pasid, domain);
>> + ret = xa_err(curr);
>> + }
>>
>
> s/handle/xa_entry/
oops. will fix it.
> btw you may continue to use xa_insert() to save one line for xa_err()
got it.
--
Regards,
Yi Liu
next prev parent reply other threads:[~2025-01-20 6:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 3:08 [PATCH 0/2] Two enhancements to iommu_attach_device_pasid() Yi Liu
2025-01-20 3:08 ` [PATCH 1/2] iommu: Store either domain or handle in group->pasid_array Yi Liu
2025-01-20 5:55 ` Tian, Kevin
2025-01-20 15:55 ` Jason Gunthorpe
2025-01-21 2:02 ` Baolu Lu
2025-01-21 7:22 ` Yi Liu
2025-01-20 3:08 ` [PATCH 2/2] iommu: Swap the order of setting group->pasid_array and __iommu_set_group_pasid() Yi Liu
2025-01-20 5:58 ` Tian, Kevin
2025-01-20 6:57 ` Yi Liu [this message]
2025-01-20 16:13 ` Jason Gunthorpe
2025-01-21 9:27 ` Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb12e1f-c052-44e4-a700-c9154109dc83@intel.com \
--to=yi.l.liu@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox