Re: [PATCH V7 9/9] iommufd: map file selftest

[Steven Sistare <steven.sistare@oracle.com>]

On 10/25/2024 1:04 PM, Nicolin Chen wrote:
> On Fri, Oct 25, 2024 at 06:11:59AM -0700, Steve Sistare wrote:
>>
>> Add test cases to exercise IOMMU_IOAS_MAP_FILE.
>>
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
> 
> The build passes, but I now see a few failing tests. Any idea?

Strange.  All tests pass for me, with patches applied to base commit
e2d8fe9148b79ed1cbf0663edc988db7769173dc

   # modprobe iomufd
   # iommufd
   ...
   Totals: pass:204 fail:0 xfail:0 xpass:0 skip:0 error:0

However, I also needed this patch from Yi Liu to make it work:
[2] https://github.com/yiliu1765/iommufd/commit/ff0772d155c1ae2841e7b7ff0d7ca889271b81b2

Without that, most tests fail, even before my series.

I will try to reproduce your failures.
What is your base commit?
What is your value of /sys/kernel/mm/transparent_hugepage/shmem_enabled ?
   (both always and never pass for me)

- Steve

> #  RUN           iommufd_mock_domain.one_domain_file.basic ...
> # iommufd.c:1521:basic:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, 0, PAGE_SIZE, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
> # basic: Test terminated by assertion
> #          FAIL  iommufd_mock_domain.one_domain_file.basic
> not ok 136 iommufd_mock_domain.one_domain_file.basic
> #  RUN           iommufd_mock_domain.one_domain_file.ro_unshare ...
> #            OK  iommufd_mock_domain.one_domain_file.ro_unshare
> ok 137 iommufd_mock_domain.one_domain_file.ro_unshare
> #  RUN           iommufd_mock_domain.one_domain_file.all_aligns ...
> # iommufd.c:1602:all_aligns:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, start, length, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
> # all_aligns: Test terminated by assertion
> #          FAIL  iommufd_mock_domain.one_domain_file.all_aligns
> not ok 138 iommufd_mock_domain.one_domain_file.all_aligns
> #  RUN           iommufd_mock_domain.one_domain_file.all_aligns_copy ...
> # iommufd.c:1656:all_aligns_copy:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, start, length, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
> # all_aligns_copy: Test terminated by assertion
> #          FAIL  iommufd_mock_domain.one_domain_file.all_aligns_copy
> not ok 139 iommufd_mock_domain.one_domain_file.all_aligns_copy
> #  RUN           iommufd_mock_domain.one_domain_file.user_copy ...
> # iommufd.c:1712:user_copy:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, ioas_id, mfd, 0, BUFFER_SIZE, &copy_cmd.src_iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
> # user_copy: Test terminated by assertion
> #          FAIL  iommufd_mock_domain.one_domain_file.user_copy
> not ok 140 iommufd_mock_domain.one_domain_file.user_copy
> #  RUN           iommufd_mock_domain.one_domain_file.replace ...
> #            OK  iommufd_mock_domain.one_domain_file.replace
> ok 141 iommufd_mock_domain.one_domain_file.replace
> #  RUN           iommufd_mock_domain.one_domain_file.alloc_hwpt ...
> #            OK  iommufd_mock_domain.one_domain_file.alloc_hwpt
> ok 142 iommufd_mock_domain.one_domain_file.alloc_hwpt
> #  RUN           iommufd_mock_domain.one_domain_file_hugepage.basic ...
> # iommufd.c:1521:basic:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, 0, PAGE_SIZE, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
> # basic: Test terminated by assertion
> #          FAIL  iommufd_mock_domain.one_domain_file_hugepage.basic
> not ok 143 iommufd_mock_domain.one_domain_file_hugepage.basic
> #  RUN           iommufd_mock_domain.one_domain_file_hugepage.ro_unshare ...
> #            OK  iommufd_mock_domain.one_domain_file_hugepage.ro_unshare
> ok 144 iommufd_mock_domain.one_domain_file_hugepage.ro_unshare
> #  RUN           iommufd_mock_domain.one_domain_file_hugepage.all_aligns ...
> #            OK  iommufd_mock_domain.one_domain_file_hugepage.all_aligns
> ok 145 iommufd_mock_domain.one_domain_file_hugepage.all_aligns
> #  RUN           iommufd_mock_domain.one_domain_file_hugepage.all_aligns_copy ...
> #            OK  iommufd_mock_domain.one_domain_file_hugepage.all_aligns_copy
> ok 146 iommufd_mock_domain.one_domain_file_hugepage.all_aligns_copy
> #  RUN           iommufd_mock_domain.one_domain_file_hugepage.user_copy ...
> # iommufd.c:1712:user_copy:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, ioas_id, mfd, 0, BUFFER_SIZE, &copy_cmd.src_iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
> # user_copy: Test terminated by assertion
> #          FAIL  iommufd_mock_domain.one_domain_file_hugepage.user_copy
> ...
> ok 2 basic_fail_nth.map_domain
> #  RUN           basic_fail_nth.map_file_domain ...
> # iommufd_fail_nth.c:338:map_file_domain:Expected 0 (0) == test_nth_map_file_domain(_metadata, self, variant, &nth_state) (-1)
> # map_file_domain: Test terminated by assertion
> #          FAIL  basic_fail_nth.map_file_domain
> not ok 3 basic_fail_nth.map_file_domain
>