Re: [PATCH V7 9/9] iommufd: map file selftest

Linux IOMMU Development
 help / color / mirror / Atom feed

From: Nicolin Chen <nicolinc@nvidia.com>
To: Steve Sistare <steven.sistare@oracle.com>
Cc: <iommu@lists.linux.dev>, Jason Gunthorpe <jgg@nvidia.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH V7 9/9] iommufd: map file selftest
Date: Fri, 25 Oct 2024 10:04:05 -0700	[thread overview]
Message-ID: <ZxvPhQZOBR7g56eh@Asurada-Nvidia> (raw)
In-Reply-To: <1729861919-234514-10-git-send-email-steven.sistare@oracle.com>

On Fri, Oct 25, 2024 at 06:11:59AM -0700, Steve Sistare wrote:
> 
> Add test cases to exercise IOMMU_IOAS_MAP_FILE.
> 
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>

The build passes, but I now see a few failing tests. Any idea?

#  RUN           iommufd_mock_domain.one_domain_file.basic ...
# iommufd.c:1521:basic:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, 0, PAGE_SIZE, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
# basic: Test terminated by assertion
#          FAIL  iommufd_mock_domain.one_domain_file.basic
not ok 136 iommufd_mock_domain.one_domain_file.basic
#  RUN           iommufd_mock_domain.one_domain_file.ro_unshare ...
#            OK  iommufd_mock_domain.one_domain_file.ro_unshare
ok 137 iommufd_mock_domain.one_domain_file.ro_unshare
#  RUN           iommufd_mock_domain.one_domain_file.all_aligns ...
# iommufd.c:1602:all_aligns:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, start, length, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
# all_aligns: Test terminated by assertion
#          FAIL  iommufd_mock_domain.one_domain_file.all_aligns
not ok 138 iommufd_mock_domain.one_domain_file.all_aligns
#  RUN           iommufd_mock_domain.one_domain_file.all_aligns_copy ...
# iommufd.c:1656:all_aligns_copy:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, start, length, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
# all_aligns_copy: Test terminated by assertion
#          FAIL  iommufd_mock_domain.one_domain_file.all_aligns_copy
not ok 139 iommufd_mock_domain.one_domain_file.all_aligns_copy
#  RUN           iommufd_mock_domain.one_domain_file.user_copy ...
# iommufd.c:1712:user_copy:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, ioas_id, mfd, 0, BUFFER_SIZE, &copy_cmd.src_iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
# user_copy: Test terminated by assertion
#          FAIL  iommufd_mock_domain.one_domain_file.user_copy
not ok 140 iommufd_mock_domain.one_domain_file.user_copy
#  RUN           iommufd_mock_domain.one_domain_file.replace ...
#            OK  iommufd_mock_domain.one_domain_file.replace
ok 141 iommufd_mock_domain.one_domain_file.replace
#  RUN           iommufd_mock_domain.one_domain_file.alloc_hwpt ...
#            OK  iommufd_mock_domain.one_domain_file.alloc_hwpt
ok 142 iommufd_mock_domain.one_domain_file.alloc_hwpt
#  RUN           iommufd_mock_domain.one_domain_file_hugepage.basic ...
# iommufd.c:1521:basic:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, self->ioas_id, mfd, 0, PAGE_SIZE, &iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
# basic: Test terminated by assertion
#          FAIL  iommufd_mock_domain.one_domain_file_hugepage.basic
not ok 143 iommufd_mock_domain.one_domain_file_hugepage.basic
#  RUN           iommufd_mock_domain.one_domain_file_hugepage.ro_unshare ...
#            OK  iommufd_mock_domain.one_domain_file_hugepage.ro_unshare
ok 144 iommufd_mock_domain.one_domain_file_hugepage.ro_unshare
#  RUN           iommufd_mock_domain.one_domain_file_hugepage.all_aligns ...
#            OK  iommufd_mock_domain.one_domain_file_hugepage.all_aligns
ok 145 iommufd_mock_domain.one_domain_file_hugepage.all_aligns
#  RUN           iommufd_mock_domain.one_domain_file_hugepage.all_aligns_copy ...
#            OK  iommufd_mock_domain.one_domain_file_hugepage.all_aligns_copy
ok 146 iommufd_mock_domain.one_domain_file_hugepage.all_aligns_copy
#  RUN           iommufd_mock_domain.one_domain_file_hugepage.user_copy ...
# iommufd.c:1712:user_copy:Expected 0 (0) == _test_ioctl_ioas_map_file( self->fd, ioas_id, mfd, 0, BUFFER_SIZE, &copy_cmd.src_iova, IOMMU_IOAS_MAP_WRITEABLE | IOMMU_IOAS_MAP_READABLE) (-1)
# user_copy: Test terminated by assertion
#          FAIL  iommufd_mock_domain.one_domain_file_hugepage.user_copy
...
ok 2 basic_fail_nth.map_domain
#  RUN           basic_fail_nth.map_file_domain ...
# iommufd_fail_nth.c:338:map_file_domain:Expected 0 (0) == test_nth_map_file_domain(_metadata, self, variant, &nth_state) (-1)
# map_file_domain: Test terminated by assertion
#          FAIL  basic_fail_nth.map_file_domain
not ok 3 basic_fail_nth.map_file_domain

next prev parent reply	other threads:[~2024-10-25 17:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 13:11 [PATCH V7 0/9] iommu_ioas_map_file Steve Sistare
2024-10-25 13:11 ` [PATCH V7 1/9] mm/gup: folio_add_pins Steve Sistare
2024-10-25 13:11 ` [PATCH V7 2/9] iommufd: rename uptr in iopt_alloc_iova Steve Sistare
2024-10-25 13:11 ` [PATCH V7 3/9] iommufd: generalize iopt_pages address Steve Sistare
2024-10-25 13:11 ` [PATCH V7 4/9] iommufd: pfn reader local variables Steve Sistare
2024-10-25 13:11 ` [PATCH V7 5/9] iommufd: folio subroutines Steve Sistare
2024-10-25 13:11 ` [PATCH V7 6/9] iommufd: pfn reader for file mappings Steve Sistare
2024-10-31  3:34   ` Alexey Kardashevskiy
2024-11-06  3:18     ` Alexey Kardashevskiy
2024-11-06 13:19       ` Steven Sistare
2024-11-07 10:00         ` Alexey Kardashevskiy
2024-11-07 13:21           ` Steven Sistare
2024-11-07 14:08           ` Jason Gunthorpe
2024-11-08  0:01             ` Alexey Kardashevskiy
2024-11-14  4:03               ` Alexey Kardashevskiy
2024-11-14 16:17                 ` Jason Gunthorpe
2024-11-18  1:24                   ` Alexey Kardashevskiy
2024-10-25 13:11 ` [PATCH V7 7/9] iommufd: IOMMU_IOAS_MAP_FILE Steve Sistare
2024-10-25 13:11 ` [PATCH V7 8/9] iommufd: file mappings for mdev Steve Sistare
2024-10-25 13:11 ` [PATCH V7 9/9] iommufd: map file selftest Steve Sistare
2024-10-25 13:14   ` Steven Sistare
2024-10-25 17:00     ` Nicolin Chen
2024-10-25 17:04   ` Nicolin Chen [this message]
2024-10-25 17:58     ` Steven Sistare
2024-10-25 18:39       ` Nicolin Chen
2024-10-25 23:58         ` Jason Gunthorpe
2024-10-26 19:13           ` Steven Sistare
2024-10-26 19:16             ` Steven Sistare
2024-10-26 23:09               ` Nicolin Chen
2024-10-27 14:38                 ` Steven Sistare
2024-10-30  0:11 ` [PATCH V7 0/9] iommu_ioas_map_file Jason Gunthorpe
2024-10-30 12:43   ` Steven Sistare
2024-11-04 13:58     ` Steven Sistare
2024-11-04 14:18       ` Jason Gunthorpe
2024-11-04 14:24         ` Steven Sistare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxvPhQZOBR7g56eh@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=kevin.tian@intel.com \
    --cc=steven.sistare@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox