* [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb
@ 2025-10-09 1:09 Aashish Sharma
2025-11-18 1:53 ` Baolu Lu
0 siblings, 1 reply; 2+ messages in thread
From: Aashish Sharma @ 2025-10-09 1:09 UTC (permalink / raw)
To: Vineeth Pillai, Lu Baolu, Dmytro Maluka, David Woodhouse,
Joerg Roedel, Tina Zhang
Cc: Robin Murphy, iommu, linux-kernel, Aashish Sharma, Aashish Sharma
Invalidation hint (ih) in the function 'qi_desc_iotlb' is
initialized to zero and never used. It is embedded in the 0th bit
of the 'addr' parameter. Get the correct 'ih' value from there.
Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition")
Signed-off-by: Aashish Sharma <aashish@aashishsharma.net>
---
drivers/iommu/intel/iommu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/iommu.h b/drivers/iommu/intel/iommu.h
index 3056583d7f56..dcc5466d35f9 100644
--- a/drivers/iommu/intel/iommu.h
+++ b/drivers/iommu/intel/iommu.h
@@ -1097,7 +1097,7 @@ static inline void qi_desc_iotlb(struct intel_iommu *iommu, u16 did, u64 addr,
struct qi_desc *desc)
{
u8 dw = 0, dr = 0;
- int ih = 0;
+ int ih = addr & 1;
if (cap_write_drain(iommu->cap))
dw = 1;
--
2.51.0.710.ga91ca5db03-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb
2025-10-09 1:09 [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb Aashish Sharma
@ 2025-11-18 1:53 ` Baolu Lu
0 siblings, 0 replies; 2+ messages in thread
From: Baolu Lu @ 2025-11-18 1:53 UTC (permalink / raw)
To: Aashish Sharma, Vineeth Pillai, Dmytro Maluka, David Woodhouse,
Joerg Roedel, Tina Zhang
Cc: Robin Murphy, iommu, linux-kernel, Aashish Sharma
On 10/9/25 09:09, Aashish Sharma wrote:
> Invalidation hint (ih) in the function 'qi_desc_iotlb' is
> initialized to zero and never used. It is embedded in the 0th bit
> of the 'addr' parameter. Get the correct 'ih' value from there.
>
> Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition")
> Signed-off-by: Aashish Sharma<aashish@aashishsharma.net>
> ---
> drivers/iommu/intel/iommu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Queued for v6.19-rc1. Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-18 1:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-09 1:09 [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb Aashish Sharma
2025-11-18 1:53 ` Baolu Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox